Uh oh!
There was an error while loading. Please reload this page.
test: add tests for console.assert - #6302
Closed
evanlucas wants to merge 1 commit into
Closed
Conversation
There were previously no tests where console.assert failed
evanlucas
commented
Apr 20, 2016
ContributorAuthor
santigimeno
commented
Apr 20, 2016
Member
LGTM |
3 similar comments
cjihrig
commented
Apr 20, 2016
Contributor
LGTM |
mscdex
commented
Apr 20, 2016
Contributor
LGTM |
Trott
commented
Apr 20, 2016
Member
LGTM |
jasnell pushed a commit
that referenced
this pull request
Apr 22, 2016
There were previously no tests where console.assert failed PR-URL: #6302 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
commented
Apr 22, 2016
Member
Landed in 84ebf2b |
evanlucas
commented
Apr 25, 2016
ContributorAuthor
Thanks @jasnell! |
joelostrowski pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
There were previously no tests where console.assert failed PR-URL: nodejs#6302 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Apr 26, 2016
There were previously no tests where console.assert failed PR-URL: #6302 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 18, 2016
There were previously no tests where console.assert failed PR-URL: #6302 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 18, 2016
There were previously no tests where console.assert failed PR-URL: #6302 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
There were previously no tests where console.assert failed