lib: add Temporal to frozen intrinsics

[Renegade334]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (8173251) to head (66cce03).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63029 +/- ##
==========================================
- Coverage 91.49% 89.64% -1.85% 
==========================================
Files 358 708 +350 Lines 151574 220389 +68815 Branches 23921 42263 +18342 ==========================================
+ Hits 138679 197570 +58891 - Misses 12619 14655 +2036 - Partials 276 8164 +7888 

Files with missing lines	Coverage Δ
lib/internal/freeze_intrinsics.js	96.97% <100.00%> (+0.08%)	⬆️

... and 471 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73025/

[ljharb]

you may also want to include Temporal.Now

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73031/

[Renegade334]

you may also want to include Temporal.Now

It's recursively covered by deepFreeze().

[ljharb]

Right, but i meant, you'd want to extract all the static methods inside Temporal.Now to be available as primordials.

[aduh95]

Right, but i meant, you'd want to extract all the static methods inside Temporal.Now

Those are recursively covered by deepFreeze:

node/lib/internal/freeze_intrinsics.js

Line 378 in 66054cc

ArrayPrototypeForEach(intrinsics,deepFreeze);

node/lib/internal/freeze_intrinsics.js

Lines 389 to 469 in 66054cc

	functiondeepFreeze(root){
	/**
	* "innerDeepFreeze()" acts like "Object.freeze()", except that:
	*
	* To deepFreeze an object is to freeze it and all objects transitively
	* reachable from it via transitive reflective property and prototype
	* traversal.
	*/
	functioninnerDeepFreeze(node){
	// Objects that we have frozen in this round.
	constfreezingSet=newSafeSet();
	// If val is something we should be freezing but aren't yet,
	// add it to freezingSet.
	functionenqueue(val){
	if(Object(val)!==val){
	// ignore primitives
	return;
	}
	consttype=typeofval;
	if(type!=='object'&&type!=='function'){
	// NB: handle for any new cases in future
	}
	if(frozenSet.has(val)||freezingSet.has(val)){
	// TODO: Use uncurried form
	// Ignore if already frozen or freezing
	return;
	}
	freezingSet.add(val);// TODO: Use uncurried form
	}
	functiondoFreeze(obj){
	// Immediately freeze the object to ensure reactive
	// objects such as proxies won't add properties
	// during traversal, before they get frozen.
	// Object are verified before being enqueued,
	// therefore this is a valid candidate.
	// Throws if this fails (strict mode).
	ObjectFreeze(obj);
	// We rely upon certain commitments of Object.freeze and proxies here
	// Get stable/immutable outbound links before a Proxy has a chance to do
	// something sneaky.
	constproto=ObjectGetPrototypeOf(obj);
	constdescs=ObjectGetOwnPropertyDescriptors(obj);
	enqueue(proto);
	ArrayPrototypeForEach(ReflectOwnKeys(descs),(name)=>{
	constdesc=descs[name];
	if(ObjectPrototypeHasOwnProperty(desc,'value')){
	// todo uncurried form
	enqueue(desc.value);
	}else{
	enqueue(desc.get);
	enqueue(desc.set);
	}
	});
	}
	functiondequeue(){
	// New values added before forEach() has finished will be visited.
	freezingSet.forEach(doFreeze);// TODO: Curried forEach
	}
	functioncommit(){
	// TODO: Curried forEach
	// We capture the real WeakSet.prototype.add above, in case someone
	// changes it. The two-argument form of forEach passes the second
	// argument as the 'this' binding, so we add to the correct set.
	freezingSet.forEach(frozenSet.add,frozenSet);
	}
	enqueue(node);
	dequeue();
	commit();
	}
	innerDeepFreeze(root);
	returnroot;
	}

to be available as primordials.

This has nothing to do with primordials though, it's about forbidding any mutation of intrinsics when node is run with --frozen-intrinsics.

[ljharb]

ah, sorry for my confusion.

[nodejs-github-bot]

Landed in 637a98a