Uh oh!
There was an error while loading. Please reload this page.
build: add temporary workaround for Rust on macOS - #63053
Closed
richardlau wants to merge 1 commit into
Closed
Conversation
Temporarily install the x64 Rust target on macOS at build time. To be removed when the target is installed at the macOS VM level. Signed-off-by: Richard Lau <richard.lau@ibm.com>
richardlau
commented
Apr 30, 2026
MemberAuthor
aduh95
approved these changes
Apr 30, 2026
nodejs-github-bot
commented
Apr 30, 2026
Collaborator
sxa
reviewed
Apr 30, 2026
sxa
left a comment
Member
There was a problem hiding this comment.
I approve in principle but will hold off on any formal approve/merge until @ryanaslett and I can determine if this change can be made on the orka images tomorrow.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #63053 +/- ##
==========================================
- Coverage 91.48% 89.65% -1.84%
==========================================
Files 358 708 +350 Lines 151591 220410 +68819 Branches 23925 42276 +18351 ==========================================
+ Hits 138690 197598 +58908 - Misses 12625 14659 +2034 - Partials 276 8153 +7877 🚀 New features to boost your workflow:
|
RafaelGSS
approved these changes
Apr 30, 2026
nodejs-github-bot
commented
Apr 30, 2026
Collaborator
anonrig
approved these changes
May 1, 2026
gurgunday
approved these changes
May 1, 2026
sxa
commented
May 1, 2026
Member
I'm going to close this now as we've built and redeployed an updated image including this by dwefault via nodejs/build#4316 and it has successful run in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily install the x64 Rust target on macOS at build time. To be removed when the target is installed at the macOS VM level.
Refs: #63015
Refs: nodejs/build#4316
This can land independently of nodejs/build#4316, but if it does land it should be reverted once nodejs/build#4316 is deployed onto the macOS VMs.