Uh oh!
There was an error while loading. Please reload this page.
lib,src: updates for BoringSSL - #63125
Closed
panva wants to merge 6 commits into
Closed
Conversation
panvaforce-pushed
the
make-crypto-boring-again
branch
2 times, most recently
from
May 5, 2026 13:30
121a7ab to
97a3c8fCompare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #63125 +/- ##
==========================================
- Coverage 90.03% 90.03% -0.01%
==========================================
Files 713 713 Lines 224950 224969 +19 Branches 42532 42560 +28 ==========================================
+ Hits 202542 202552 +10 - Misses 14175 14180 +5 - Partials 8233 8237 +4
🚀 New features to boost your workflow:
|
panvaforce-pushed
the
make-crypto-boring-again
branch
from
May 5, 2026 15:49
97a3c8f to
6b8d741Compare
This comment was marked as outdated.
This comment was marked as outdated.
panvaforce-pushed
the
make-crypto-boring-again
branch
from
May 5, 2026 17:17
6b8d741 to
db65e65Compare
This comment was marked as outdated.
This comment was marked as outdated.
panvaforce-pushed
the
make-crypto-boring-again
branch
3 times, most recently
from
May 6, 2026 19:13
078d5ed to
b88eca8Comparejasnell
approved these changes
May 7, 2026
jasnell
left a comment
Member
There was a problem hiding this comment.
LGTM but would be good to have @codebytere also take a look if they're available to do so.
MemberAuthor
panvaforce-pushed
the
make-crypto-boring-again
branch
3 times, most recently
from
May 8, 2026 08:53
8868f43 to
b2b116eCompareaduh95
reviewed
May 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
panvaforce-pushed
the
make-crypto-boring-again
branch
3 times, most recently
from
May 8, 2026 18:12
2a7cae8 to
cd86c6aCompareBoringSSL declares EVP_CIPHER_do_all_sorted and EVP_MD_do_all_sorted, but stock no-decrepit builds do not provide those symbols. Add a Node build flag that keeps ncrypto and its dependents on a local BoringSSL fallback list when libdecrepit is absent. Keep embedders that provide the EVP enumeration symbols on the normal OpenSSL-compatible path, matching Electron's patched BoringSSL build. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Add OPENSSL_WITH_* feature macros for crypto capabilities that vary by OpenSSL version and use those instead of repeating version checks. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panvaforce-pushed
the
make-crypto-boring-again
branch
from
May 8, 2026 23:15
cd86c6a to
02d372eCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wipIssues and PRs that are still a work in progress.