Skip to content

crypto: reject invalid raw key imports - #63134

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:raw-format-fixes
May 7, 2026
Merged

crypto: reject invalid raw key imports#63134
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:raw-format-fixes

Conversation

@panva

@panvapanva commented May 5, 2026

Copy link
Copy Markdown
Member

Fixes a couple edge cases related to raw key formats in node:crypto.

@panva
crypto: reject invalid raw key imports
03c121c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panvapanva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. labels May 5, 2026
@nodejs-github-bot

nodejs-github-bot commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 5, 2026
@codecov

codecovBot commented May 5, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.69231% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (18f938d) to head (03c121c).
⚠️ Report is 6 commits behind head on main.

Files with missing linesPatch %Lines
src/crypto/crypto_keys.cc60.37%2 Missing and 19 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63134 +/- ##
=======================================
Coverage 89.67% 89.68% =======================================
Files 712 712 Lines 221251 221305 +54 Branches 42393 42417 +24 =======================================
+ Hits 198413 198481 +68 + Misses 14681 14627 -54 - Partials 8157 8197 +40
Files with missing linesCoverage Δ
lib/internal/crypto/keys.js97.05% <100.00%> (+0.01%)⬆️
lib/internal/crypto/ml_kem.js94.66% <100.00%> (ø)
src/crypto/crypto_pqc.cc85.85% <100.00%> (+3.06%)⬆️
src/crypto/crypto_keys.cc71.59% <60.37%> (-1.25%)⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleaxaddaleax added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 5, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73191/

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 1fd4949 into nodejs:mainMay 7, 2026
97 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Landed in 1fd4949

@panva
panva deleted the raw-format-fixes branch May 7, 2026 19:02
aduh95 pushed a commit that referenced this pull request May 19, 2026
@panva@aduh95
crypto: reject invalid raw key imports
732d682
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63134
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2026
@panva@aduh95
crypto: reject invalid raw key imports
729274e
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63134
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2026
Merged
@panvapanva added the lts-watch-v24.x PRs that may need to be released in v24.x label May 21, 2026
@panvapanva added the backport-open-v24.x Indicate that the PR has an open backport label Jul 20, 2026
@panvapanva mentioned this pull request Jul 20, 2026
Closed
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@panva@aduh95
crypto: reject invalid raw key imports
eaeb9b6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63134
Backport-PR-URL: #64629
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95aduh95 mentioned this pull request Jul 21, 2026
Merged
@aduh95aduh95 removed the lts-watch-v24.x PRs that may need to be released in v24.x label Jul 21, 2026
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@panva@aduh95
crypto: reject invalid raw key imports
73c435b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63134
Backport-PR-URL: #64629
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@panva@aduh95
crypto: reject invalid raw key imports
c83b798
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63134
Backport-PR-URL: #64629
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panvapanva added backported-to-v24.x PRs backported to the v24.x-staging branch. and removed backport-open-v24.x Indicate that the PR has an open backport labels Aug 3, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@anonriganonriganonrig approved these changes
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backported-to-v24.xPRs backported to the v24.x-staging branch.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@panva@nodejs-github-bot@jasnell@addaleax@anonrig@aymen94@aduh95