Uh oh!
There was an error while loading. Please reload this page.
quic: ignore coverage for quic files - #63149
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
May 6, 2026
Collaborator
Review requested:
|
Since they aren't built by default Signed-off-by: James M Snell <jasnell@gmail.com>
jasnellforce-pushed
the
jasnell/ignore-quic-coverage
branch
from
May 6, 2026 11:30
1f7a03e to
3d65005CompareContributor
Fast-track has been requested by @jasnell. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
May 6, 2026
MoLow
approved these changes
May 6, 2026
pimterry
approved these changes
May 6, 2026
aymen94
approved these changes
May 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #63149 +/- ##
==========================================
+ Coverage 89.66% 90.06% +0.39%
==========================================
Files 713 713 Lines 224076 224257 +181 Branches 42308 42396 +88 ==========================================
+ Hits 200912 201970 +1058 + Misses 14996 14099 -897 - Partials 8168 8188 +20
🚀 New features to boost your workflow:
|
jasnell
commented
May 6, 2026
MemberAuthor
fedora build agents on jenkins are moving painfully slowly today because apparently the ccache was cleared. 3+ hrs and counting and it's not even yet completely done with the v8 part of the build. Once that finally does finish, and once I'm able to resume to clear up the one flaky failure that's there, I'll be able to get this landed. |
Collaborator
jasnell added a commit
that referenced
this pull request
May 6, 2026
Since they aren't built by default Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #63149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tim Perry <pimterry@gmail.com>
jasnell
commented
May 6, 2026
MemberAuthor
Landed in 3c2d2e3 |
aduh95 pushed a commit
that referenced
this pull request
May 19, 2026
Since they aren't built by default Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #63149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 19, 2026
Since they aren't built by default Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #63149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Since they aren't built by default Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#63149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
to aduh95/node
that referenced
this pull request
Aug 3, 2026
Since they aren't built by default Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#63149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tim Perry <pimterry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since they aren't built by default