Skip to content

deps: add missing static linking targets for libffi - #63168

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShogunPanda:ffi-missing-static-archs
May 11, 2026
Merged

deps: add missing static linking targets for libffi#63168
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShogunPanda:ffi-missing-static-archs

Conversation

@ShogunPanda

@ShogunPandaShogunPanda commented May 7, 2026

Copy link
Copy Markdown
Contributor

This ensures static linking of libffi wherever it is supported.

@ShogunPandaShogunPanda added the ffi Issues and PRs related to experimental Foreign Function Interface support. label May 7, 2026
@nodejs-github-bot

nodejs-github-bot commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi
  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 7, 2026
mcollina
mcollina approved these changes May 7, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

nodejs-github-bot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73246/

@nodejs-github-bot

nodejs-github-bot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73251/

@codecov

codecovBot commented May 8, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.01%. Comparing base (130398a) to head (c410a25).
⚠️ Report is 7 commits behind head on main.

Files with missing linesPatch %Lines
src/ffi/types.cc50.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63168 +/- ##
==========================================
- Coverage 90.03% 90.01% -0.03% 
==========================================
Files 713 713 Lines 224950 224950 Branches 42530 42526 -4 ==========================================
- Hits 202541 202491 -50 - Misses 14184 14237 +53 + Partials 8225 8222 -3
Files with missing linesCoverage Δ
src/ffi/types.cc48.91% <50.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95
aduh95 reviewed May 8, 2026
View reviewed changes
Comment threaddoc/api/ffi.md Outdated
aduh95
aduh95 reviewed May 8, 2026
View reviewed changes
Comment threaddeps/libffi/src/s390/sysv.S
@nodejs-github-bot

nodejs-github-bot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73256/

@nodejs-github-bot

nodejs-github-bot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73266/

@nodejs-github-bot

nodejs-github-bot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73270/

@nodejs-github-bot

nodejs-github-bot commented May 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73282/

@nodejs-github-bot

nodejs-github-bot commented May 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73289/

@nodejs-github-bot

nodejs-github-bot commented May 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73291/

@nodejs-github-bot

nodejs-github-bot commented May 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73305/

@nodejs-github-bot

nodejs-github-bot commented May 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73306/

@nodejs-github-bot

nodejs-github-bot commented May 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73310/

@ShogunPanda
ShogunPandaforce-pushed the ffi-missing-static-archs branch from 8231062 to 5b074f0CompareMay 10, 2026 05:50
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73314/

@nodejs-github-bot

nodejs-github-bot commented May 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73327/

@ShogunPanda
deps: add missing static linking targets for libffi
c410a25
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
@ShogunPanda
ShogunPandaforce-pushed the ffi-missing-static-archs branch from 5b074f0 to c410a25CompareMay 11, 2026 04:51
@nodejs-github-bot

nodejs-github-bot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73355/

@nodejs-github-bot

nodejs-github-bot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73358/

@mcollinamcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels May 11, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2026
@nodejs-github-bot
nodejs-github-bot merged commit a2aeb72 into nodejs:mainMay 11, 2026
68 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Landed in a2aeb72

@ShogunPanda
ShogunPanda deleted the ffi-missing-static-archs branch May 11, 2026 19:24
aduh95 pushed a commit that referenced this pull request May 19, 2026
@ShogunPanda@aduh95
deps: add missing static linking targets for libffi
2179f21
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
PR-URL: #63168
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit that referenced this pull request May 19, 2026
@ShogunPanda@aduh95
deps: add missing static linking targets for libffi
5ea6c3e
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
PR-URL: #63168
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 left review comments
@mcollinamcollinamcollina approved these changes
@anonriganonriganonrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@benglbenglAwaiting requested review from bengl
@addaleaxaddaleaxAwaiting requested review from addaleax

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.dependenciesPull requests that update a dependency file.ffiIssues and PRs related to experimental Foreign Function Interface support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ShogunPanda@nodejs-github-bot@mcollina@anonrig@richardlau@aduh95