Skip to content

[v24.x backport] crypto,doc: selected crypto changes - #63173

Merged
aduh95 merged 4 commits into
nodejs:v24.x-stagingfrom
panva:crypto-backports
May 9, 2026
Merged

[v24.x backport] crypto,doc: selected crypto changes#63173
aduh95 merged 4 commits into
nodejs:v24.x-stagingfrom
panva:crypto-backports

Conversation

@panva

@panvapanva commented May 7, 2026•
edited by aduh95
Loading

Copy link
Copy Markdown
Member

@panvapanva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label May 7, 2026
@nodejs-github-bot

nodejs-github-bot commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels May 7, 2026
@panvapanva changed the title crypto: remove Argon2 KDF derivation from its job setup[v24.x backport] several crypto backportsMay 7, 2026
@panvapanva changed the title [v24.x backport] several crypto backports[v24.x backport] crypto,doc: selected crypto changesMay 7, 2026
@nodejs-github-bot

nodejs-github-bot commented May 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73233/

@codecov

codecovBot commented May 7, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.85%. Comparing base (1fbb5a9) to head (8752b60).
⚠️ Report is 10 commits behind head on v24.x-staging.

Additional details and impacted files
@@ Coverage Diff @@## v24.x-staging #63173 +/- ##
=================================================
- Coverage 89.91% 89.85% -0.06% 
=================================================
Files 686 680 -6 Lines 208361 207901 -460 Branches 40057 40000 -57 =================================================
- Hits 187353 186816 -537 - Misses 13239 13283 +44 - Partials 7769 7802 +33
Files with missing linesCoverage Δ
lib/internal/crypto/aes.js88.42% <100.00%> (-0.04%)⬇️
lib/internal/crypto/cfrg.js96.26% <100.00%> (ø)
lib/internal/crypto/chacha20_poly1305.js92.72% <100.00%> (-0.05%)⬇️
lib/internal/crypto/ec.js96.21% <100.00%> (ø)
lib/internal/crypto/keys.js95.55% <100.00%> (+0.08%)⬆️
lib/internal/crypto/mac.js91.09% <100.00%> (-0.04%)⬇️
lib/internal/crypto/ml_dsa.js95.18% <100.00%> (ø)
lib/internal/crypto/ml_kem.js92.13% <100.00%> (ø)
lib/internal/crypto/rsa.js94.10% <100.00%> (ø)
lib/internal/crypto/util.js95.61% <100.00%> (+0.15%)⬆️
... and 2 more

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73278/

@aduh95
aduh95force-pushed the crypto-backports branch from b0fb43c to bdeea2eCompareMay 9, 2026 07:27
aduh95 pushed a commit to panva/node that referenced this pull request May 9, 2026
@panva@aduh95
crypto: deduplicate and canonicalize CryptoKey usages
bdeea2e
Fixes: nodejs#62899
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62902
Backport-PR-URL: nodejs#63173Fixes: nodejs#62899
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva added 4 commits May 9, 2026 09:27
@panva@aduh95
crypto: remove Argon2 KDF derivation from its job setup
28a7874
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62863
Backport-PR-URL: nodejs#63173Fixes: nodejs#62861
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva@aduh95
crypto: reject unintended raw key format string input
341947e
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62974
Backport-PR-URL: nodejs#63173
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva@aduh95
doc: fix typos and inconsistencies in crypto.md and webcrypto.md
aa1e0bc
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62828
Backport-PR-URL: nodejs#63173
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva@aduh95
crypto: deduplicate and canonicalize CryptoKey usages
8752b60
Fixes: nodejs#62899
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62902
Backport-PR-URL: nodejs#63173Fixes: nodejs#62899
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95force-pushed the crypto-backports branch from bdeea2e to 8752b60CompareMay 9, 2026 07:27
@aduh95
aduh95 merged commit 8752b60 into nodejs:v24.x-stagingMay 9, 2026
18 checks passed
@aduh95

aduh95 commented May 9, 2026

Copy link
Copy Markdown
Contributor

Landed in 2ca42c8...8752b60

@panva
panva deleted the crypto-backports branch May 9, 2026 07:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.v24.xIssues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panva@nodejs-github-bot@aduh95