[v24.x backport] inspector: support storage inspection and webstorage events by thisalihassan · Pull Request #63176 · nodejs/node

thisalihassan · 2026-05-07T17:24:26Z

This is a manual backport of five related commits.

nodejs-github-bot · 2026-05-07T17:24:32Z

Review requested:

@nodejs/config
@nodejs/gyp
@nodejs/inspector
@nodejs/startup

thisalihassan · 2026-05-07T19:16:41Z

@aduh95 I believe this #62660 PR fixes this (generates localstorage temp file) check https://github.com/nodejs/node/actions/runs/25511424629/job/74870924115?pr=63176 now there's a CI #62661 which enforces clean git tree

Want me to backport that commit too?

codecov · 2026-05-07T19:54:49Z

Codecov Report

❌ Patch coverage is 92.11009% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.92%. Comparing base (8752b60) to head (b881658).
⚠️ Report is 5 commits behind head on v24.x-staging.

Files with missing lines	Patch %	Lines
src/inspector/dom_storage_agent.cc	86.32%	14 Missing and 15 partials ⚠️
src/inspector/inspector_object_utils.cc	89.79%	0 Missing and 5 partials ⚠️
src/node_webstorage.cc	77.27%	1 Missing and 4 partials ⚠️
src/inspector/network_agent.cc	96.92%	2 Missing ⚠️
src/inspector/notification_emitter.cc	90.00%	0 Missing and 1 partial ⚠️
src/inspector_agent.cc	95.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## v24.x-staging #63176 +/- ##
=================================================
+ Coverage 89.85% 89.92% +0.06% 
=================================================
Files 680 686 +6 Lines 207901 208389 +488 Branches 40000 40077 +77 =================================================
+ Hits 186816 187387 +571 + Misses 13283 13238 -45 + Partials 7802 7764 -38

Files with missing lines	Coverage Δ
lib/inspector.js	`97.22% <100.00%> (+0.12%)`	⬆️
lib/internal/inspector/webstorage.js	`100.00% <100.00%> (ø)`
lib/internal/webstorage.js	`100.00% <100.00%> (ø)`
src/inspector/notification_emitter.h	`100.00% <100.00%> (ø)`
src/inspector/storage_agent.cc	`100.00% <100.00%> (ø)`
src/node_builtins.cc	`76.33% <ø> (+0.38%)`	⬆️
src/node_options.cc	`76.28% <100.00%> (+0.12%)`	⬆️
src/node_options.h	`97.88% <100.00%> (+0.01%)`	⬆️
src/node_webstorage.h	`50.00% <ø> (ø)`
src/inspector/notification_emitter.cc	`90.00% <90.00%> (ø)`
... and 5 more

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 · 2026-05-07T20:00:40Z

Want me to backport that commit too?

Yes please, otherwise we cannot land this without breaking CI for every other backport PR

nodejs-github-bot · 2026-05-07T21:33:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73240/

nodejs-github-bot · 2026-05-07T22:43:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73244/

nodejs-github-bot · 2026-05-08T20:52:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73274/

PR-URL: nodejs#61139 Backport-PR-URL: nodejs#63176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#62145 Backport-PR-URL: nodejs#63176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#62162 Backport-PR-URL: nodejs#63176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Signed-off-by: Ali Hassan <ali-hassan27@outlook.com> PR-URL: nodejs#62616 Backport-PR-URL: nodejs#63176 Refs: nodejs#62145 Refs: nodejs#62162 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#62660 Backport-PR-URL: nodejs#63176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 · 2026-05-09T07:33:43Z

Landed in 8752b60...b881658

aduh95 reviewed May 7, 2026
View reviewed changes

Comment threadsrc/inspector/domain_dom_storage.pdl

aduh95 reviewed May 7, 2026
View reviewed changes

Comment threadsrc/inspector/network_agent.cc Outdated

aduh95 reviewed May 7, 2026
View reviewed changes

Comment threadsrc/inspector/network_agent.cc Outdated

aduh95 reviewed May 7, 2026
View reviewed changes

Comment threadsrc/inspector/network_agent.cc Outdated

thisalihassan force-pushed the backport-61139-to-v24.x branch from 2837841 to 1fbb5a9Compare May 7, 2026 20:50

aduh95 approved these changes May 7, 2026
View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 7, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2026

islandryuand others added 5 commits May 9, 2026 09:32

inspector: initial support storage inspection
36cc041
PR-URL: nodejs#61139 Backport-PR-URL: nodejs#63176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

inspector: auto collect webstorage data
4f3f21b
PR-URL: nodejs#62145 Backport-PR-URL: nodejs#63176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

inspector: return errors when CDP protocol event emission fails
3dc3fb6
PR-URL: nodejs#62162 Backport-PR-URL: nodejs#63176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

inspector: coerce key and value to string in webstorage events
b3bfe35
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com> PR-URL: nodejs#62616 Backport-PR-URL: nodejs#63176 Refs: nodejs#62145 Refs: nodejs#62162 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

test: generate localstorage.db in a temp dir
b881658
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#62660 Backport-PR-URL: nodejs#63176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 force-pushed the backport-61139-to-v24.x branch from 1fbb5a9 to b881658Compare May 9, 2026 07:32

aduh95 merged commit b881658 into nodejs:v24.x-stagingMay 9, 2026
18 of 19 checks passed

Navigation Menu

Uh oh!

Uh oh!

[v24.x backport] inspector: support storage inspection and webstorage events - #63176

[v24.x backport] inspector: support storage inspection and webstorage events#63176
aduh95 merged 5 commits into
nodejs:v24.x-stagingfrom
thisalihassan:backport-61139-to-v24.x

thisalihassan commented May 7, 2026•
edited
Loading

Uh oh!

nodejs-github-bot commented May 7, 2026

Uh oh!

thisalihassan commented May 7, 2026

Uh oh!

codecovBot commented May 7, 2026•
edited
Loading

Uh oh!

aduh95 commented May 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 7, 2026

Uh oh!

nodejs-github-bot commented May 7, 2026

Uh oh!

nodejs-github-bot commented May 8, 2026

Uh oh!

aduh95 commented May 9, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

thisalihassan commented May 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 7, 2026

Uh oh!

thisalihassan commented May 7, 2026

Uh oh!

codecovBot commented May 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aduh95 commented May 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 7, 2026

Uh oh!

nodejs-github-bot commented May 7, 2026

Uh oh!

nodejs-github-bot commented May 8, 2026

Uh oh!

aduh95 commented May 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thisalihassan commented May 7, 2026•
edited
Loading

codecovBot commented May 7, 2026•
edited
Loading

aduh95 commented May 9, 2026•
edited
Loading