Uh oh!
There was an error while loading. Please reload this page.
doc: change references to Stable to Current - #6318
Conversation
jasnell
commented
Apr 21, 2016
LGTM |
MylesBorins
commented
Apr 21, 2016
/cc @nodejs/ctc |
evanlucas
commented
Apr 21, 2016
I think changelog-maker will need an update too if I am remembering correctly |
From my comment in nodejs/nodejs.org#669
edit: I'm making a checklist in the top comment. Other collaborators please feel free to edit my comment and add more to the list |
MylesBorins
commented
Apr 21, 2016
@evanlucas afaik changelog maker is agnostic to release lines. The title of the changelog is always made manually afaik |
evanlucas
commented
Apr 21, 2016
It breaks https://github.com/rvagg/changelog-maker/blob/master/groups.js#L19 (the --filter-release flag) |
MylesBorins
commented
Apr 21, 2016
PR has come in at a first pass to updating the website nodejs/nodejs.org#672 |
fhemberger
commented
Apr 21, 2016
PR for changelog-maker: nodejs/changelog-maker#38 |
Fishrock123
commented
Apr 23, 2016
We do? |
MylesBorins
commented
Apr 23, 2016
via email
There was another thread where there seemed to be consensus. Tbqh the
language is written for the commit if it lands. I copied it over to the PR.
I should have likely switched to more democratic language in the issue. |
Fishrock123
commented
Apr 23, 2016
I have voiced my concerns at nodejs/nodejs.org#669 (comment) We need to make sure we give the large changes more time and not just cram them in before breaking releases... Speaking of which, this doesn't actually have to be done in a breaking release at all. I'd rather everyone be good with it and change it afterwards than not. |
evanlucas
commented
Apr 24, 2016
This probably needs CTC approval? |
Fishrock123
commented
Apr 24, 2016
@evanlucas at the very least, I think. |
Fishrock123
commented
Apr 24, 2016
Thinking about this more in nodejs/nodejs.org#669 (comment)
|
jasnell
commented
Apr 24, 2016
Getting ctc review and encouraging input from the collaborators is exactly why this PR was opened :-) |
Trott
commented
Apr 24, 2016
@Fishrock123 wrote:
@nodejs/evangelism @nodejs/website |
mikeal
commented
Apr 24, 2016
CTC should weigh in but it would be good to have the website change ready On Saturday, April 23, 2016, Rich Trott notifications@github.com wrote:
|
jasnell
commented
Apr 25, 2016
Need to know today if we're going to use the new naming for v6 |
ChALkeR
commented
Apr 25, 2016
This does LGTM (with a nit). The only concern that I have here is that we would actually have LTS, Current, Maintenance, and Stable, at least in the changelog. We should make sure that the renaming is clear and that people can look up what did |
evanlucas
commented
Apr 25, 2016
LGTM with @ChALkeR's nit addressed |
7da4fd4 to
c7066fbComparePR for download page redirect: nodejs/build#399 @thealphanerd Can you please update the original post? |
jasnell
commented
Apr 26, 2016
@nodejs/ctc ... I need a final Go / No Go on making this change in this release. @Fishrock123 has voiced an objection. Need to know what to use for this release. |
fhemberger
commented
Apr 26, 2016
@jasnell Website has already been updated: nodejs/nodejs.org#672 (comment) |
jasnell
commented
Apr 26, 2016
Ok... that settles it then lol. @thealphanerd can you make sure this PR is up to date and get it landed? |
With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. ref: nodejs/nodejs.org#669
2384db1 to
d6a5f98CompareWith v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: nodejs/nodejs.org#669 PR-URL: #6318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell
commented
Apr 26, 2016
Landed in 29a6c7c |
With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: nodejs/nodejs.org#669 PR-URL: #6318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
With the change of release names from 'Stable' to 'Current' (introduced with Node.js v6), the old download page needs to be redirected. PR-URL: #399 Refs: nodejs/node#6318 Refs: nodejs/nodejs.org#672 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: nodejs/nodejs.org#669 PR-URL: #6318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: nodejs/nodejs.org#669 PR-URL: #6318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: nodejs/nodejs.org#669 PR-URL: #6318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Checklist
Notes
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.
ref: nodejs/nodejs.org#669