Skip to content

crypto: move DEP0203 and DEP0204 to End-of-Life - #63188

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:eol-DEP0203-DEP0204
Jun 17, 2026
Merged

crypto: move DEP0203 and DEP0204 to End-of-Life#63188
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:eol-DEP0203-DEP0204

Conversation

@panva

@panvapanva commented May 8, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Moves support for passing CryptoKey instances to node:crypto APIs to End-of-Life status (DEP0203).

Moves support for passing a non-extractable CryptoKey instances to KeyObject.from() to End-of-Life status (DEP0204).

Closes#55293

doc-deprecation is since 24
runtime-deprecation is since 26
this eol is for 27

@panvapanva added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels May 8, 2026
@nodejs-github-bot

nodejs-github-bot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/userland-migrations

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 8, 2026
@panva
panvaforce-pushed the eol-DEP0203-DEP0204 branch from b625ac4 to 3eb5d08CompareMay 8, 2026 09:18
@panva
panva marked this pull request as ready for review May 8, 2026 09:18
@panva
panva marked this pull request as draft May 8, 2026 09:29
@codecov

codecovBot commented May 8, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (9adddc5) to head (3eb5d08).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63188 +/- ##
==========================================
+ Coverage 90.04% 90.06% +0.01% 
==========================================
Files 713 713 Lines 224926 224899 -27 Branches 42525 42527 +2 ==========================================
+ Hits 202526 202545 +19 + Misses 14180 14136 -44 + Partials 8220 8218 -2
Files with missing linesCoverage Δ
lib/internal/crypto/keys.js97.57% <100.00%> (+0.42%)⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva
crypto: move DEP0203 and DEP0204 to End-of-Life
dae9839
Moves support for passing CryptoKey instances to node:crypto APIs to
End-of-Life status (DEP0203).
Moves support for passing a non-extractable CryptoKey instances to
KeyObject.from() End-of-Life status (DEP0204).
Closesnodejs#55293
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panvaforce-pushed the eol-DEP0203-DEP0204 branch from 3eb5d08 to dae9839CompareJune 15, 2026 08:02
@panva
panva marked this pull request as ready for review June 15, 2026 08:03
AugustinMauroy
AugustinMauroy reviewed Jun 15, 2026
View reviewed changes
Comment threaddoc/api/deprecations.md
@panva
panva requested a review from ChALkeRJune 15, 2026 08:48
@panva

panva commented Jun 15, 2026

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/tsc for semver-majorPRs that contain breaking changes and should be released in the next major version.

@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2026
@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 15, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74172/

mcollina
mcollina approved these changes Jun 17, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 4d09c04 into nodejs:mainJun 17, 2026
94 of 96 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Landed in 4d09c04

@panva
panva deleted the eol-DEP0203-DEP0204 branch June 17, 2026 17:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@anonriganonriganonrig approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
+1 more reviewer
@AugustinMauroyAugustinMauroyAugustinMauroy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.deprecationsIssues and PRs related to deprecations.needs-ciPRs that need a full CI run.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accepting CryptoKey in node:crypto APIs

5 participants

@panva@nodejs-github-bot@mcollina@anonrig@AugustinMauroy