lib: fix ERR_INVALID_ARG_TYPE with --enable-source-maps by kimjune01 · Pull Request #63215 · nodejs/node

kimjune01 · 2026-05-09T16:50:52Z

When --enable-source-maps is enabled but no source map exists for the script (e.g. a plain .mjs file), getErrorSourceLocation() returned undefined. This caused getErrMessage() to return undefined, which made innerOk() pass [undefined] as the message tuple to innerFail(), hitting the ERR_INVALID_ARG_TYPE guard instead of throwing AssertionError.

Fix all code paths in getErrorSourceLocation() that returned bare undefined to fall back to the raw generated source line, matching the behavior when source maps are disabled entirely. Also add a guard for when V8 fails to provide a source line at all.

Includes tests for both .mjs and .cjs files under --enable-source-maps.

Fixes: #63169

atlowChemi · 2026-05-10T06:54:31Z

@kimjune01 I think the commit's module should be lib, not assert, as I don't think this changes assert specifically, that is mostly the symptom, not the actual issue, no?

kimjune01 · 2026-05-10T07:23:47Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

atlowChemi · 2026-05-10T09:14:01Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

@kimjune01 please reword the commit as well 🙏🏽
Let me know if any help is needed

kimjune01 · 2026-05-11T04:01:15Z

Done — reworded commit to lib: prefix.

codecov · 2026-05-24T06:36:39Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (d4d35c6) to head (da520ed).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/errors/error_source.js	33.33%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63215 +/- ##
=======================================
Coverage 90.12% 90.12% =======================================
Files 743 743 Lines 242415 242422 +7 Branches 45656 45653 -3 =======================================
+ Hits 218476 218491 +15 
Misses 15438 15438 + Partials 8501 8493 -8

Files with missing lines	Coverage Δ
lib/internal/errors/error_source.js	`82.55% <33.33%> (+0.73%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi · 2026-05-24T08:13:00Z

@kimjune01 the CI failures all seem related to the changes

kimjune01 · 2026-05-26T23:47:21Z

Rebased onto current main and fixed the two lint failures:

Dropped the non-ASCII em-dash from the comments (lint-js-and-md)
Added the DCO Signed-off-by (lint-commit-message)

The earlier build failures looked unrelated to this lib/ change; should be clean on the fresh run.

kimjune01 · 2026-06-27T00:30:51Z

Done. Moved both cases into test-node-output-sourcemaps.mjs as snapshot fixtures under source-map/output/ with a // Flags: --enable-source-maps directive; dropped the standalone test.

nodejs-github-bot · 2026-06-28T06:40:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74431/

nodejs-github-bot · 2026-07-26T00:17:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75155/

Signed-off-by: June Kim <kimjune01@gmail.com>

Fold the .mjs and .cjs --enable-source-maps cases from the standalone test-assert-ok-source-maps.js into the existing snapshot output test, following the setup in test-node-output-sourcemaps.mjs as requested in review. The fixtures live under test/fixtures/source-map/output/ with a `// Flags: --enable-source-maps` directive and assert AssertionError output via snapshots instead of bespoke spawnSync assertions. Refs: nodejs#63169 Signed-off-by: June Kim <kimjune01@gmail.com>

The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 · 2026-07-26T04:26:39Z

Rebased onto main. Could someone run CI?

nodejs-github-bot · 2026-07-26T09:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75166/

nodejs-github-bot · 2026-08-19T16:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76001/

nodejs-github-bot · 2026-08-20T23:02:36Z

Landed in b5d37cd

Signed-off-by: June Kim <kimjune01@gmail.com> PR-URL: #63215Fixes: #63169 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

kimjune01 · 2026-05-09T16:50:52Z

When --enable-source-maps is enabled but no source map exists for the script (e.g. a plain .mjs file), getErrorSourceLocation() returned undefined. This caused getErrMessage() to return undefined, which made innerOk() pass [undefined] as the message tuple to innerFail(), hitting the ERR_INVALID_ARG_TYPE guard instead of throwing AssertionError.

Fix all code paths in getErrorSourceLocation() that returned bare undefined to fall back to the raw generated source line, matching the behavior when source maps are disabled entirely. Also add a guard for when V8 fails to provide a source line at all.

Includes tests for both .mjs and .cjs files under --enable-source-maps.

Fixes: #63169

atlowChemi · 2026-05-10T06:54:31Z

@kimjune01 I think the commit's module should be lib, not assert, as I don't think this changes assert specifically, that is mostly the symptom, not the actual issue, no?

kimjune01 · 2026-05-10T07:23:47Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

atlowChemi · 2026-05-10T09:14:01Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

@kimjune01 please reword the commit as well 🙏🏽
Let me know if any help is needed

kimjune01 · 2026-05-11T04:01:15Z

Done — reworded commit to lib: prefix.

codecov · 2026-05-24T06:36:39Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (d4d35c6) to head (da520ed).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/errors/error_source.js	33.33%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63215 +/- ##
=======================================
Coverage 90.12% 90.12% =======================================
Files 743 743 Lines 242415 242422 +7 Branches 45656 45653 -3 =======================================
+ Hits 218476 218491 +15 
Misses 15438 15438 + Partials 8501 8493 -8

Files with missing lines	Coverage Δ
lib/internal/errors/error_source.js	`82.55% <33.33%> (+0.73%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi · 2026-05-24T08:13:00Z

@kimjune01 the CI failures all seem related to the changes

kimjune01 · 2026-05-26T23:47:21Z

Rebased onto current main and fixed the two lint failures:

Dropped the non-ASCII em-dash from the comments (lint-js-and-md)
Added the DCO Signed-off-by (lint-commit-message)

The earlier build failures looked unrelated to this lib/ change; should be clean on the fresh run.

kimjune01 · 2026-06-27T00:30:51Z

Done. Moved both cases into test-node-output-sourcemaps.mjs as snapshot fixtures under source-map/output/ with a // Flags: --enable-source-maps directive; dropped the standalone test.

nodejs-github-bot · 2026-06-28T06:40:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74431/

nodejs-github-bot · 2026-07-26T00:17:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75155/

Signed-off-by: June Kim <kimjune01@gmail.com>

Fold the .mjs and .cjs --enable-source-maps cases from the standalone test-assert-ok-source-maps.js into the existing snapshot output test, following the setup in test-node-output-sourcemaps.mjs as requested in review. The fixtures live under test/fixtures/source-map/output/ with a `// Flags: --enable-source-maps` directive and assert AssertionError output via snapshots instead of bespoke spawnSync assertions. Refs: nodejs#63169 Signed-off-by: June Kim <kimjune01@gmail.com>

The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 · 2026-07-26T04:26:39Z

Rebased onto main. Could someone run CI?

nodejs-github-bot · 2026-07-26T09:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75166/

nodejs-github-bot · 2026-08-19T16:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76001/

nodejs-github-bot · 2026-08-20T23:02:36Z

Landed in b5d37cd

Signed-off-by: June Kim <kimjune01@gmail.com> PR-URL: #63215Fixes: #63169 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

kimjune01 · 2026-05-09T16:50:52Z

When --enable-source-maps is enabled but no source map exists for the script (e.g. a plain .mjs file), getErrorSourceLocation() returned undefined. This caused getErrMessage() to return undefined, which made innerOk() pass [undefined] as the message tuple to innerFail(), hitting the ERR_INVALID_ARG_TYPE guard instead of throwing AssertionError.

Fix all code paths in getErrorSourceLocation() that returned bare undefined to fall back to the raw generated source line, matching the behavior when source maps are disabled entirely. Also add a guard for when V8 fails to provide a source line at all.

Includes tests for both .mjs and .cjs files under --enable-source-maps.

Fixes: #63169

atlowChemi · 2026-05-10T06:54:31Z

@kimjune01 I think the commit's module should be lib, not assert, as I don't think this changes assert specifically, that is mostly the symptom, not the actual issue, no?

kimjune01 · 2026-05-10T07:23:47Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

atlowChemi · 2026-05-10T09:14:01Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

@kimjune01 please reword the commit as well 🙏🏽
Let me know if any help is needed

kimjune01 · 2026-05-11T04:01:15Z

Done — reworded commit to lib: prefix.

codecov · 2026-05-24T06:36:39Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (d4d35c6) to head (da520ed).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/errors/error_source.js	33.33%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63215 +/- ##
=======================================
Coverage 90.12% 90.12% =======================================
Files 743 743 Lines 242415 242422 +7 Branches 45656 45653 -3 =======================================
+ Hits 218476 218491 +15 
Misses 15438 15438 + Partials 8501 8493 -8

Files with missing lines	Coverage Δ
lib/internal/errors/error_source.js	`82.55% <33.33%> (+0.73%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi · 2026-05-24T08:13:00Z

@kimjune01 the CI failures all seem related to the changes

kimjune01 · 2026-05-26T23:47:21Z

Rebased onto current main and fixed the two lint failures:

Dropped the non-ASCII em-dash from the comments (lint-js-and-md)
Added the DCO Signed-off-by (lint-commit-message)

The earlier build failures looked unrelated to this lib/ change; should be clean on the fresh run.

kimjune01 · 2026-06-27T00:30:51Z

Done. Moved both cases into test-node-output-sourcemaps.mjs as snapshot fixtures under source-map/output/ with a // Flags: --enable-source-maps directive; dropped the standalone test.

nodejs-github-bot · 2026-06-28T06:40:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74431/

nodejs-github-bot · 2026-07-26T00:17:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75155/

Signed-off-by: June Kim <kimjune01@gmail.com>

Fold the .mjs and .cjs --enable-source-maps cases from the standalone test-assert-ok-source-maps.js into the existing snapshot output test, following the setup in test-node-output-sourcemaps.mjs as requested in review. The fixtures live under test/fixtures/source-map/output/ with a `// Flags: --enable-source-maps` directive and assert AssertionError output via snapshots instead of bespoke spawnSync assertions. Refs: nodejs#63169 Signed-off-by: June Kim <kimjune01@gmail.com>

The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 · 2026-07-26T04:26:39Z

Rebased onto main. Could someone run CI?

nodejs-github-bot · 2026-07-26T09:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75166/

nodejs-github-bot · 2026-08-19T16:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76001/

nodejs-github-bot · 2026-08-20T23:02:36Z

Landed in b5d37cd

Signed-off-by: June Kim <kimjune01@gmail.com> PR-URL: #63215Fixes: #63169 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

kimjune01 · 2026-05-09T16:50:52Z

When --enable-source-maps is enabled but no source map exists for the script (e.g. a plain .mjs file), getErrorSourceLocation() returned undefined. This caused getErrMessage() to return undefined, which made innerOk() pass [undefined] as the message tuple to innerFail(), hitting the ERR_INVALID_ARG_TYPE guard instead of throwing AssertionError.

Fix all code paths in getErrorSourceLocation() that returned bare undefined to fall back to the raw generated source line, matching the behavior when source maps are disabled entirely. Also add a guard for when V8 fails to provide a source line at all.

Includes tests for both .mjs and .cjs files under --enable-source-maps.

Fixes: #63169

atlowChemi · 2026-05-10T06:54:31Z

@kimjune01 I think the commit's module should be lib, not assert, as I don't think this changes assert specifically, that is mostly the symptom, not the actual issue, no?

kimjune01 · 2026-05-10T07:23:47Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

atlowChemi · 2026-05-10T09:14:01Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

@kimjune01 please reword the commit as well 🙏🏽
Let me know if any help is needed

kimjune01 · 2026-05-11T04:01:15Z

Done — reworded commit to lib: prefix.

codecov · 2026-05-24T06:36:39Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (d4d35c6) to head (da520ed).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/errors/error_source.js	33.33%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63215 +/- ##
=======================================
Coverage 90.12% 90.12% =======================================
Files 743 743 Lines 242415 242422 +7 Branches 45656 45653 -3 =======================================
+ Hits 218476 218491 +15 
Misses 15438 15438 + Partials 8501 8493 -8

Files with missing lines	Coverage Δ
lib/internal/errors/error_source.js	`82.55% <33.33%> (+0.73%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi · 2026-05-24T08:13:00Z

@kimjune01 the CI failures all seem related to the changes

kimjune01 · 2026-05-26T23:47:21Z

Rebased onto current main and fixed the two lint failures:

Dropped the non-ASCII em-dash from the comments (lint-js-and-md)
Added the DCO Signed-off-by (lint-commit-message)

The earlier build failures looked unrelated to this lib/ change; should be clean on the fresh run.

kimjune01 · 2026-06-27T00:30:51Z

Done. Moved both cases into test-node-output-sourcemaps.mjs as snapshot fixtures under source-map/output/ with a // Flags: --enable-source-maps directive; dropped the standalone test.

nodejs-github-bot · 2026-06-28T06:40:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74431/

nodejs-github-bot · 2026-07-26T00:17:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75155/

Signed-off-by: June Kim <kimjune01@gmail.com>

Fold the .mjs and .cjs --enable-source-maps cases from the standalone test-assert-ok-source-maps.js into the existing snapshot output test, following the setup in test-node-output-sourcemaps.mjs as requested in review. The fixtures live under test/fixtures/source-map/output/ with a `// Flags: --enable-source-maps` directive and assert AssertionError output via snapshots instead of bespoke spawnSync assertions. Refs: nodejs#63169 Signed-off-by: June Kim <kimjune01@gmail.com>

The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 · 2026-07-26T04:26:39Z

Rebased onto main. Could someone run CI?

nodejs-github-bot · 2026-07-26T09:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75166/

nodejs-github-bot · 2026-08-19T16:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76001/

nodejs-github-bot · 2026-08-20T23:02:36Z

Landed in b5d37cd

Signed-off-by: June Kim <kimjune01@gmail.com> PR-URL: #63215Fixes: #63169 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

kimjune01 · 2026-05-09T16:50:52Z

When --enable-source-maps is enabled but no source map exists for the script (e.g. a plain .mjs file), getErrorSourceLocation() returned undefined. This caused getErrMessage() to return undefined, which made innerOk() pass [undefined] as the message tuple to innerFail(), hitting the ERR_INVALID_ARG_TYPE guard instead of throwing AssertionError.

Fix all code paths in getErrorSourceLocation() that returned bare undefined to fall back to the raw generated source line, matching the behavior when source maps are disabled entirely. Also add a guard for when V8 fails to provide a source line at all.

Includes tests for both .mjs and .cjs files under --enable-source-maps.

Fixes: #63169

atlowChemi · 2026-05-10T06:54:31Z

@kimjune01 I think the commit's module should be lib, not assert, as I don't think this changes assert specifically, that is mostly the symptom, not the actual issue, no?

kimjune01 · 2026-05-10T07:23:47Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

atlowChemi · 2026-05-10T09:14:01Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

@kimjune01 please reword the commit as well 🙏🏽
Let me know if any help is needed

kimjune01 · 2026-05-11T04:01:15Z

Done — reworded commit to lib: prefix.

codecov · 2026-05-24T06:36:39Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (d4d35c6) to head (da520ed).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/errors/error_source.js	33.33%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63215 +/- ##
=======================================
Coverage 90.12% 90.12% =======================================
Files 743 743 Lines 242415 242422 +7 Branches 45656 45653 -3 =======================================
+ Hits 218476 218491 +15 
Misses 15438 15438 + Partials 8501 8493 -8

Files with missing lines	Coverage Δ
lib/internal/errors/error_source.js	`82.55% <33.33%> (+0.73%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi · 2026-05-24T08:13:00Z

@kimjune01 the CI failures all seem related to the changes

kimjune01 · 2026-05-26T23:47:21Z

Rebased onto current main and fixed the two lint failures:

Dropped the non-ASCII em-dash from the comments (lint-js-and-md)
Added the DCO Signed-off-by (lint-commit-message)

The earlier build failures looked unrelated to this lib/ change; should be clean on the fresh run.

kimjune01 · 2026-06-27T00:30:51Z

Done. Moved both cases into test-node-output-sourcemaps.mjs as snapshot fixtures under source-map/output/ with a // Flags: --enable-source-maps directive; dropped the standalone test.

nodejs-github-bot · 2026-06-28T06:40:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74431/

nodejs-github-bot · 2026-07-26T00:17:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75155/

Signed-off-by: June Kim <kimjune01@gmail.com>

Fold the .mjs and .cjs --enable-source-maps cases from the standalone test-assert-ok-source-maps.js into the existing snapshot output test, following the setup in test-node-output-sourcemaps.mjs as requested in review. The fixtures live under test/fixtures/source-map/output/ with a `// Flags: --enable-source-maps` directive and assert AssertionError output via snapshots instead of bespoke spawnSync assertions. Refs: nodejs#63169 Signed-off-by: June Kim <kimjune01@gmail.com>

The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 · 2026-07-26T04:26:39Z

Rebased onto main. Could someone run CI?

nodejs-github-bot · 2026-07-26T09:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75166/

nodejs-github-bot · 2026-08-19T16:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76001/

nodejs-github-bot · 2026-08-20T23:02:36Z

Landed in b5d37cd

Signed-off-by: June Kim <kimjune01@gmail.com> PR-URL: #63215Fixes: #63169 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

kimjune01 · 2026-05-09T16:50:52Z

When --enable-source-maps is enabled but no source map exists for the script (e.g. a plain .mjs file), getErrorSourceLocation() returned undefined. This caused getErrMessage() to return undefined, which made innerOk() pass [undefined] as the message tuple to innerFail(), hitting the ERR_INVALID_ARG_TYPE guard instead of throwing AssertionError.

Fix all code paths in getErrorSourceLocation() that returned bare undefined to fall back to the raw generated source line, matching the behavior when source maps are disabled entirely. Also add a guard for when V8 fails to provide a source line at all.

Includes tests for both .mjs and .cjs files under --enable-source-maps.

Fixes: #63169

atlowChemi · 2026-05-10T06:54:31Z

@kimjune01 I think the commit's module should be lib, not assert, as I don't think this changes assert specifically, that is mostly the symptom, not the actual issue, no?

kimjune01 · 2026-05-10T07:23:47Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

atlowChemi · 2026-05-10T09:14:01Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

@kimjune01 please reword the commit as well 🙏🏽
Let me know if any help is needed

kimjune01 · 2026-05-11T04:01:15Z

Done — reworded commit to lib: prefix.

codecov · 2026-05-24T06:36:39Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (d4d35c6) to head (da520ed).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/errors/error_source.js	33.33%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63215 +/- ##
=======================================
Coverage 90.12% 90.12% =======================================
Files 743 743 Lines 242415 242422 +7 Branches 45656 45653 -3 =======================================
+ Hits 218476 218491 +15 
Misses 15438 15438 + Partials 8501 8493 -8

Files with missing lines	Coverage Δ
lib/internal/errors/error_source.js	`82.55% <33.33%> (+0.73%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi · 2026-05-24T08:13:00Z

@kimjune01 the CI failures all seem related to the changes

kimjune01 · 2026-05-26T23:47:21Z

Rebased onto current main and fixed the two lint failures:

Dropped the non-ASCII em-dash from the comments (lint-js-and-md)
Added the DCO Signed-off-by (lint-commit-message)

The earlier build failures looked unrelated to this lib/ change; should be clean on the fresh run.

kimjune01 · 2026-06-27T00:30:51Z

Done. Moved both cases into test-node-output-sourcemaps.mjs as snapshot fixtures under source-map/output/ with a // Flags: --enable-source-maps directive; dropped the standalone test.

nodejs-github-bot · 2026-06-28T06:40:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74431/

nodejs-github-bot · 2026-07-26T00:17:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75155/

Signed-off-by: June Kim <kimjune01@gmail.com>

Fold the .mjs and .cjs --enable-source-maps cases from the standalone test-assert-ok-source-maps.js into the existing snapshot output test, following the setup in test-node-output-sourcemaps.mjs as requested in review. The fixtures live under test/fixtures/source-map/output/ with a `// Flags: --enable-source-maps` directive and assert AssertionError output via snapshots instead of bespoke spawnSync assertions. Refs: nodejs#63169 Signed-off-by: June Kim <kimjune01@gmail.com>

The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 · 2026-07-26T04:26:39Z

Rebased onto main. Could someone run CI?

nodejs-github-bot · 2026-07-26T09:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75166/

nodejs-github-bot · 2026-08-19T16:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76001/

nodejs-github-bot · 2026-08-20T23:02:36Z

Landed in b5d37cd

Signed-off-by: June Kim <kimjune01@gmail.com> PR-URL: #63215Fixes: #63169 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

kimjune01 · 2026-05-09T16:50:52Z

When --enable-source-maps is enabled but no source map exists for the script (e.g. a plain .mjs file), getErrorSourceLocation() returned undefined. This caused getErrMessage() to return undefined, which made innerOk() pass [undefined] as the message tuple to innerFail(), hitting the ERR_INVALID_ARG_TYPE guard instead of throwing AssertionError.

Fix all code paths in getErrorSourceLocation() that returned bare undefined to fall back to the raw generated source line, matching the behavior when source maps are disabled entirely. Also add a guard for when V8 fails to provide a source line at all.

Includes tests for both .mjs and .cjs files under --enable-source-maps.

Fixes: #63169

atlowChemi · 2026-05-10T06:54:31Z

@kimjune01 I think the commit's module should be lib, not assert, as I don't think this changes assert specifically, that is mostly the symptom, not the actual issue, no?

kimjune01 · 2026-05-10T07:23:47Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

atlowChemi · 2026-05-10T09:14:01Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

@kimjune01 please reword the commit as well 🙏🏽
Let me know if any help is needed

kimjune01 · 2026-05-11T04:01:15Z

Done — reworded commit to lib: prefix.

codecov · 2026-05-24T06:36:39Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (d4d35c6) to head (da520ed).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/errors/error_source.js	33.33%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63215 +/- ##
=======================================
Coverage 90.12% 90.12% =======================================
Files 743 743 Lines 242415 242422 +7 Branches 45656 45653 -3 =======================================
+ Hits 218476 218491 +15 
Misses 15438 15438 + Partials 8501 8493 -8

Files with missing lines	Coverage Δ
lib/internal/errors/error_source.js	`82.55% <33.33%> (+0.73%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi · 2026-05-24T08:13:00Z

@kimjune01 the CI failures all seem related to the changes

kimjune01 · 2026-05-26T23:47:21Z

Rebased onto current main and fixed the two lint failures:

Dropped the non-ASCII em-dash from the comments (lint-js-and-md)
Added the DCO Signed-off-by (lint-commit-message)

The earlier build failures looked unrelated to this lib/ change; should be clean on the fresh run.

kimjune01 · 2026-06-27T00:30:51Z

Done. Moved both cases into test-node-output-sourcemaps.mjs as snapshot fixtures under source-map/output/ with a // Flags: --enable-source-maps directive; dropped the standalone test.

nodejs-github-bot · 2026-06-28T06:40:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74431/

nodejs-github-bot · 2026-07-26T00:17:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75155/

Signed-off-by: June Kim <kimjune01@gmail.com>

Fold the .mjs and .cjs --enable-source-maps cases from the standalone test-assert-ok-source-maps.js into the existing snapshot output test, following the setup in test-node-output-sourcemaps.mjs as requested in review. The fixtures live under test/fixtures/source-map/output/ with a `// Flags: --enable-source-maps` directive and assert AssertionError output via snapshots instead of bespoke spawnSync assertions. Refs: nodejs#63169 Signed-off-by: June Kim <kimjune01@gmail.com>

The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 · 2026-07-26T04:26:39Z

Rebased onto main. Could someone run CI?

nodejs-github-bot · 2026-07-26T09:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75166/

nodejs-github-bot · 2026-08-19T16:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76001/

nodejs-github-bot · 2026-08-20T23:02:36Z

Landed in b5d37cd

Signed-off-by: June Kim <kimjune01@gmail.com> PR-URL: #63215Fixes: #63169 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

kimjune01 · 2026-05-09T16:50:52Z

When --enable-source-maps is enabled but no source map exists for the script (e.g. a plain .mjs file), getErrorSourceLocation() returned undefined. This caused getErrMessage() to return undefined, which made innerOk() pass [undefined] as the message tuple to innerFail(), hitting the ERR_INVALID_ARG_TYPE guard instead of throwing AssertionError.

Fix all code paths in getErrorSourceLocation() that returned bare undefined to fall back to the raw generated source line, matching the behavior when source maps are disabled entirely. Also add a guard for when V8 fails to provide a source line at all.

Includes tests for both .mjs and .cjs files under --enable-source-maps.

Fixes: #63169

atlowChemi · 2026-05-10T06:54:31Z

@kimjune01 I think the commit's module should be lib, not assert, as I don't think this changes assert specifically, that is mostly the symptom, not the actual issue, no?

kimjune01 · 2026-05-10T07:23:47Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

atlowChemi · 2026-05-10T09:14:01Z

Good point — the root cause is in the source map resolution path, not assert itself. I'll update the title.

@kimjune01 please reword the commit as well 🙏🏽
Let me know if any help is needed

kimjune01 · 2026-05-11T04:01:15Z

Done — reworded commit to lib: prefix.

codecov · 2026-05-24T06:36:39Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (d4d35c6) to head (da520ed).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/errors/error_source.js	33.33%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63215 +/- ##
=======================================
Coverage 90.12% 90.12% =======================================
Files 743 743 Lines 242415 242422 +7 Branches 45656 45653 -3 =======================================
+ Hits 218476 218491 +15 
Misses 15438 15438 + Partials 8501 8493 -8

Files with missing lines	Coverage Δ
lib/internal/errors/error_source.js	`82.55% <33.33%> (+0.73%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi · 2026-05-24T08:13:00Z

@kimjune01 the CI failures all seem related to the changes

kimjune01 · 2026-05-26T23:47:21Z

Rebased onto current main and fixed the two lint failures:

Dropped the non-ASCII em-dash from the comments (lint-js-and-md)
Added the DCO Signed-off-by (lint-commit-message)

The earlier build failures looked unrelated to this lib/ change; should be clean on the fresh run.

kimjune01 · 2026-06-27T00:30:51Z

Done. Moved both cases into test-node-output-sourcemaps.mjs as snapshot fixtures under source-map/output/ with a // Flags: --enable-source-maps directive; dropped the standalone test.

nodejs-github-bot · 2026-06-28T06:40:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74431/

nodejs-github-bot · 2026-07-26T00:17:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75155/

Signed-off-by: June Kim <kimjune01@gmail.com>

Fold the .mjs and .cjs --enable-source-maps cases from the standalone test-assert-ok-source-maps.js into the existing snapshot output test, following the setup in test-node-output-sourcemaps.mjs as requested in review. The fixtures live under test/fixtures/source-map/output/ with a `// Flags: --enable-source-maps` directive and assert AssertionError output via snapshots instead of bespoke spawnSync assertions. Refs: nodejs#63169 Signed-off-by: June Kim <kimjune01@gmail.com>

The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 · 2026-07-26T04:26:39Z

Rebased onto main. Could someone run CI?

nodejs-github-bot · 2026-07-26T09:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75166/

nodejs-github-bot · 2026-08-19T16:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76001/

nodejs-github-bot · 2026-08-20T23:02:36Z

Landed in b5d37cd

Signed-off-by: June Kim <kimjune01@gmail.com> PR-URL: #63215Fixes: #63169 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run. labels May 9, 2026

atlowChemi added the source maps Issues and PRs related to source map support. label May 10, 2026

kimjune01 changed the title ~~assert: fix ERR_INVALID_ARG_TYPE with --enable-source-maps~~lib: fix ERR_INVALID_ARG_TYPE with --enable-source-mapsMay 10, 2026

This comment was marked as spam.
Sign in to view

kimjune01 force-pushed the fix/assert-source-maps-regression branch from 629761d to bef74ddCompare May 11, 2026 04:00

atlowChemi approved these changes May 24, 2026
View reviewed changes

legendecas reviewed May 24, 2026
View reviewed changes

Comment threadtest/parallel/test-assert-ok-source-maps.js Outdated

kimjune01 force-pushed the fix/assert-source-maps-regression branch from 6eddc82 to 4b39cd1Compare May 26, 2026 23:46

kimjune01 force-pushed the fix/assert-source-maps-regression branch from 4b39cd1 to 6a0b05fCompare May 26, 2026 23:49

legendecas reviewed May 27, 2026
View reviewed changes

Comment threadtest/parallel/test-assert-ok-source-maps.js Outdated

jasnell approved these changes Jun 27, 2026
View reviewed changes

atlowChemi approved these changes Jun 28, 2026
View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2026

legendecas approved these changes Jul 15, 2026
View reviewed changes

legendecas added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Jul 15, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026

This comment was marked as outdated.
Sign in to view

kimjune01 added 3 commits July 25, 2026 19:48

lib: fix ERR_INVALID_ARG_TYPE with --enable-source-maps
8d14a76
Signed-off-by: June Kim <kimjune01@gmail.com>

test: silence no-restricted-syntax in source-map assert fixtures
da520ed
The literal first argument to assert() is intentional in these regression fixtures (the .snapshot files pin the exact source line and column), so disable the rule inline rather than rewriting the call.

kimjune01 force-pushed the fix/assert-source-maps-regression branch from b15e1c6 to da520edCompare July 26, 2026 02:53

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2026

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2026

legendecas added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 20, 2026

nodejs-github-bot merged commit b5d37cd into nodejs:mainAug 20, 2026
88 of 89 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026

colinhacks mentioned this pull request Aug 22, 2026
node: withhold --enable-source-maps across the whole Node 26.x assert regression band nubjs/nub#784
Merged

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged