Uh oh!
There was an error while loading. Please reload this page.
test: add more test cases for pathToFileURL - #63293
Merged
nodejs-github-bot merged 2 commits intoJun 2, 2026
Merged
Conversation
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSSforce-pushed
the
test-include-testcases-pathtofileurl
branch
from
May 13, 2026 18:58
4069b78 to
875c813CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #63293 +/- ##
==========================================
+ Coverage 90.05% 90.30% +0.24%
==========================================
Files 714 730 +16 Lines 225247 234773 +9526 Branches 42578 43955 +1377 ==========================================
+ Hits 202842 212001 +9159 - Misses 14181 14485 +304 - Partials 8224 8287 +63 🚀 New features to boost your workflow:
|
aduh95
reviewed
May 14, 2026
Comment on lines
+25
to
+35
| const forbiddenHostnameChars = [ | ||
| '\\\\exa mple\\share\\file.txt', | ||
| '\\\\host name\\share\\file.txt', // space | ||
| '\\\\host#name\\share\\file.txt', // hash | ||
| '\\\\host?name\\share\\file.txt', // question mark | ||
| '\\\\host@name\\share\\file.txt', // at sign | ||
| '\\\\host:name\\share\\file.txt', // colon | ||
| '\\\\host/name\\share\\file.txt', // forward slash | ||
| '\\\\host[name\\share\\file.txt', // left bracket | ||
| '\\\\host]name\\share\\file.txt', // right bracket | ||
| ]; |
Contributor
There was a problem hiding this comment.
According to https://url.spec.whatwg.org/#host-miscellaneous, there are a few more forbidden char we might as well check for:
Suggested change
| constforbiddenHostnameChars=[ | |
| '\\\\exa mple\\share\\file.txt', | |
| '\\\\host name\\share\\file.txt',// space | |
| '\\\\host#name\\share\\file.txt',// hash | |
| '\\\\host?name\\share\\file.txt',// question mark | |
| '\\\\host@name\\share\\file.txt',// at sign | |
| '\\\\host:name\\share\\file.txt',// colon | |
| '\\\\host/name\\share\\file.txt',// forward slash | |
| '\\\\host[name\\share\\file.txt',// left bracket | |
| '\\\\host]name\\share\\file.txt',// right bracket | |
| ]; | |
| constforbiddenHostnameChars=Array.from('\0\t\n\r #:<>?@[]^|',(sep)=>`\\\\host${sep}name\\share\\file.txt`); |
But it looks like \n, \r, \t are ignored instead of being rejected; # and ? might have a special significant in UNC not sure
Contributor
There was a problem hiding this comment.
I've opened ada-url/ada#1142 to address the # and ? cases
MemberAuthor
There was a problem hiding this comment.
Ok, I will wait it to reach Node.js main, ping me please
Contributor
There was a problem hiding this comment.
Sorry forgot to follow up, but the upstream issue was closed so let's limit to the ones that are supported
Suggested change
| constforbiddenHostnameChars=[ | |
| '\\\\exa mple\\share\\file.txt', | |
| '\\\\host name\\share\\file.txt',// space | |
| '\\\\host#name\\share\\file.txt',// hash | |
| '\\\\host?name\\share\\file.txt',// question mark | |
| '\\\\host@name\\share\\file.txt',// at sign | |
| '\\\\host:name\\share\\file.txt',// colon | |
| '\\\\host/name\\share\\file.txt',// forward slash | |
| '\\\\host[name\\share\\file.txt',// left bracket | |
| '\\\\host]name\\share\\file.txt',// right bracket | |
| ]; | |
| constforbiddenHostnameChars=Array.from('\0 :<>@[]^|',(sep)=>`\\\\host${sep}name\\share\\file.txt`); |
MemberAuthor
There was a problem hiding this comment.
Yes, that's why I sent 51f1a25. Honestly, it's much clearer to see that list than the approach you suggested.
Contributor
There was a problem hiding this comment.
I disagree, to me it's harder to spot the one-char diff, but as long as it works it's fine
nodejs-github-bot
commented
Jun 1, 2026
Collaborator
aduh95
approved these changes
Jun 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 2, 2026
Collaborator
Landed in fd632cf |
aduh95 pushed a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #63293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jun 25, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #63293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #63293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to make sure we won't introduce any regression anytime further (based on H1 reports we received).