Uh oh!
There was an error while loading. Please reload this page.
test: make Brotli 16GB test wait for backpressure - #63389
Merged
nodejs-github-bot merged 2 commits intoJun 6, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #63389 +/- ##
==========================================
- Coverage 91.95% 90.33% -1.63%
==========================================
Files 379 732 +353 Lines 166486 236454 +69968 Branches 25452 44531 +19079 ==========================================
+ Hits 153099 213594 +60495 - Misses 13094 14597 +1503 - Partials 293 8263 +7970 🚀 New features to boost your workflow:
|
aduh95
reviewed
May 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
jasnell
approved these changes
May 22, 2026
This comment was marked as outdated.
This comment was marked as outdated.
trivikrforce-pushed
the
flaky-test-zlib-brotli-16GB
branch
from
May 28, 2026 05:06
a6f7f6e to
143affeComparetrivikrforce-pushed
the
flaky-test-zlib-brotli-16GB
branch
from
May 31, 2026 05:22
143affe to
5e854e7CompareatlowChemi
approved these changes
Jun 4, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pimterry
approved these changes
Jun 4, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Wait for the Brotli decoder to fill its readable buffer before checking that decompression stops at the high water mark. This avoids racing the fixed timeout against libuv worker-pool scheduling. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
aduh95force-pushed
the
flaky-test-zlib-brotli-16GB
branch
from
June 5, 2026 09:53
5e854e7 to
cf75868Compare
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jun 5, 2026
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 6, 2026
Collaborator
Landed in 2adaeee |
aduh95 pushed a commit
that referenced
this pull request
Jun 18, 2026
Wait for the Brotli decoder to fill its readable buffer before checking that decompression stops at the high water mark. This avoids racing the fixed timeout against libuv worker-pool scheduling. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63389 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jun 25, 2026
Wait for the Brotli decoder to fill its readable buffer before checking that decompression stops at the high water mark. This avoids racing the fixed timeout against libuv worker-pool scheduling. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63389 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
Wait for the Brotli decoder to fill its readable buffer before checking that decompression stops at the high water mark. This avoids racing the fixed timeout against libuv worker-pool scheduling. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63389 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Tim Perry <pimterry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
parallel/test-zlib-brotli-16GBto wait until the Brotlidecoder reaches the expected readable-buffer backpressure point
before asserting the buffered chunk count.
The previous test used a fixed timeout and could check
_readableState.buffer.lengthbefore libuv worker-pool processing had pushed any output, causing intermittent
failures like
0 !== 4on loaded CI machines.Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure
Assisted-by: openai:gpt-5.5