crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
panva:crypto-add-siv-modes
Aug 22, 2026
Merged

crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
panva:crypto-add-siv-modes

Conversation

@panva

@panvapanva commented May 18, 2026

Copy link
Copy Markdown
Member

Closes#63393

@nodejs-github-bot

nodejs-github-bot commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels May 18, 2026
@panva
panvaforce-pushed the crypto-add-siv-modes branch from a1ea9b7 to 127a852CompareMay 18, 2026 13:24
@panva
panva requested a review from tniessenMay 18, 2026 13:24
@panvapanva added the crypto Issues and PRs related to the crypto subsystem. label May 18, 2026
@panva
panva marked this pull request as ready for review May 18, 2026 13:24
@panvapanva added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x labels May 18, 2026
@panva
panvaforce-pushed the crypto-add-siv-modes branch from 687e02b to b5764bcCompareMay 18, 2026 13:45
@codecov

codecovBot commented May 18, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 46 commits behind head on main.

Files with missing linesPatch %Lines
src/crypto/crypto_cipher.cc87.09%2 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63411 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 252325 252371 +46 Branches 47456 47472 +16 ==========================================
+ Hits 227407 227436 +29 - Misses 16217 16233 +16 - Partials 8701 8702 +1
Files with missing linesCoverage Δ
src/crypto/crypto_cipher.h68.47% <ø> (ø)
src/crypto/crypto_cipher.cc78.04% <87.09%> (+1.34%)⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panvapanva added review wanted PRs that need review. semver-minor PRs that contain new features and should be released in the next minor version. and removed dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels May 25, 2026
@panva
panva requested review from ChALkeR and jasnellJune 7, 2026 09:57
@panva
panva marked this pull request as draft June 11, 2026 09:09
@panva
panva marked this pull request as ready for review June 14, 2026 10:13
@panva
panvaforce-pushed the crypto-add-siv-modes branch from 944bf43 to 7c39722CompareJune 29, 2026 08:14
tniessen
tniessen reviewed Jun 29, 2026
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.h Outdated
Comment threaddeps/ncrypto/ncrypto.cc Outdated
@panva
panva requested a review from tniessenJune 30, 2026 21:04
@hylmarj

hylmarj commented Aug 17, 2026

Copy link
Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?

@panva
panvaforce-pushed the crypto-add-siv-modes branch from 823805b to 71999e4CompareAugust 20, 2026 09:20
@panvapanva mentioned this pull request Aug 20, 2026
Closed
@panvapanva removed the review wanted PRs that need review. label Aug 20, 2026
@panvapanva added the review wanted PRs that need review. label Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76206/

@panvapanva added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot merged commit e573bd6 into nodejs:mainAug 22, 2026
70 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Landed in e573bd6

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 22, 2026
@panva
panva deleted the crypto-add-siv-modes branch August 22, 2026 08:25
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
9ee76f3
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
f0531f1
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
nodejs-github-bot added a commit that referenced this pull request Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
aduh95 pushed a commit that referenced this pull request Aug 26, 2026
@nodejs-github-bot@aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
@tniessentniessenAwaiting requested review from tniessen

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.cryptoIssues and PRs related to the crypto subsystem.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.review wantedPRs that need review.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()

6 participants

@panva@nodejs-github-bot@hylmarj@jasnell@tniessen@aduh95
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411
Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Aug 22, 2026
Merged
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Conversation
@panva
@panvapanva
commented
May 18, 2026

Copy link


Copy Markdown

Member
Closes#63393
@nodejs-github-bot
nodejs-github-bot
commented
May 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
a1ea9b7 to
127a852CompareMay 18, 2026 13:24
@panva
panva
requested a review
from tniessenMay 18, 2026 13:24
@panvapanva
added
the 
crypto
Issues and PRs related to the crypto subsystem.
label
May 18, 2026
@panva
panva
marked this pull request as ready for review
May 18, 2026 13:24
@panvapanva
added

dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
dont-land-on-v25.x

labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
687e02b to
b5764bcCompareMay 18, 2026 13:45
@codecov
codecovBot
commented
May 18, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 46 commits behind head on main.
Files with missing linesPatch %Lines
src/crypto/crypto_cipher.cc87.09%2 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63411 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 252325 252371 +46 Branches 47456 47472 +16 ==========================================
+ Hits 227407 227436 +29 - Misses 16217 16233 +16 - Partials 8701 8702 +1 
Files with missing linesCoverage Δ
src/crypto/crypto_cipher.h68.47% <ø> (ø)
src/crypto/crypto_cipher.cc78.04% <87.09%> (+1.34%)⬆️
... and 31 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panvapanva
added

review wanted
PRs that need review.
semver-minor
PRs that contain new features and should be released in the next minor version.
and removed

dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
labels
May 25, 2026
@panva
panva
requested review from
ChALkeR and jasnellJune 7, 2026 09:57
@panva
panva
marked this pull request as draft
June 11, 2026 09:09
@panva
panva
marked this pull request as ready for review
June 14, 2026 10:13
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
944bf43 to
7c39722CompareJune 29, 2026 08:14
tniessen
tniessen
reviewed
Jun 29, 2026
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.h
Outdated

Comment threaddeps/ncrypto/ncrypto.cc
Outdated

@panva
panva
requested a review
from tniessenJune 30, 2026 21:04
@hylmarj
hylmarj
commented
Aug 17, 2026

Copy link


Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
823805b to
71999e4CompareAugust 20, 2026 09:20
@panvapanva
mentioned this pull request
Aug 20, 2026
 Closed

@panvapanva
removed
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@panvapanva
added
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76206/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e573bd6
into
nodejs:mainAug 22, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in e573bd6
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@panva
panva
deleted the

crypto-add-siv-modes

branch
August 22, 2026 08:25
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
9ee76f3
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
f0531f1
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

nodejs-github-bot added a commit
that referenced
this pull request
Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
aduh95 pushed a commit
that referenced
this pull request
Aug 26, 2026
@nodejs-github-bot@aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
@tniessentniessenAwaiting requested review from tniessen

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.cryptoIssues and PRs related to the crypto subsystem.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.review wantedPRs that need review.semver-minorPRs that contain new features and should be released in the next minor version.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()


6 participants

@panva@nodejs-github-bot@hylmarj@jasnell@tniessen@aduh95

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411
Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Aug 22, 2026
Merged
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Conversation
@panva
@panvapanva
commented
May 18, 2026

Copy link


Copy Markdown

Member
Closes#63393
@nodejs-github-bot
nodejs-github-bot
commented
May 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
a1ea9b7 to
127a852CompareMay 18, 2026 13:24
@panva
panva
requested a review
from tniessenMay 18, 2026 13:24
@panvapanva
added
the 
crypto
Issues and PRs related to the crypto subsystem.
label
May 18, 2026
@panva
panva
marked this pull request as ready for review
May 18, 2026 13:24
@panvapanva
added

dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
dont-land-on-v25.x

labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
687e02b to
b5764bcCompareMay 18, 2026 13:45
@codecov
codecovBot
commented
May 18, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 46 commits behind head on main.
Files with missing linesPatch %Lines
src/crypto/crypto_cipher.cc87.09%2 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63411 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 252325 252371 +46 Branches 47456 47472 +16 ==========================================
+ Hits 227407 227436 +29 - Misses 16217 16233 +16 - Partials 8701 8702 +1 
Files with missing linesCoverage Δ
src/crypto/crypto_cipher.h68.47% <ø> (ø)
src/crypto/crypto_cipher.cc78.04% <87.09%> (+1.34%)⬆️
... and 31 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panvapanva
added

review wanted
PRs that need review.
semver-minor
PRs that contain new features and should be released in the next minor version.
and removed

dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
labels
May 25, 2026
@panva
panva
requested review from
ChALkeR and jasnellJune 7, 2026 09:57
@panva
panva
marked this pull request as draft
June 11, 2026 09:09
@panva
panva
marked this pull request as ready for review
June 14, 2026 10:13
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
944bf43 to
7c39722CompareJune 29, 2026 08:14
tniessen
tniessen
reviewed
Jun 29, 2026
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.h
Outdated

Comment threaddeps/ncrypto/ncrypto.cc
Outdated

@panva
panva
requested a review
from tniessenJune 30, 2026 21:04
@hylmarj
hylmarj
commented
Aug 17, 2026

Copy link


Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
823805b to
71999e4CompareAugust 20, 2026 09:20
@panvapanva
mentioned this pull request
Aug 20, 2026
 Closed

@panvapanva
removed
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@panvapanva
added
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76206/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e573bd6
into
nodejs:mainAug 22, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in e573bd6
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@panva
panva
deleted the

crypto-add-siv-modes

branch
August 22, 2026 08:25
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
9ee76f3
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
f0531f1
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

nodejs-github-bot added a commit
that referenced
this pull request
Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
aduh95 pushed a commit
that referenced
this pull request
Aug 26, 2026
@nodejs-github-bot@aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
@tniessentniessenAwaiting requested review from tniessen

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.cryptoIssues and PRs related to the crypto subsystem.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.review wantedPRs that need review.semver-minorPRs that contain new features and should be released in the next minor version.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()


6 participants

@panva@nodejs-github-bot@hylmarj@jasnell@tniessen@aduh95

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411
Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Aug 22, 2026
Merged
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Conversation
@panva
@panvapanva
commented
May 18, 2026

Copy link


Copy Markdown

Member
Closes#63393
@nodejs-github-bot
nodejs-github-bot
commented
May 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
a1ea9b7 to
127a852CompareMay 18, 2026 13:24
@panva
panva
requested a review
from tniessenMay 18, 2026 13:24
@panvapanva
added
the 
crypto
Issues and PRs related to the crypto subsystem.
label
May 18, 2026
@panva
panva
marked this pull request as ready for review
May 18, 2026 13:24
@panvapanva
added

dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
dont-land-on-v25.x

labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
687e02b to
b5764bcCompareMay 18, 2026 13:45
@codecov
codecovBot
commented
May 18, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 46 commits behind head on main.
Files with missing linesPatch %Lines
src/crypto/crypto_cipher.cc87.09%2 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63411 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 252325 252371 +46 Branches 47456 47472 +16 ==========================================
+ Hits 227407 227436 +29 - Misses 16217 16233 +16 - Partials 8701 8702 +1 
Files with missing linesCoverage Δ
src/crypto/crypto_cipher.h68.47% <ø> (ø)
src/crypto/crypto_cipher.cc78.04% <87.09%> (+1.34%)⬆️
... and 31 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panvapanva
added

review wanted
PRs that need review.
semver-minor
PRs that contain new features and should be released in the next minor version.
and removed

dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
labels
May 25, 2026
@panva
panva
requested review from
ChALkeR and jasnellJune 7, 2026 09:57
@panva
panva
marked this pull request as draft
June 11, 2026 09:09
@panva
panva
marked this pull request as ready for review
June 14, 2026 10:13
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
944bf43 to
7c39722CompareJune 29, 2026 08:14
tniessen
tniessen
reviewed
Jun 29, 2026
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.h
Outdated

Comment threaddeps/ncrypto/ncrypto.cc
Outdated

@panva
panva
requested a review
from tniessenJune 30, 2026 21:04
@hylmarj
hylmarj
commented
Aug 17, 2026

Copy link


Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
823805b to
71999e4CompareAugust 20, 2026 09:20
@panvapanva
mentioned this pull request
Aug 20, 2026
 Closed

@panvapanva
removed
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@panvapanva
added
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76206/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e573bd6
into
nodejs:mainAug 22, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in e573bd6
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@panva
panva
deleted the

crypto-add-siv-modes

branch
August 22, 2026 08:25
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
9ee76f3
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
f0531f1
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

nodejs-github-bot added a commit
that referenced
this pull request
Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
aduh95 pushed a commit
that referenced
this pull request
Aug 26, 2026
@nodejs-github-bot@aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
@tniessentniessenAwaiting requested review from tniessen

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.cryptoIssues and PRs related to the crypto subsystem.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.review wantedPRs that need review.semver-minorPRs that contain new features and should be released in the next minor version.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()


6 participants

@panva@nodejs-github-bot@hylmarj@jasnell@tniessen@aduh95

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411
Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Aug 22, 2026
Merged
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Conversation
@panva
@panvapanva
commented
May 18, 2026

Copy link


Copy Markdown

Member
Closes#63393
@nodejs-github-bot
nodejs-github-bot
commented
May 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
a1ea9b7 to
127a852CompareMay 18, 2026 13:24
@panva
panva
requested a review
from tniessenMay 18, 2026 13:24
@panvapanva
added
the 
crypto
Issues and PRs related to the crypto subsystem.
label
May 18, 2026
@panva
panva
marked this pull request as ready for review
May 18, 2026 13:24
@panvapanva
added

dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
dont-land-on-v25.x

labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
687e02b to
b5764bcCompareMay 18, 2026 13:45
@codecov
codecovBot
commented
May 18, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 46 commits behind head on main.
Files with missing linesPatch %Lines
src/crypto/crypto_cipher.cc87.09%2 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63411 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 252325 252371 +46 Branches 47456 47472 +16 ==========================================
+ Hits 227407 227436 +29 - Misses 16217 16233 +16 - Partials 8701 8702 +1 
Files with missing linesCoverage Δ
src/crypto/crypto_cipher.h68.47% <ø> (ø)
src/crypto/crypto_cipher.cc78.04% <87.09%> (+1.34%)⬆️
... and 31 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panvapanva
added

review wanted
PRs that need review.
semver-minor
PRs that contain new features and should be released in the next minor version.
and removed

dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
labels
May 25, 2026
@panva
panva
requested review from
ChALkeR and jasnellJune 7, 2026 09:57
@panva
panva
marked this pull request as draft
June 11, 2026 09:09
@panva
panva
marked this pull request as ready for review
June 14, 2026 10:13
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
944bf43 to
7c39722CompareJune 29, 2026 08:14
tniessen
tniessen
reviewed
Jun 29, 2026
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.h
Outdated

Comment threaddeps/ncrypto/ncrypto.cc
Outdated

@panva
panva
requested a review
from tniessenJune 30, 2026 21:04
@hylmarj
hylmarj
commented
Aug 17, 2026

Copy link


Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
823805b to
71999e4CompareAugust 20, 2026 09:20
@panvapanva
mentioned this pull request
Aug 20, 2026
 Closed

@panvapanva
removed
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@panvapanva
added
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76206/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e573bd6
into
nodejs:mainAug 22, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in e573bd6
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@panva
panva
deleted the

crypto-add-siv-modes

branch
August 22, 2026 08:25
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
9ee76f3
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
f0531f1
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

nodejs-github-bot added a commit
that referenced
this pull request
Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
aduh95 pushed a commit
that referenced
this pull request
Aug 26, 2026
@nodejs-github-bot@aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
@tniessentniessenAwaiting requested review from tniessen

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.cryptoIssues and PRs related to the crypto subsystem.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.review wantedPRs that need review.semver-minorPRs that contain new features and should be released in the next minor version.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()


6 participants

@panva@nodejs-github-bot@hylmarj@jasnell@tniessen@aduh95

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411
Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Aug 22, 2026
Merged
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Conversation
@panva
@panvapanva
commented
May 18, 2026

Copy link


Copy Markdown

Member
Closes#63393
@nodejs-github-bot
nodejs-github-bot
commented
May 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
a1ea9b7 to
127a852CompareMay 18, 2026 13:24
@panva
panva
requested a review
from tniessenMay 18, 2026 13:24
@panvapanva
added
the 
crypto
Issues and PRs related to the crypto subsystem.
label
May 18, 2026
@panva
panva
marked this pull request as ready for review
May 18, 2026 13:24
@panvapanva
added

dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
dont-land-on-v25.x

labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
687e02b to
b5764bcCompareMay 18, 2026 13:45
@codecov
codecovBot
commented
May 18, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 46 commits behind head on main.
Files with missing linesPatch %Lines
src/crypto/crypto_cipher.cc87.09%2 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63411 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 252325 252371 +46 Branches 47456 47472 +16 ==========================================
+ Hits 227407 227436 +29 - Misses 16217 16233 +16 - Partials 8701 8702 +1 
Files with missing linesCoverage Δ
src/crypto/crypto_cipher.h68.47% <ø> (ø)
src/crypto/crypto_cipher.cc78.04% <87.09%> (+1.34%)⬆️
... and 31 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panvapanva
added

review wanted
PRs that need review.
semver-minor
PRs that contain new features and should be released in the next minor version.
and removed

dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
labels
May 25, 2026
@panva
panva
requested review from
ChALkeR and jasnellJune 7, 2026 09:57
@panva
panva
marked this pull request as draft
June 11, 2026 09:09
@panva
panva
marked this pull request as ready for review
June 14, 2026 10:13
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
944bf43 to
7c39722CompareJune 29, 2026 08:14
tniessen
tniessen
reviewed
Jun 29, 2026
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.h
Outdated

Comment threaddeps/ncrypto/ncrypto.cc
Outdated

@panva
panva
requested a review
from tniessenJune 30, 2026 21:04
@hylmarj
hylmarj
commented
Aug 17, 2026

Copy link


Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
823805b to
71999e4CompareAugust 20, 2026 09:20
@panvapanva
mentioned this pull request
Aug 20, 2026
 Closed

@panvapanva
removed
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@panvapanva
added
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76206/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e573bd6
into
nodejs:mainAug 22, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in e573bd6
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@panva
panva
deleted the

crypto-add-siv-modes

branch
August 22, 2026 08:25
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
9ee76f3
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
f0531f1
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

nodejs-github-bot added a commit
that referenced
this pull request
Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
aduh95 pushed a commit
that referenced
this pull request
Aug 26, 2026
@nodejs-github-bot@aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
@tniessentniessenAwaiting requested review from tniessen

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.cryptoIssues and PRs related to the crypto subsystem.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.review wantedPRs that need review.semver-minorPRs that contain new features and should be released in the next minor version.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()


6 participants

@panva@nodejs-github-bot@hylmarj@jasnell@tniessen@aduh95

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411
Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Aug 22, 2026
Merged
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Conversation
@panva
@panvapanva
commented
May 18, 2026

Copy link


Copy Markdown

Member
Closes#63393
@nodejs-github-bot
nodejs-github-bot
commented
May 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
a1ea9b7 to
127a852CompareMay 18, 2026 13:24
@panva
panva
requested a review
from tniessenMay 18, 2026 13:24
@panvapanva
added
the 
crypto
Issues and PRs related to the crypto subsystem.
label
May 18, 2026
@panva
panva
marked this pull request as ready for review
May 18, 2026 13:24
@panvapanva
added

dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
dont-land-on-v25.x

labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
687e02b to
b5764bcCompareMay 18, 2026 13:45
@codecov
codecovBot
commented
May 18, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 46 commits behind head on main.
Files with missing linesPatch %Lines
src/crypto/crypto_cipher.cc87.09%2 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63411 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 252325 252371 +46 Branches 47456 47472 +16 ==========================================
+ Hits 227407 227436 +29 - Misses 16217 16233 +16 - Partials 8701 8702 +1 
Files with missing linesCoverage Δ
src/crypto/crypto_cipher.h68.47% <ø> (ø)
src/crypto/crypto_cipher.cc78.04% <87.09%> (+1.34%)⬆️
... and 31 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panvapanva
added

review wanted
PRs that need review.
semver-minor
PRs that contain new features and should be released in the next minor version.
and removed

dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
labels
May 25, 2026
@panva
panva
requested review from
ChALkeR and jasnellJune 7, 2026 09:57
@panva
panva
marked this pull request as draft
June 11, 2026 09:09
@panva
panva
marked this pull request as ready for review
June 14, 2026 10:13
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
944bf43 to
7c39722CompareJune 29, 2026 08:14
tniessen
tniessen
reviewed
Jun 29, 2026
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.h
Outdated

Comment threaddeps/ncrypto/ncrypto.cc
Outdated

@panva
panva
requested a review
from tniessenJune 30, 2026 21:04
@hylmarj
hylmarj
commented
Aug 17, 2026

Copy link


Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
823805b to
71999e4CompareAugust 20, 2026 09:20
@panvapanva
mentioned this pull request
Aug 20, 2026
 Closed

@panvapanva
removed
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@panvapanva
added
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76206/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e573bd6
into
nodejs:mainAug 22, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in e573bd6
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@panva
panva
deleted the

crypto-add-siv-modes

branch
August 22, 2026 08:25
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
9ee76f3
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
f0531f1
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

nodejs-github-bot added a commit
that referenced
this pull request
Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
aduh95 pushed a commit
that referenced
this pull request
Aug 26, 2026
@nodejs-github-bot@aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
@tniessentniessenAwaiting requested review from tniessen

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.cryptoIssues and PRs related to the crypto subsystem.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.review wantedPRs that need review.semver-minorPRs that contain new features and should be released in the next minor version.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()


6 participants

@panva@nodejs-github-bot@hylmarj@jasnell@tniessen@aduh95

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411
Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Aug 22, 2026
Merged
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
nodejs-github-bot merged 4 commits into
nodejs:mainfrom 
panva:crypto-add-siv-modes
Conversation
@panva
@panvapanva
commented
May 18, 2026

Copy link


Copy Markdown

Member
Closes#63393
@nodejs-github-bot
nodejs-github-bot
commented
May 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
a1ea9b7 to
127a852CompareMay 18, 2026 13:24
@panva
panva
requested a review
from tniessenMay 18, 2026 13:24
@panvapanva
added
the 
crypto
Issues and PRs related to the crypto subsystem.
label
May 18, 2026
@panva
panva
marked this pull request as ready for review
May 18, 2026 13:24
@panvapanva
added

dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
dont-land-on-v25.x

labels
May 18, 2026
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
687e02b to
b5764bcCompareMay 18, 2026 13:45
@codecov
codecovBot
commented
May 18, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 46 commits behind head on main.
Files with missing linesPatch %Lines
src/crypto/crypto_cipher.cc87.09%2 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63411 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 252325 252371 +46 Branches 47456 47472 +16 ==========================================
+ Hits 227407 227436 +29 - Misses 16217 16233 +16 - Partials 8701 8702 +1 
Files with missing linesCoverage Δ
src/crypto/crypto_cipher.h68.47% <ø> (ø)
src/crypto/crypto_cipher.cc78.04% <87.09%> (+1.34%)⬆️
... and 31 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panvapanva
added

review wanted
PRs that need review.
semver-minor
PRs that contain new features and should be released in the next minor version.
and removed

dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
labels
May 25, 2026
@panva
panva
requested review from
ChALkeR and jasnellJune 7, 2026 09:57
@panva
panva
marked this pull request as draft
June 11, 2026 09:09
@panva
panva
marked this pull request as ready for review
June 14, 2026 10:13
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
944bf43 to
7c39722CompareJune 29, 2026 08:14
tniessen
tniessen
reviewed
Jun 29, 2026
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.h
Outdated

Comment threaddeps/ncrypto/ncrypto.cc
Outdated

@panva
panva
requested a review
from tniessenJune 30, 2026 21:04
@hylmarj
hylmarj
commented
Aug 17, 2026

Copy link


Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?
@panva
panvaforce-pushed
the
crypto-add-siv-modes
branch
from
823805b to
71999e4CompareAugust 20, 2026 09:20
@panvapanva
mentioned this pull request
Aug 20, 2026
 Closed

@panvapanva
removed
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@panvapanva
added
the 
review wanted
PRs that need review.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76206/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e573bd6
into
nodejs:mainAug 22, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in e573bd6
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
@panva
panva
deleted the

crypto-add-siv-modes

branch
August 22, 2026 08:25
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
9ee76f3
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs
f0531f1
Closes#63393
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63411
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

nodejs-github-bot added a commit
that referenced
this pull request
Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
aduh95 pushed a commit
that referenced
this pull request
Aug 26, 2026
@nodejs-github-bot@aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:
benchmark:
* (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
* update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
* (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
* mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
* (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
* (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
* (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
* add basic syntax highlighting (Aviv Keller) #64591
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
* (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
* (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
* (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339
PR-URL: #65551
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@ChALkeRChALkeRAwaiting requested review from ChALkeR
@tniessentniessenAwaiting requested review from tniessen

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.cryptoIssues and PRs related to the crypto subsystem.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.review wantedPRs that need review.semver-minorPRs that contain new features and should be released in the next minor version.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()


6 participants

@panva@nodejs-github-bot@hylmarj@jasnell@tniessen@aduh95