Skip to content

test: increase the platform timeout for AIX - #6342

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:aixtime
Closed

test: increase the platform timeout for AIX#6342
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:aixtime

Conversation

@mhdawson

@mhdawsonmhdawson commented Apr 21, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extending the platform
timeout for AIX. This commit does that.

addresses: #6333

There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extending the platform
timeout for AIX. This commit does that.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Apr 21, 2016
@mhdawson

Copy link
Copy Markdown
MemberAuthor

@mhdawsonmhdawson self-assigned this Apr 21, 2016
@mhdawson

Copy link
Copy Markdown
MemberAuthor

CI run all green

@jasnell

Copy link
Copy Markdown
Member

LGTM

@Fishrock123

Copy link
Copy Markdown
Contributor

LGTM

mhdawson added a commit that referenced this pull request Apr 25, 2016
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.
PR-URL: #6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@mhdawson

Copy link
Copy Markdown
MemberAuthor

Landed as 75e073f

@mhdawson

Copy link
Copy Markdown
MemberAuthor

Only needs a backport if #6286 is backported

joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.
PR-URL: nodejs#6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.
PR-URL: #6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.
PR-URL: #6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.
PR-URL: #6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 18, 2016
@mhdawson
mhdawson deleted the aixtime branch March 15, 2017 21:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mhdawson@jasnell@Fishrock123@MylesBorins@nodejs-github-bot