Uh oh!
There was an error while loading. Please reload this page.
doc: mention crypto.hash() for better perf - #63420
Merged
Merged
Conversation
nodejs-github-bot
commented
May 19, 2026
Collaborator
Review requested:
|
Signed-off-by: Steven <steven@ceriously.com>
anonrig
approved these changes
May 19, 2026
joyeecheung
left a comment
Member
There was a problem hiding this comment.
I feel that we should be less imperative in the docs for performance recommendations, it's better to just state the performance observations and users can decide for themselves considering their input shapes (it's not definitively faster if the data is not readily available).
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 21, 2026
Collaborator
Landed in f3ecafa |
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs on
crypto.hash()already mentioned why you would use it overcrypto.createHash().This PR adds the reverse so that the docs on
crypto.createHash()mention why you would usecrypto.hash().