Skip to content

[v26.x backport] BoringSSL support - #63433

Closed
aduh95 wants to merge 3 commits into
nodejs:v26.x-stagingfrom
panva:backport-63161-to-26
Closed

[v26.x backport] BoringSSL support#63433
aduh95 wants to merge 3 commits into
nodejs:v26.x-stagingfrom
panva:backport-63161-to-26

Conversation

@aduh95

@aduh95aduh95 commented May 19, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

@nodejs-github-botnodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. labels May 19, 2026
panva added 3 commits May 19, 2026 17:44
@panva
test: update tls/crypto behaviour expectations when using BoringSSL
f895f69
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#63161
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panva
src: add BoringSSL EVP enumeration fallback
c4fff0e
BoringSSL declares EVP_CIPHER_do_all_sorted and
EVP_MD_do_all_sorted, but stock no-decrepit builds do not provide
those symbols. Add a Node build flag that keeps ncrypto and its
dependents on a local BoringSSL fallback list when libdecrepit is
absent.
Keep embedders that provide the EVP enumeration symbols on the normal
OpenSSL-compatible path, matching Electron's patched BoringSSL build.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#63206
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
tools: add boringssl to tools/nix/openssl-matrix.nix
f58a33a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#63206
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed the backport-63161-to-26 branch from 890215f to f58a33aCompareMay 19, 2026 15:44
@nodejs-github-bot

nodejs-github-bot commented May 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73559/

@nodejs-github-bot

nodejs-github-bot commented May 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73561/

@aduh95

aduh95 commented May 19, 2026

Copy link
Copy Markdown
ContributorAuthor

LGTM

aduh95 pushed a commit that referenced this pull request May 19, 2026
@panva@aduh95
test: update tls/crypto behaviour expectations when using BoringSSL
a57aeba
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63161
Backport-PR-URL: #63433
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2026
@panva@aduh95
tools: add boringssl to tools/nix/openssl-matrix.nix
f14ed76
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63206
Backport-PR-URL: #63433
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95

aduh95 commented May 19, 2026

Copy link
Copy Markdown
ContributorAuthor

Landed in b871cff...f14ed76

@aduh95aduh95 closed this May 19, 2026
@panva
panva deleted the backport-63161-to-26 branch May 19, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

addonsIssues and PRs related to native addons.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95@nodejs-github-bot@panva