Uh oh!
There was an error while loading. Please reload this page.
doc: clarify tty raw mode applies to input processing only - #63438
Merged
nodejs-github-bot merged 1 commit intoJun 2, 2026
Conversation
addaleax
approved these changes
May 21, 2026
addaleax
commented
Jun 2, 2026
Member
@zeeshan56656 I'm sorry, but can you push to this branch again to update the commit message to include a |
zeeshan56656force-pushed
the
fix/63059-tty-rawmode-doc
branch
from
June 2, 2026 12:27
e791173 to
da0ec46CompareUpdate the setRawMode documentation to specify that raw mode disables special processing of input characters only. Output processing, such as newline translation on Unix terminals, is not affected. Fixes: nodejs#63059 Signed-off-by: zeeshan56656 <zeeshan130710@gmail.com>
zeeshan56656force-pushed
the
fix/63059-tty-rawmode-doc
branch
from
June 2, 2026 12:42
da0ec46 to
4bb0b0aComparezeeshan56656
commented
Jun 2, 2026
ContributorAuthor
Done, pushed an amended commit with the Signed-off-by trailer. Thanks for the heads-up on the new DCO requirement! 🙏 |
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 2, 2026
Collaborator
Landed in 7b08df7 |
samuel-williams-shopify
commented
Jun 3, 2026
Folks, now that we addressed the documentation, is there any appetite to actually fix raw mode so that it's actually raw mode? perhaps we can pass a flag so the existing interface stays compatible. |
aduh95 pushed a commit
that referenced
this pull request
Jun 18, 2026
Update the setRawMode documentation to specify that raw mode disables special processing of input characters only. Output processing, such as newline translation on Unix terminals, is not affected. Fixes: #63059 Signed-off-by: zeeshan56656 <zeeshan130710@gmail.com> PR-URL: #63438 Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit
that referenced
this pull request
Jun 25, 2026
Update the setRawMode documentation to specify that raw mode disables special processing of input characters only. Output processing, such as newline translation on Unix terminals, is not affected. Fixes: #63059 Signed-off-by: zeeshan56656 <zeeshan130710@gmail.com> PR-URL: #63438 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
commented
Jun 25, 2026
Member
@samuel-williams-shopify I think you'd be welcome to add such a mode to libuv and expose it in Node.js – libuv/libuv@843b64f would be an example of what adding a new TTY mode to libuv looks like |
samuel-williams-shopify
commented
Jun 26, 2026
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
Update the setRawMode documentation to specify that raw mode disables special processing of input characters only. Output processing, such as newline translation on Unix terminals, is not affected. Fixes: #63059 Signed-off-by: zeeshan56656 <zeeshan130710@gmail.com> PR-URL: #63438 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tty.ReadStream.setRawMode()documentation currently states that "all special processing of characters by the terminal is disabled", which is misleading. On Unix, raw mode (cfmakeraw/ICANON+ISIG+IEXTENcleared) only affects input character processing. Output processing flags such asOPOSTandONLCR, which perform the\nto\r\ntranslation on terminal output, are untouched bysetRawMode(true).This change scopes the existing sentence to input characters and adds a brief note clarifying that terminal output processing, including newline translation on Unix terminals, is not affected. No runtime behavior changes.
Fixes: #63059
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (documentation only change)