Uh oh!
There was an error while loading. Please reload this page.
crypto: fix error in deprecation message - #6344
Closed
Trott wants to merge 1 commit into
Closed
Conversation
jasnell
commented
Apr 22, 2016
Member
LGTM |
estliberitasforce-pushed
the
master
branch
2 times, most recently
from
April 26, 2016 05:23
7da4fd4 to
c7066fbCompareThe deprecation message for `crypto.Credentials` says to use `tls.createSecureContext` but the correct property to use is `tls.SecureContext()`. Fix the deprecation message and add a test that checks the mappings of deprecated properties and their warning messages.
Trott
commented
Apr 27, 2016
MemberAuthor
Trott
commented
Apr 28, 2016
MemberAuthor
CI failures are one buildbot failure and the current problematic tick processor issue on OS X. Unrelated, of course. |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Apr 28, 2016
The deprecation message for `crypto.Credentials` says to use `tls.createSecureContext` but the correct property to use is `tls.SecureContext()`. Fix the deprecation message and add a test that checks the mappings of deprecated properties and their warning messages. PR-URL: nodejs#6344 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Apr 28, 2016
MemberAuthor
Landed in 296bfd2 |
Fishrock123 pushed a commit
that referenced
this pull request
May 4, 2016
The deprecation message for `crypto.Credentials` says to use `tls.createSecureContext` but the correct property to use is `tls.SecureContext()`. Fix the deprecation message and add a test that checks the mappings of deprecated properties and their warning messages. PR-URL: #6344 Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 4, 2016
MylesBorins
commented
Jun 1, 2016
Contributor
@Trott lts? |
Trott
commented
Jun 1, 2016
MemberAuthor
@thealphanerd Yes. |
Contributor
@Trott test failure on v4.x-staging, can you manually backport? edit: please include all original meta data |
Trott
commented
Jun 2, 2016
MemberAuthor
@thealphanerd Is the test failing because |
MylesBorins
commented
Jun 2, 2016
Contributor
|
Trott
commented
Jun 2, 2016
MemberAuthor
This depends on So the test needs to be re-written for LTS. Or we could choose not to land. Or you could just land the deprecation message text change and not land the test. |
MylesBorins
commented
Jul 11, 2016
Contributor
@Trott I'm leaving this as don't land for now. Please feel free to open a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
crypto test
Description of change
The deprecation message for
crypto.Credentialssays to usetls.createSecureContextbut the correct property to use istls.SecureContext().Fix the deprecation message and add a test that checks the mappings of
deprecated properties and their warning messages.
@nodejs/crypto