Skip to content

stream: flush each fused stateless transform - #63468

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:stream-iter-consecutive-text
May 23, 2026
Merged

stream: flush each fused stateless transform#63468
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:stream-iter-consecutive-text

Conversation

@trivikr

@trivikrtrivikr commented May 21, 2026

Copy link
Copy Markdown
Member

This fixes fused stateless stream/iter transform flushing so each
transform receives its own final null after upstream flush output has
been processed.

Previously, if one stateless transform emitted data during flush, the
next transform processed that data but did not receive its own final
flush signal.

Fixes: #63467

Assisted-by: openai:gpt-5.5

@nodejs-github-bot

nodejs-github-bot commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels May 21, 2026
@trivikr
stream: flush each fused stateless transform
1cef78f
Ensure consecutive stateless stream/iter transforms each receive a
final null flush after upstream flush output has been processed.
Fixes: nodejs#63467
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
@trivikr
trivikrforce-pushed the stream-iter-consecutive-text branch from 97055b3 to 1cef78fCompareMay 21, 2026 04:00
@codecov

codecovBot commented May 21, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.09%. Comparing base (614050b) to head (1cef78f).
⚠️ Report is 58 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63468 +/- ##
==========================================
- Coverage 91.67% 90.09% -1.59% 
==========================================
Files 361 714 +353 Lines 156408 225935 +69527 Branches 24050 42743 +18693 ==========================================
+ Hits 143384 203550 +60166 - Misses 12751 14169 +1418 - Partials 273 8216 +7943
Files with missing linesCoverage Δ
lib/internal/streams/iter/pull.js88.12% <100.00%> (+2.97%)⬆️

... and 476 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes May 21, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trivikrtrivikr added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73611/

@trivikr
trivikr requested a review from jasnellMay 23, 2026 02:45
@jasnelljasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 837910d into nodejs:mainMay 23, 2026
77 of 78 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Landed in 837910d

@trivikr
trivikr deleted the stream-iter-consecutive-text branch May 27, 2026 07:50
aduh95 pushed a commit that referenced this pull request May 27, 2026
@trivikr@aduh95
stream: flush each fused stateless transform
4f40a85
Ensure consecutive stateless stream/iter transforms each receive a
final null flush after upstream flush output has been processed.
Fixes: #63467
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
PR-URL: #63468Fixes: #63467
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 30, 2026
Merged
@aduh95aduh95 mentioned this pull request Jul 22, 2026
Closed
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 30, 2026
@trivikr@aduh95
stream: flush each fused stateless transform
93c1002
Ensure consecutive stateless stream/iter transforms each receive a
final null flush after upstream flush output has been processed.
Fixes: nodejs#63467
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
PR-URL: nodejs#63468Fixes: nodejs#63467
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@trivikr@aduh95
stream: flush each fused stateless transform
217b495
Ensure consecutive stateless stream/iter transforms each receive a
final null flush after upstream flush output has been processed.
Fixes: #63467
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
PR-URL: #63468
Backport-PR-URL: #64675Fixes: #63467
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stream/iter: consecutive stateless stream/iter transforms lose downstream flush output

4 participants

@trivikr@nodejs-github-bot@mcollina@jasnell