stream: keep overlapping broadcast reads pending by trivikr · Pull Request #63500 · nodejs/node

trivikr · 2026-05-23T04:24:23Z

broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.

This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.

Fixes: #63499

Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-05-23T04:24:28Z

Review requested:

@nodejs/streams

codecov · 2026-05-23T05:46:22Z

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (37779fd) to head (d2bf99e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/broadcast.js	83.92%	9 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35% =======================================
Files 732 732 Lines 236689 236741 +52 Branches 44586 44601 +15 =======================================
+ Hits 213839 213897 +58 
Misses 14550 14550 + Partials 8300 8294 -6

Files with missing lines	Coverage Δ
lib/internal/streams/iter/broadcast.js	`86.03% <83.92%> (+0.78%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-05-25T22:25:28Z

Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit.

Details in #63499 (comment)

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-06-20T01:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74280/

nodejs-github-bot · 2026-06-20T04:04:10Z

Landed in d1eaaf6

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

trivikr · 2026-05-23T04:24:23Z

broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.

This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.

Fixes: #63499

Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-05-23T04:24:28Z

Review requested:

@nodejs/streams

codecov · 2026-05-23T05:46:22Z

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (37779fd) to head (d2bf99e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/broadcast.js	83.92%	9 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35% =======================================
Files 732 732 Lines 236689 236741 +52 Branches 44586 44601 +15 =======================================
+ Hits 213839 213897 +58 
Misses 14550 14550 + Partials 8300 8294 -6

Files with missing lines	Coverage Δ
lib/internal/streams/iter/broadcast.js	`86.03% <83.92%> (+0.78%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-05-25T22:25:28Z

Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit.

Details in #63499 (comment)

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-06-20T01:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74280/

nodejs-github-bot · 2026-06-20T04:04:10Z

Landed in d1eaaf6

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

trivikr · 2026-05-23T04:24:23Z

broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.

This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.

Fixes: #63499

Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-05-23T04:24:28Z

Review requested:

@nodejs/streams

codecov · 2026-05-23T05:46:22Z

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (37779fd) to head (d2bf99e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/broadcast.js	83.92%	9 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35% =======================================
Files 732 732 Lines 236689 236741 +52 Branches 44586 44601 +15 =======================================
+ Hits 213839 213897 +58 
Misses 14550 14550 + Partials 8300 8294 -6

Files with missing lines	Coverage Δ
lib/internal/streams/iter/broadcast.js	`86.03% <83.92%> (+0.78%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-05-25T22:25:28Z

Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit.

Details in #63499 (comment)

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-06-20T01:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74280/

nodejs-github-bot · 2026-06-20T04:04:10Z

Landed in d1eaaf6

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

trivikr · 2026-05-23T04:24:23Z

broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.

This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.

Fixes: #63499

Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-05-23T04:24:28Z

Review requested:

@nodejs/streams

codecov · 2026-05-23T05:46:22Z

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (37779fd) to head (d2bf99e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/broadcast.js	83.92%	9 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35% =======================================
Files 732 732 Lines 236689 236741 +52 Branches 44586 44601 +15 =======================================
+ Hits 213839 213897 +58 
Misses 14550 14550 + Partials 8300 8294 -6

Files with missing lines	Coverage Δ
lib/internal/streams/iter/broadcast.js	`86.03% <83.92%> (+0.78%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-05-25T22:25:28Z

Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit.

Details in #63499 (comment)

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-06-20T01:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74280/

nodejs-github-bot · 2026-06-20T04:04:10Z

Landed in d1eaaf6

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

trivikr · 2026-05-23T04:24:23Z

broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.

This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.

Fixes: #63499

Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-05-23T04:24:28Z

Review requested:

@nodejs/streams

codecov · 2026-05-23T05:46:22Z

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (37779fd) to head (d2bf99e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/broadcast.js	83.92%	9 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35% =======================================
Files 732 732 Lines 236689 236741 +52 Branches 44586 44601 +15 =======================================
+ Hits 213839 213897 +58 
Misses 14550 14550 + Partials 8300 8294 -6

Files with missing lines	Coverage Δ
lib/internal/streams/iter/broadcast.js	`86.03% <83.92%> (+0.78%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-05-25T22:25:28Z

Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit.

Details in #63499 (comment)

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-06-20T01:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74280/

nodejs-github-bot · 2026-06-20T04:04:10Z

Landed in d1eaaf6

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

trivikr · 2026-05-23T04:24:23Z

broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.

This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.

Fixes: #63499

Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-05-23T04:24:28Z

Review requested:

@nodejs/streams

codecov · 2026-05-23T05:46:22Z

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (37779fd) to head (d2bf99e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/broadcast.js	83.92%	9 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35% =======================================
Files 732 732 Lines 236689 236741 +52 Branches 44586 44601 +15 =======================================
+ Hits 213839 213897 +58 
Misses 14550 14550 + Partials 8300 8294 -6

Files with missing lines	Coverage Δ
lib/internal/streams/iter/broadcast.js	`86.03% <83.92%> (+0.78%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-05-25T22:25:28Z

Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit.

Details in #63499 (comment)

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-06-20T01:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74280/

nodejs-github-bot · 2026-06-20T04:04:10Z

Landed in d1eaaf6

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

trivikr · 2026-05-23T04:24:23Z

broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.

This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.

Fixes: #63499

Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-05-23T04:24:28Z

Review requested:

@nodejs/streams

codecov · 2026-05-23T05:46:22Z

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (37779fd) to head (d2bf99e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/broadcast.js	83.92%	9 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35% =======================================
Files 732 732 Lines 236689 236741 +52 Branches 44586 44601 +15 =======================================
+ Hits 213839 213897 +58 
Misses 14550 14550 + Partials 8300 8294 -6

Files with missing lines	Coverage Δ
lib/internal/streams/iter/broadcast.js	`86.03% <83.92%> (+0.78%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-05-25T22:25:28Z

Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit.

Details in #63499 (comment)

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-06-20T01:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74280/

nodejs-github-bot · 2026-06-20T04:04:10Z

Landed in d1eaaf6

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

trivikr · 2026-05-23T04:24:23Z

broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.

This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.

Fixes: #63499

Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-05-23T04:24:28Z

Review requested:

@nodejs/streams

codecov · 2026-05-23T05:46:22Z

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (37779fd) to head (d2bf99e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/broadcast.js	83.92%	9 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35% =======================================
Files 732 732 Lines 236689 236741 +52 Branches 44586 44601 +15 =======================================
+ Hits 213839 213897 +58 
Misses 14550 14550 + Partials 8300 8294 -6

Files with missing lines	Coverage Δ
lib/internal/streams/iter/broadcast.js	`86.03% <83.92%> (+0.78%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-05-25T22:25:28Z

Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit.

Details in #63499 (comment)

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5

nodejs-github-bot · 2026-06-20T01:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74280/

nodejs-github-bot · 2026-06-20T04:04:10Z

Landed in d1eaaf6

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>

Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to Node.js streams. labels May 23, 2026

trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2026

jasnell approved these changes May 23, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2026

This comment was marked as outdated.
Sign in to view

trivikr added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 23, 2026

This comment was marked as outdated.
Sign in to view

trivikr force-pushed the stream-iter-broadcast-next-pending branch from 87668cb to ae779b6Compare May 25, 2026 22:22

trivikr requested a review from jasnell May 25, 2026 22:23

trivikr force-pushed the stream-iter-broadcast-next-pending branch from ae779b6 to c556978Compare May 25, 2026 22:24

trivikr changed the title ~~stream: fix overlapping broadcast next calls~~stream: keep overlapping broadcast reads pendingMay 25, 2026

trivikr force-pushed the stream-iter-broadcast-next-pending branch from c556978 to c47708dCompare May 27, 2026 01:21

trivikr added request-ci Add this label to start a Jenkins CI on a PR. and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels May 27, 2026

trivikr force-pushed the stream-iter-broadcast-next-pending branch 3 times, most recently from f1aaff6 to d2bf99eCompare June 2, 2026 03:43

trivikr added review wanted PRs that need review. and removed review wanted PRs that need review. labels Jun 4, 2026

trivikr force-pushed the stream-iter-broadcast-next-pending branch 3 times, most recently from af686c7 to 1ac85e8Compare June 13, 2026 14:06

trivikr force-pushed the stream-iter-broadcast-next-pending branch from 1ac85e8 to e35fdedCompare June 15, 2026 03:53

trivikr force-pushed the stream-iter-broadcast-next-pending branch from e35fded to 8a996e3Compare June 18, 2026 00:24

jasnell approved these changes Jun 19, 2026
View reviewed changes

trivikr added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 19, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2026

This comment was marked as outdated.
Sign in to view

trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 20, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 20, 2026

nodejs-github-bot merged commit d1eaaf6 into nodejs:mainJun 20, 2026
69 of 73 checks passed

trivikr deleted the stream-iter-broadcast-next-pending branch June 20, 2026 06:49

github-actionsBot mentioned this pull request Jun 22, 2026
2026-06-23, Version 26.4.0 (Current) #64058
Merged

aduh95 mentioned this pull request Jul 22, 2026
[v24.x backport] node:stream/iter and QUIC backports #64675
Closed

github-actionsBot mentioned this pull request Aug 21, 2026
2026-08-26, Version 24.20.0 'Krypton' (LTS) #65461
Merged