Skip to content

test_runner: ignore erased TS lines in coverage - #63510

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:fix-test-coverage-import-type
May 28, 2026
Merged

test_runner: ignore erased TS lines in coverage#63510
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:fix-test-coverage-import-type

Conversation

@mcollina

@mcollinamcollina commented May 23, 2026•
edited
Loading

Copy link
Copy Markdown
Member
  • ignore TypeScript lines that are erased before runtime when source-map coverage is reported
  • use the internal TypeScript stripper to detect type-only lines in mapped sources
  • add a regression test for import type coverage with --enable-source-maps

Fixes: #54753

@nodejs-github-bot

nodejs-github-bot commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 23, 2026
@mcollina
mcollina marked this pull request as ready for review May 23, 2026 13:27
@mcollina
test_runner: ignore erased TS lines in coverage
afed6fc
Fixes: nodejs#54753
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
@mcollina
mcollinaforce-pushed the fix-test-coverage-import-type branch from ea0e334 to afed6fcCompareMay 23, 2026 13:30
@codecov

codecovBot commented May 23, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.10256% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (8d3245e) to head (afed6fc).
⚠️ Report is 68 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/test_runner/coverage.js12.50%63 Missing ⚠️
lib/internal/modules/typescript.js33.33%4 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63510 +/- ##
==========================================
- Coverage 90.14% 90.11% -0.04% 
==========================================
Files 718 718 Lines 227984 228059 +75 Branches 42835 42832 -3 ==========================================
- Hits 205522 205520 -2 - Misses 14235 14318 +83 + Partials 8227 8221 -6
Files with missing linesCoverage Δ
lib/internal/modules/typescript.js90.65% <33.33%> (-1.66%)⬇️
lib/internal/test_runner/coverage.js59.58% <12.50%> (-4.61%)⬇️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi
atlowChemi reviewed May 24, 2026
View reviewed changes

@atlowChemiatlowChemi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina what would be the performance price of this change?

@mcollina

mcollina commented May 24, 2026

Copy link
Copy Markdown
MemberAuthor

I have no idea tbh, do we have any bench for coverage? I'm mostly focusing on correctness/getting coverage out of experimental.

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2026
@atlowChemi

atlowChemi commented May 24, 2026

Copy link
Copy Markdown
Member

I have no idea tbh, do we have any bench for coverage? I'm mostly focusing on correctness/getting coverage out of experimental.

I recalled @avivkeller added one, but I can't find one, so I guess we don't 🤷🏽‍♂️

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2026
@nodejs-github-bot

nodejs-github-bot commented May 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73668/

@trivikr

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73799/

@atlowChemiatlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 28, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 8d0a3b8 into nodejs:mainMay 28, 2026
87 of 88 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Landed in 8d0a3b8

aduh95 pushed a commit that referenced this pull request May 30, 2026
@mcollina@aduh95
test_runner: ignore erased TS lines in coverage
1731283
Fixes: #54753
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #63510
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 30, 2026
Merged
aduh95 pushed a commit that referenced this pull request May 30, 2026
@mcollina@aduh95
test_runner: ignore erased TS lines in coverage
d56c6cd
Fixes: #54753
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #63510
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 20, 2026
@mcollina@aduh95
test_runner: ignore erased TS lines in coverage
151e308
Fixes: #54753
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #63510
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@mcollina@aduh95
test_runner: ignore erased TS lines in coverage
7f3f9de
Fixes: #54753
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #63510
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@mcollina@aduh95
test_runner: ignore erased TS lines in coverage
5022c95
Fixes: #54753
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #63510
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@mcollina@aduh95
test_runner: ignore erased TS lines in coverage
0948693
Fixes: #54753
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #63510
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLowMoLowMoLow approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.moduleIssues and PRs related to the module subsystem.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--experimental-test-coverage falsely reports missing coverage where TS source is import type

6 participants

@mcollina@nodejs-github-bot@atlowChemi@trivikr@MoLow@pmarchini