Skip to content

doc,lib: align WebCrypto names with spec - #63518

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:align-spec-names
May 25, 2026
Merged

doc,lib: align WebCrypto names with spec#63518
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:align-spec-names

Conversation

@panva

@panvapanva commented May 23, 2026

Copy link
Copy Markdown
Member

Rename WebCrypto operation parameters and local variables to match the spec terminology. Use operation, algorithm, and key names consistently between the docs and implementation.

@panva
doc,lib: align WebCrypto names with spec
9421937
Rename WebCrypto operation parameters and local variables to match the
spec terminology.
Use operation, algorithm, and key names consistently between the docs
and implementation.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panvapanva added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. webcrypto dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x labels May 23, 2026
@nodejs-github-bot

nodejs-github-bot commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 23, 2026
@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 23, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

codecovBot commented May 23, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (dfe2d47) to head (9421937).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63518 +/- ##
========================================
Coverage 90.13% 90.13% ========================================
Files 718 718 Lines 228399 228500 +101 Branches 42931 42941 +10 ========================================
+ Hits 205860 205957 +97 - Misses 14283 14286 +3 - Partials 8256 8257 +1
Files with missing linesCoverage Δ
lib/internal/crypto/aes.js92.61% <100.00%> (ø)
lib/internal/crypto/cfrg.js94.67% <100.00%> (ø)
lib/internal/crypto/chacha20_poly1305.js98.47% <100.00%> (ø)
lib/internal/crypto/ec.js95.54% <100.00%> (ø)
lib/internal/crypto/mac.js99.02% <100.00%> (ø)
lib/internal/crypto/ml_dsa.js97.46% <100.00%> (ø)
lib/internal/crypto/ml_kem.js95.49% <100.00%> (ø)
lib/internal/crypto/rsa.js94.47% <100.00%> (ø)
lib/internal/crypto/webcrypto.js97.03% <100.00%> (+0.14%)⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95
aduh95 approved these changes May 23, 2026
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not check the spec, but the change looks OK

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73641/

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2026
@nodejs-github-bot
nodejs-github-bot merged commit ecee55e into nodejs:mainMay 25, 2026
110 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Landed in ecee55e

@panva
panva deleted the align-spec-names branch May 25, 2026 16:41
@panvapanva removed the dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. label May 25, 2026
aduh95 pushed a commit that referenced this pull request May 27, 2026
@panva@aduh95
doc,lib: align WebCrypto names with spec
eeb77d2
Rename WebCrypto operation parameters and local variables to match the
spec terminology.
Use operation, algorithm, and key names consistently between the docs
and implementation.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63518
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 30, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@panva@aduh95
doc,lib: align WebCrypto names with spec
5d2dc84
Rename WebCrypto operation parameters and local variables to match the
spec terminology.
Use operation, algorithm, and key names consistently between the docs
and implementation.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63518
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@panva@aduh95
doc,lib: align WebCrypto names with spec
1a4edb3
Rename WebCrypto operation parameters and local variables to match the
spec terminology.
Use operation, algorithm, and key names consistently between the docs
and implementation.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63518
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@Renegade334Renegade334Renegade334 approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@panva@nodejs-github-bot@jasnell@lpinca@Renegade334@aduh95