Skip to content

debugger,test: deflake resume failure test and add debug logs - #63524

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:deflake-resume
May 26, 2026
Merged

debugger,test: deflake resume failure test and add debug logs#63524
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:deflake-resume

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented May 23, 2026

Copy link
Copy Markdown
Member

On slow CI, the outer Debugger.resume can be picked up in the same drain pass as the Debugger.evaluateOnCallFrame, while V8 still considers the context paused. In this case both resume calls may succeed and the process can continue running from the setInterval until the timeout. Accept both probe failure and timeout as valid to accommodate this flakiness.

This patch also adds more debug logs to the probe mode to show more information in case it flakes again in the CI

Fixes: #63505

@joyeecheung
debugger,test: deflake resume failure test and add debug logs
e9cb3fc
On slow CI, the outer Debugger.resume can be picked up in the
same drain pass as the Debugger.evaluateOnCallFrame, while V8
still considers the context paused. In this case both resume
calls may succeed and the process can continue running from
the setInterval until the timeout. Accept both probe failure
and timeout as valid to accommodate this flakiness.
This patch also adds more debug logs to the probe mode to
show more information in case it flakes again in the CI
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-botnodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels May 23, 2026
@joyeecheungjoyeecheung mentioned this pull request May 23, 2026
Closed
@nodejs-github-bot

nodejs-github-bot commented May 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73632/

@atlowChemiatlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2026
@codecov

codecovBot commented May 23, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.31%. Comparing base (c9562dd) to head (e9cb3fc).
⚠️ Report is 35 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/debugger/inspect_probe.js78.94%4 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63524 +/- ##
==========================================
+ Coverage 90.30% 90.31% +0.01% 
==========================================
Files 730 730 Lines 234188 234206 +18 Branches 43919 43912 -7 ==========================================
+ Hits 211478 211527 +49 + Misses 14443 14402 -41 - Partials 8267 8277 +10
Files with missing linesCoverage Δ
lib/internal/debugger/inspect_probe.js79.45% <78.94%> (-0.14%)⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung

joyeecheung commented May 23, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Stress test: https://ci.nodejs.org/job/node-stress-single-test/743/

@nodejs-github-bot

nodejs-github-bot commented May 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73724/

@joyeecheungjoyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 460c350 into nodejs:mainMay 26, 2026
82 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Landed in 460c350

aduh95 pushed a commit that referenced this pull request May 27, 2026
@joyeecheung@aduh95
debugger,test: deflake resume failure test and add debug logs
dbc78ff
On slow CI, the outer Debugger.resume can be picked up in the
same drain pass as the Debugger.evaluateOnCallFrame, while V8
still considers the context paused. In this case both resume
calls may succeed and the process can continue running from
the setInterval until the timeout. Accept both probe failure
and timeout as valid to accommodate this flakiness.
This patch also adds more debug logs to the probe mode to
show more information in case it flakes again in the CI
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63524Fixes: #63505
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 30, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 20, 2026
@joyeecheung@aduh95
debugger,test: deflake resume failure test and add debug logs
080410e
On slow CI, the outer Debugger.resume can be picked up in the
same drain pass as the Debugger.evaluateOnCallFrame, while V8
still considers the context paused. In this case both resume
calls may succeed and the process can continue running from
the setInterval until the timeout. Accept both probe failure
and timeout as valid to accommodate this flakiness.
This patch also adds more debug logs to the probe mode to
show more information in case it flakes again in the CI
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63524Fixes: #63505
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@joyeecheung@aduh95
debugger,test: deflake resume failure test and add debug logs
f6074a3
On slow CI, the outer Debugger.resume can be picked up in the
same drain pass as the Debugger.evaluateOnCallFrame, while V8
still considers the context paused. In this case both resume
calls may succeed and the process can continue running from
the setInterval until the timeout. Accept both probe failure
and timeout as valid to accommodate this flakiness.
This patch also adds more debug logs to the probe mode to
show more information in case it flakes again in the CI
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63524Fixes: #63505
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@joyeecheung@aduh95
debugger,test: deflake resume failure test and add debug logs
303524a
On slow CI, the outer Debugger.resume can be picked up in the
same drain pass as the Debugger.evaluateOnCallFrame, while V8
still considers the context paused. In this case both resume
calls may succeed and the process can continue running from
the setInterval until the timeout. Accept both probe failure
and timeout as valid to accommodate this flakiness.
This patch also adds more debug logs to the probe mode to
show more information in case it flakes again in the CI
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63524Fixes: #63505
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@joyeecheung@aduh95
debugger,test: deflake resume failure test and add debug logs
92a909c
On slow CI, the outer Debugger.resume can be picked up in the
same drain pass as the Debugger.evaluateOnCallFrame, while V8
still considers the context paused. In this case both resume
calls may succeed and the process can continue running from
the setInterval until the timeout. Accept both probe failure
and timeout as valid to accommodate this flakiness.
This patch also adds more debug logs to the probe mode to
show more information in case it flakes again in the CI
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63524Fixes: #63505
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
@gurgundaygurgundaygurgunday approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.debuggerIssues and PRs related to the debugger subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel/test-debugger-probe-failure-resume is flaky

5 participants

@joyeecheung@nodejs-github-bot@legendecas@atlowChemi@gurgunday