Skip to content

test_runner: fix suite diagnostic chanel end - #63533

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-suite-diagnostics-channel
May 26, 2026
Merged

test_runner: fix suite diagnostic chanel end#63533
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-suite-diagnostics-channel

Conversation

@MoLow

@MoLowMoLow commented May 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@MoLow
test_runner: fix suite diagnostic chanel end
467092d
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
@nodejs-github-bot

nodejs-github-bot commented May 24, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 24, 2026
@nodejs-github-bot

nodejs-github-bot commented May 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73658/

@codecov

codecovBot commented May 24, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (df09b2a) to head (467092d).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63533 +/- ##
=======================================
Coverage 90.32% 90.32% =======================================
Files 730 730 Lines 234152 234160 +8 Branches 43900 43904 +4 =======================================
+ Hits 211499 211507 +8 - Misses 14374 14379 +5 + Partials 8279 8274 -5
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.90% <100.00%> (+<0.01%)⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi
atlowChemi approved these changes May 24, 2026
View reviewed changes
Comment threadtest/parallel/test-runner-diagnostics-channel.js
@nodejs-github-bot

nodejs-github-bot commented May 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73673/

@MoLowMoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 25, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2026
@nodejs-github-bot
nodejs-github-bot merged commit cebe424 into nodejs:mainMay 26, 2026
82 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Landed in cebe424

aduh95 pushed a commit that referenced this pull request May 27, 2026
@MoLow@aduh95
test_runner: fix suite diagnostic chanel end
16015f1
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #63533
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 30, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 20, 2026
@MoLow@aduh95
test_runner: fix suite diagnostic chanel end
78c5fc9
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #63533
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@MoLow@aduh95
test_runner: fix suite diagnostic chanel end
3ae5f8c
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #63533
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@MoLow@aduh95
test_runner: fix suite diagnostic chanel end
ee32d40
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #63533
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@MoLow@aduh95
test_runner: fix suite diagnostic chanel end
68edc2b
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #63533
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atlowChemiatlowChemiatlowChemi approved these changes
@jasnelljasnelljasnell approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MoLow@nodejs-github-bot@jasnell@atlowChemi