Skip to content

test: deflake test-debugger-probe-timeout - #63547

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:probe-timeout-flake
May 27, 2026
Merged

test: deflake test-debugger-probe-timeout#63547
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:probe-timeout-flake

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented May 24, 2026•
edited
Loading

Copy link
Copy Markdown
Member

On slow machines in the CI, the 200ms timeout may fire before the probed process finishes evaluation. Increase the timeout to common.platformTimeout(1000) to accomondate.

Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-24.md

@joyeecheung
test: deflake test-debugger-probe-timeout
e5c3949
On slow machines in the CI, the 200ms timeout may fire before
the probed process finishes evaluation. Increase the timeout
to common.platformTimeout(1000) to accomondate.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 24, 2026
@nodejs-github-bot

nodejs-github-bot commented May 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73681/

@codecov

codecovBot commented May 24, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (fa0aadc) to head (e5c3949).
⚠️ Report is 55 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63547 +/- ##
==========================================
- Coverage 91.77% 90.33% -1.44% 
==========================================
Files 365 730 +365 Lines 158387 234161 +75774 Branches 24099 43916 +19817 ==========================================
+ Hits 145357 211526 +66169 - Misses 12757 14378 +1621 - Partials 273 8257 +7984

see 511 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr

trivikr commented May 25, 2026

Copy link
Copy Markdown
Member

The git merge conflict in debian12-x64 CI is reported in nodejs/build#4345

@nodejs-github-bot

nodejs-github-bot commented May 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73723/

@joyeecheungjoyeecheung added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 26, 2026
@nodejs-github-bot

nodejs-github-bot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73738/

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2026
@nodejs-github-bot

nodejs-github-bot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73760/

@nodejs-github-bot

nodejs-github-bot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73770/

@joyeecheungjoyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label May 27, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 27, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 221ffc0 into nodejs:mainMay 27, 2026
86 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Landed in 221ffc0

aduh95 pushed a commit that referenced this pull request May 27, 2026
@joyeecheung@aduh95
test: deflake test-debugger-probe-timeout
83cada8
On slow machines in the CI, the 200ms timeout may fire before
the probed process finishes evaluation. Increase the timeout
to common.platformTimeout(1000) to accomondate.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63547
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-24.md
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 30, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 20, 2026
@joyeecheung@aduh95
test: deflake test-debugger-probe-timeout
4ddde30
On slow machines in the CI, the 200ms timeout may fire before
the probed process finishes evaluation. Increase the timeout
to common.platformTimeout(1000) to accomondate.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63547
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-24.md
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@joyeecheung@aduh95
test: deflake test-debugger-probe-timeout
8aa5c84
On slow machines in the CI, the 200ms timeout may fire before
the probed process finishes evaluation. Increase the timeout
to common.platformTimeout(1000) to accomondate.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63547
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-24.md
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@joyeecheung@aduh95
test: deflake test-debugger-probe-timeout
dee23d8
On slow machines in the CI, the 200ms timeout may fire before
the probed process finishes evaluation. Increase the timeout
to common.platformTimeout(1000) to accomondate.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63547
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-24.md
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@joyeecheung@aduh95
test: deflake test-debugger-probe-timeout
89e23b7
On slow machines in the CI, the 200ms timeout may fire before
the probed process finishes evaluation. Increase the timeout
to common.platformTimeout(1000) to accomondate.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63547
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-24.md
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung@nodejs-github-bot@trivikr@jasnell@lpinca@juanarbol