Skip to content

build: build codecache and snapshot with libnode - #63626

Merged
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
legendecas:static-intermediate
Jun 2, 2026
Merged

build: build codecache and snapshot with libnode#63626
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
legendecas:static-intermediate

Conversation

@legendecas

@legendecaslegendecas commented May 28, 2026•
edited
Loading

Copy link
Copy Markdown
Member

This refactors the node and libnode targets, splitting the node_mksnapshot action from the node exe target, and adding a (always) static node_base target, allowing libnode to depend on node_mksnapshot exe, enabling the node startup snapshot when building with flag --shared.

The new dependency graph would be like:

node (executable)
└── libnode (static or shared)
├── node_base (static, whole-archived by `node` when not `--shared`)
│ ├── node_js2c#host
│ └── <all C++ sources + js2c generated source>
├── node_mksnapshot (executable, build-time)
│ └── node_base
└── node_snapshot.cc (generated by `node_mksnapshot`)
OR node_snapshot_stub.cc
cctest, fuzz_*, embedtest, etc.
└── libnode

@nodejs-github-bot

nodejs-github-bot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 28, 2026
@legendecas
legendecasforce-pushed the static-intermediate branch 2 times, most recently from adf769d to fac4309CompareMay 28, 2026 20:16
@legendecas
build: build codecache and snapshot with libnode
e880392
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
@legendecas
legendecasforce-pushed the static-intermediate branch from fac4309 to e880392CompareMay 28, 2026 20:17
joyeecheung
joyeecheung approved these changes May 28, 2026
View reviewed changes

@joyeecheungjoyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM if CI is happy!

Comment threadconfigure.py
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2026
@nodejs-github-bot

nodejs-github-bot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73820/

@nodejs-github-bot

nodejs-github-bot commented May 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73832/

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73871/

@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73873/

@legendecaslegendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 2, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 3d35dd8 into nodejs:mainJun 2, 2026
75 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Landed in 3d35dd8

@legendecas
legendecas deleted the static-intermediate branch June 2, 2026 15:03
@legendecaslegendecas mentioned this pull request Jun 4, 2026
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jun 12, 2026
@legendecas
build: remove redundant intermediate node_aix_shared
11390b5
With the introduction of always static target `node_base`,
`node_aix_shared` is now redundant.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63747
Refs: #63626
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@legendecas@aduh95
build: build codecache and snapshot with libnode
e510ee8
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63626
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@legendecas@aduh95
build: remove redundant intermediate node_aix_shared
1124c06
With the introduction of always static target `node_base`,
`node_aix_shared` is now redundant.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63747
Refs: #63626
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
@legendecaslegendecas added the lts-watch-v24.x PRs that may need to be released in v24.x label Jul 10, 2026
@aduh95aduh95 added the backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. label Jul 20, 2026
@aduh95

aduh95 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This doesn't land cleanly on v24.x-staging

@legendecaslegendecas mentioned this pull request Jul 20, 2026
Closed
@legendecaslegendecas added the backport-open-v24.x Indicate that the PR has an open backport label Jul 20, 2026
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@legendecas@aduh95
build: build codecache and snapshot with libnode
ef88b53
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63626
Backport-PR-URL: #64632
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@legendecas@aduh95
build: remove redundant intermediate node_aix_shared
f0b3a1c
With the introduction of always static target `node_base`,
`node_aix_shared` is now redundant.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63747
Backport-PR-URL: #64632
Refs: #63626
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95aduh95 mentioned this pull request Jul 21, 2026
Merged
@aduh95aduh95 removed the lts-watch-v24.x PRs that may need to be released in v24.x label Jul 21, 2026
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@legendecas@aduh95
build: build codecache and snapshot with libnode
7eac753
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63626
Backport-PR-URL: #64632
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@legendecas@aduh95
build: remove redundant intermediate node_aix_shared
d83cf48
With the introduction of always static target `node_base`,
`node_aix_shared` is now redundant.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63747
Backport-PR-URL: #64632
Refs: #63626
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@legendecas@aduh95
build: build codecache and snapshot with libnode
87e0675
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63626
Backport-PR-URL: #64632
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@legendecas@aduh95
build: remove redundant intermediate node_aix_shared
6e2f7e6
With the introduction of always static target `node_base`,
`node_aix_shared` is now redundant.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #63747
Backport-PR-URL: #64632
Refs: #63626
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Renegade334Renegade334 mentioned this pull request Aug 4, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes
@gurgundaygurgundaygurgunday approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backport-open-v24.xIndicate that the PR has an open backportbackport-requested-v24.xPRs awaiting manual backport to the v24.x-staging branch.buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas@nodejs-github-bot@aduh95@joyeecheung@gurgunday