Skip to content

crypto: deduplicate X509 subject matching logic - #63644

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:x509-dedup-subject-match
Jun 2, 2026
Merged

crypto: deduplicate X509 subject matching logic#63644
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:x509-dedup-subject-match

Conversation

@tniessen

@tniessentniessen commented May 29, 2026

Copy link
Copy Markdown
Member

CheckHost(), CheckEmail(), and CheckIP() all do very similar things. Extract the common logic into a helper function CheckX509Subject() to avoid duplication.

@nodejs-github-bot

nodejs-github-bot commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 29, 2026
@codecov

codecovBot commented May 29, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.33%. Comparing base (79def6d) to head (0f3664c).
⚠️ Report is 38 commits behind head on main.

Files with missing linesPatch %Lines
src/crypto/crypto_x509.cc88.00%0 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63644 +/- ##
=======================================
Coverage 90.32% 90.33% =======================================
Files 732 732 Lines 236435 236428 -7 Branches 44527 44520 -7 =======================================
+ Hits 213563 213577 +14 
Misses 14589 14589 + Partials 8283 8262 -21
Files with missing linesCoverage Δ
src/crypto/crypto_x509.cc73.63% <88.00%> (+1.18%)⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleaxaddaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 29, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2026
@nodejs-github-bot

nodejs-github-bot commented May 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73829/

@tniessen
crypto: deduplicate X509 subject matching logic
0f3664c
Signed-off-by: Tobias Nießen <tniessen@tnie.de>
@tniessen
tniessenforce-pushed the x509-dedup-subject-match branch from 2815b81 to 0f3664cCompareMay 30, 2026 15:03
@tniessentniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73856/

@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73869/

@tniessentniessen added the review wanted PRs that need reviews. label Jun 2, 2026
@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2026
@nodejs-github-bot
nodejs-github-bot merged commit a0423e2 into nodejs:mainJun 2, 2026
87 of 88 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Landed in a0423e2

aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@tniessen@aduh95
crypto: deduplicate X509 subject matching logic
5551e8f
Signed-off-by: Tobias Nießen <tniessen@tnie.de>
PR-URL: #63644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@tniessen@aduh95
crypto: deduplicate X509 subject matching logic
12986ba
Signed-off-by: Tobias Nießen <tniessen@tnie.de>
PR-URL: #63644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@tniessen@aduh95
crypto: deduplicate X509 subject matching logic
858496b
Signed-off-by: Tobias Nießen <tniessen@tnie.de>
PR-URL: #63644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.review wantedPRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tniessen@nodejs-github-bot@panva@addaleax