Skip to content

debugger: add more logs to probe mode - #63663

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:log-probe
Jun 1, 2026
Merged

debugger: add more logs to probe mode#63663
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:log-probe

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented May 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Add more log points in the probe mode and enable the debuglog int the probe mode tests, so we can have more information if they flake.

@joyeecheung
debugger: add more logs to probe mode
73f86c5
Add more log points in the probe mode and enable the debuglog
int the probe mode tests.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-botnodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels May 30, 2026
@joyeecheungjoyeecheung mentioned this pull request May 30, 2026
Closed
@codecov

codecovBot commented May 30, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (30a7e28) to head (73f86c5).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63663 +/- ##
==========================================
- Coverage 91.95% 90.33% -1.62% 
==========================================
Files 379 732 +353 Lines 166454 236462 +70008 Branches 25427 44535 +19108 ==========================================
+ Hits 153058 213617 +60559 - Misses 13104 14545 +1441 - Partials 292 8300 +8008
Files with missing linesCoverage Δ
lib/internal/debugger/inspect_probe.js79.71% <100.00%> (+0.36%)⬆️

... and 480 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73870/

@joyeecheungjoyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2026
@nodejs-github-bot
nodejs-github-bot merged commit f30139e into nodejs:mainJun 1, 2026
82 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Landed in f30139e

aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@joyeecheung@aduh95
debugger: add more logs to probe mode
238b54e
Add more log points in the probe mode and enable the debuglog
int the probe mode tests.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63663
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 20, 2026
@joyeecheung@aduh95
debugger: add more logs to probe mode
b7a83ac
Add more log points in the probe mode and enable the debuglog
int the probe mode tests.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63663
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@joyeecheung@aduh95
debugger: add more logs to probe mode
cb46741
Add more log points in the probe mode and enable the debuglog
int the probe mode tests.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63663
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@joyeecheung@aduh95
debugger: add more logs to probe mode
86d6e15
Add more log points in the probe mode and enable the debuglog
int the probe mode tests.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63663
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@joyeecheung@aduh95
debugger: add more logs to probe mode
9098585
Add more log points in the probe mode and enable the debuglog
int the probe mode tests.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63663
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes
@cola119cola119cola119 approved these changes

Assignees

No one assigned

Labels

debuggerIssues and PRs related to the debugger subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung@nodejs-github-bot@lpinca@trivikr@cola119