Skip to content

lib: add Iterator global to primordials, improve iteration object coverage in frozen intrinsics - #63698

Closed
Renegade334 wants to merge 4 commits into
nodejs:mainfrom
Renegade334:primordials-iterator-global
Closed

lib: add Iterator global to primordials, improve iteration object coverage in frozen intrinsics#63698
Renegade334 wants to merge 4 commits into
nodejs:mainfrom
Renegade334:primordials-iterator-global

Conversation

@Renegade334

@Renegade334Renegade334 commented Jun 1, 2026

Copy link
Copy Markdown
Member

lib: add Iterator global to primordials

iterator_helpers is unflagged in V8 from v24.x.

lib: improve control abstraction coverage in frozen intrinsics

Adds the new internal iteration prototypes (%IteratorHelperPrototype%, %WrapForValidIteratorPrototype%) to frozen intrinsics, and improves/deduplicates coverage of iterator/generator objects.

Note that %AsyncFromSyncIteratorPrototype% is missing from the iterator spec – this is unresolvable AFAICT.

@Renegade334
Renegade334 requested a review from ljharbJune 1, 2026 16:31
@Renegade334Renegade334 added lib / src Issues and PRs related to general changes in the lib or src directory. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jun 1, 2026
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. typings labels Jun 1, 2026
@Renegade334
Renegade334force-pushed the primordials-iterator-global branch 2 times, most recently from 51aa657 to 00e4207CompareJune 1, 2026 17:02
@bakkot

bakkot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Note that %AsyncFromSyncIteratorPrototype% is missing from the iterator spec – this is unresolvable AFAICT.

Indeed:

Async-from-Sync Iterator objects are never directly accessible to ECMAScript code.

It's a spec fiction used for defining behavior of other algorithms (for-await over a sync iterator, specifically), not a real thing (although engines might choose to have an internal representation of it for ease of implementation).

@codecov

codecovBot commented Jun 1, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.35%. Comparing base (39b481b) to head (00e4207).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63698 +/- ##
==========================================
- Coverage 91.96% 90.35% -1.61% 
==========================================
Files 379 732 +353 Lines 166638 236691 +70053 Branches 25497 44583 +19086 ==========================================
+ Hits 153242 213867 +60625 - Misses 13099 14563 +1464 - Partials 297 8261 +7964
Files with missing linesCoverage Δ
lib/internal/freeze_intrinsics.js97.05% <100.00%> (+0.08%)⬆️
lib/internal/per_context/primordials.js99.20% <100.00%> (+17.14%)⬆️

... and 476 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ljharb
ljharb reviewed Jun 2, 2026
View reviewed changes
Comment threadlib/internal/per_context/primordials.js
@Renegade334Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 2, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 2, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73900/

aduh95
aduh95 reviewed Jun 3, 2026
View reviewed changes
Comment threadlib/internal/per_context/primordials.js
@Renegade334
lib: add Iterator global to primordials
04ad7a7
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@Renegade334
lib: improve control abstraction coverage in frozen intrinsics
17d237b
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@Renegade334
Renegade334force-pushed the primordials-iterator-global branch from 00e4207 to 17d237bCompareJune 11, 2026 20:54
aduh95
aduh95 reviewed Jun 11, 2026
View reviewed changes
Comment threadlib/internal/freeze_intrinsics.js Outdated
aduh95
aduh95 approved these changes Jun 11, 2026
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMPrototype

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74066/

@Renegade334Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Landed in 96cff60...f2e3c10

nodejs-github-bot pushed a commit that referenced this pull request Jun 13, 2026
@Renegade334@nodejs-github-bot
lib: add Iterator global to primordials
be93790
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jun 13, 2026
@Renegade334@nodejs-github-bot
lib: improve control abstraction coverage in frozen intrinsics
f2e3c10
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Renegade334
Renegade334 deleted the primordials-iterator-global branch June 13, 2026 17:40
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@Renegade334@aduh95
lib: add Iterator global to primordials
0784578
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@Renegade334@aduh95
lib: improve control abstraction coverage in frozen intrinsics
7ee31b0
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@Renegade334@aduh95
lib: add Iterator global to primordials
1e33e80
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@Renegade334@aduh95
lib: improve control abstraction coverage in frozen intrinsics
24c8908
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@Renegade334@aduh95
lib: add Iterator global to primordials
7f4af55
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@Renegade334@aduh95
lib: improve control abstraction coverage in frozen intrinsics
823efe8
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Renegade334@bakkot@nodejs-github-bot@ljharb@aduh95