Skip to content

stream: check done before backpressure in stream reader - #63699

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
watilde:stream-read
Jun 9, 2026
Merged

stream: check done before backpressure in stream reader#63699
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
watilde:stream-read

Conversation

@watilde

@watildewatilde commented Jun 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@watilde
stream: check done before backpressure in stream reader
af45981
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Jun 1, 2026
@codecov

codecovBot commented Jun 1, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (39b481b) to head (af45981).
⚠️ Report is 68 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/streams/compose.js66.66%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #63699 +/- ##
==========================================
- Coverage 91.96% 90.35% -1.61% 
==========================================
Files 379 732 +353 Lines 166638 236668 +70030 Branches 25497 44580 +19083 ==========================================
+ Hits 153242 213835 +60593 - Misses 13099 14566 +1467 - Partials 297 8267 +7970
Files with missing linesCoverage Δ
lib/internal/streams/compose.js95.47% <66.66%> (-1.24%)⬇️

... and 479 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes Jun 7, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73950/

@trivikrtrivikr added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 9, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5498337 into nodejs:mainJun 9, 2026
86 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Landed in 5498337

@watilde
watilde deleted the stream-read branch June 16, 2026 07:07
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@watilde@aduh95
stream: check done before backpressure in stream reader
10272a9
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #63699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@watilde@aduh95
stream: check done before backpressure in stream reader
97590e8
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #63699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@watilde@aduh95
stream: check done before backpressure in stream reader
915e3e2
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #63699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@watilde@nodejs-github-bot@mcollina@trivikr