Skip to content

module: use file: URL as sourceURL for type-stripped CommonJS - #63705

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:source-url
Jun 4, 2026
Merged

module: use file: URL as sourceURL for type-stripped CommonJS#63705
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:source-url

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Jun 1, 2026

Copy link
Copy Markdown
Member

The CommonJS loader was passing the bare filesystem path as the //# sourceURL comment of type-stripped TypeScript, this leads to two problems:

  1. It reports hasSourceURL = false if the path contains any whitespaces as this breaks V8's magic comment parser.
  2. The inspector would incorrectly report a file path verbatim as the script's URL.

Pass the module's file: URL as the sourceURL so the reported URL is consistent across loaders and won't lead to an issue in inspector clients that actually except a real URL for the scripts.

@joyeecheung
module: use file: URL as sourceURL for type-stripped CommonJS
756d141
The CommonJS loader was passing the bare filesystem path as the
`//# sourceURL` comment of type-stripped TypeScript, this leads to
two problems:
1. It reports hasSourceURL = false if the path contains any
whitespaces as this breaks V8's magic comment parser.
2. The inspector would incorrectly report a file path verbatim as
the script's URL.
Pass the module's file: URL as the sourceURL so the reported URL
is consistent across loaders and won't lead to an issue in
inspector clients that actually except a real URL for the
scripts.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jun 1, 2026
@codecov

codecovBot commented Jun 1, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (f30139e) to head (756d141).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63705 +/- ##
==========================================
- Coverage 90.35% 90.33% -0.03% 
==========================================
Files 732 732 Lines 236684 236686 +2 Branches 44579 44593 +14 ==========================================
- Hits 213855 213809 -46 - Misses 14544 14592 +48 
Partials 8285 8285
Files with missing linesCoverage Δ
lib/internal/modules/cjs/loader.js98.05% <100.00%> (+<0.01%)⬆️
lib/internal/modules/typescript.js90.69% <100.00%> (+0.04%)⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

marco-ippolito
marco-ippolito reviewed Jun 2, 2026
View reviewed changes
Comment threadlib/internal/modules/cjs/loader.js
mcollina
mcollina approved these changes Jun 2, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 2, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 2, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73891/

@joyeecheungjoyeecheung added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 2, 2026
@joyeecheungjoyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 4219808 into nodejs:mainJun 4, 2026
100 of 102 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Landed in 4219808

@joyeecheungjoyeecheung mentioned this pull request Jun 4, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@joyeecheung@aduh95
module: use file: URL as sourceURL for type-stripped CommonJS
4becad2
The CommonJS loader was passing the bare filesystem path as the
`//# sourceURL` comment of type-stripped TypeScript, this leads to
two problems:
1. It reports hasSourceURL = false if the path contains any
whitespaces as this breaks V8's magic comment parser.
2. The inspector would incorrectly report a file path verbatim as
the script's URL.
Pass the module's file: URL as the sourceURL so the reported URL
is consistent across loaders and won't lead to an issue in
inspector clients that actually except a real URL for the
scripts.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63705
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@joyeecheung@aduh95
module: use file: URL as sourceURL for type-stripped CommonJS
98ce551
The CommonJS loader was passing the bare filesystem path as the
`//# sourceURL` comment of type-stripped TypeScript, this leads to
two problems:
1. It reports hasSourceURL = false if the path contains any
whitespaces as this breaks V8's magic comment parser.
2. The inspector would incorrectly report a file path verbatim as
the script's URL.
Pass the module's file: URL as the sourceURL so the reported URL
is consistent across loaders and won't lead to an issue in
inspector clients that actually except a real URL for the
scripts.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63705
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@joyeecheung@aduh95
module: use file: URL as sourceURL for type-stripped CommonJS
fb2ccb1
The CommonJS loader was passing the bare filesystem path as the
`//# sourceURL` comment of type-stripped TypeScript, this leads to
two problems:
1. It reports hasSourceURL = false if the path contains any
whitespaces as this breaks V8's magic comment parser.
2. The inspector would incorrectly report a file path verbatim as
the script's URL.
Pass the module's file: URL as the sourceURL so the reported URL
is consistent across loaders and won't lead to an issue in
inspector clients that actually except a real URL for the
scripts.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63705
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@legendecaslegendecaslegendecas approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
+1 more reviewer
@jsumners-nrjsumners-nrjsumners-nr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.moduleIssues and PRs related to the module subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung@nodejs-github-bot@mcollina@legendecas@marco-ippolito@jsumners-nr