Uh oh!
There was an error while loading. Please reload this page.
test: mark SEA tests flaky on linux arm debug - #63743
Merged
Merged
Conversation
nodejs-github-bot
commented
Jun 4, 2026
Collaborator
Review requested:
|
Uh oh!
There was an error while loading. Please reload this page.
The LIEF-based --build-sea tests can be killed by the OS on the linux arm debug CI worker while rebuilding the ELF binary. The failures all happen after SEA serialization succeeds, when the injector enters LIEF::ELF::Builder::build(), and report SIGKILL instead of a test assertion failure. Mark the affected SEA build and application test families as flaky only on linux arm debug, matching the node-test-commit-arm-debug job where the flakes have been observed. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
joyeecheung
approved these changes
Jun 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
watilde
approved these changes
Jun 10, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
joyeecheung
approved these changes
Jun 10, 2026
nodejs-github-bot
commented
Jun 10, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63743 ✔ Done loading data for nodejs/node/pull/63743 ----------------------------------- PR info ------------------------------------ Title test: mark SEA tests flaky on linux arm debug (#63743) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch trivikr:test-build-sea -> nodejs:main Labels test, flaky-test, author ready, needs-ci Commits 2 - test: mark SEA tests flaky on linux arm debug - Update test/sea/sea.status Committers 2 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/63743 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-10.md Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63743 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-10.md Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 04 Jun 2026 05:22:05 GMT ✔ Approvals: 3 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/63743#pullrequestreview-4467917972 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63743#pullrequestreview-4452693490 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/63743#pullrequestreview-4464290426 ✘ GitHub CI failed with status: FAILURE ℹ Last Full PR CI on 2026-06-10T10:49:11Z: https://ci.nodejs.org/job/node-test-pull-request/74031/ - Querying data for job/node-test-pull-request/74031/ ✔ Build data downloaded - Querying failures of job/node-test-commit/88580/ ✔ Data downloaded ✘ 1 failure(s) on the last Jenkins CI run -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/27279706663 |
aymen94
approved these changes
Jun 10, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
commented
Jun 10, 2026
MemberAuthor
CI failures are unrelated to this change. Report at nodejs/build#4362 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jun 11, 2026
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 11, 2026
Collaborator
Landed in 141a504 |
aduh95 pushed a commit
that referenced
this pull request
Jun 18, 2026
The LIEF-based --build-sea tests can be killed by the OS on the linux arm debug CI worker while rebuilding the ELF binary. The failures all happen after SEA serialization succeeds, when the injector enters LIEF::ELF::Builder::build(), and report SIGKILL instead of a test assertion failure. Mark the affected SEA build and application test families as flaky only on linux arm debug, matching the node-test-commit-arm-debug job where the flakes have been observed. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #63743 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-10.md Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jun 25, 2026
The LIEF-based --build-sea tests can be killed by the OS on the linux arm debug CI worker while rebuilding the ELF binary. The failures all happen after SEA serialization succeeds, when the injector enters LIEF::ELF::Builder::build(), and report SIGKILL instead of a test assertion failure. Mark the affected SEA build and application test families as flaky only on linux arm debug, matching the node-test-commit-arm-debug job where the flakes have been observed. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #63743 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-10.md Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
The LIEF-based --build-sea tests can be killed by the OS on the linux arm debug CI worker while rebuilding the ELF binary. The failures all happen after SEA serialization succeeds, when the injector enters LIEF::ELF::Builder::build(), and report SIGKILL instead of a test assertion failure. Mark the affected SEA build and application test families as flaky only on linux arm debug, matching the node-test-commit-arm-debug job where the flakes have been observed. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #63743 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-10.md Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LIEF-based --build-sea tests can be killed by the OS on the
linux arm debug CI worker while rebuilding the ELF binary. The failures
all happen after SEA serialization succeeds, when the injector enters
LIEF::ELF::Builder::build(), and report SIGKILL instead of a test
assertion failure.
Mark the affected SEA build and application test families as flaky only
on linux arm debug, matching the node-test-commit-arm-debug job
where the flakes have been observed.
Refs: