Skip to content

http2: retain header memory in session accounting - #63752

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:http2-harden-session-memory-headers
Jun 8, 2026
Merged

http2: retain header memory in session accounting#63752
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:http2-harden-session-memory-headers

Conversation

@mcollina

@mcollinamcollina commented Jun 5, 2026

Copy link
Copy Markdown
Member

Fix header memory accounting for stalled HTTP/2 streams and add regression coverage.

@nodejs-github-bot

nodejs-github-bot commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jun 5, 2026
@mcollina
mcollinaforce-pushed the http2-harden-session-memory-headers branch from 270bebd to ef92a0dCompareJune 5, 2026 06:51
pimterry
pimterry approved these changes Jun 5, 2026
View reviewed changes

@pimterrypimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, very nice 👍

@pimterrypimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2026
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 5, 2026
@github-actions

github-actionsBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Starting PR CI job
✔ PR CI job successfully started

[DEBUG] [Error: GraphQL request Error: We couldn't respond to your request in time. Sorry about that. Please try resubmitting your request and contact us if the problem persists.] {

data: { variables: { prid: 63752, owner: 'nodejs', repo: 'node' } }

}

✘ Failed to start CI
https://github.com/nodejs/node/actions/runs/27008000368

@nodejs-github-bot

nodejs-github-bot commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73918/

@nodejs-github-bot

nodejs-github-bot commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73921/

lpinca
lpinca reviewed Jun 5, 2026
View reviewed changes
Comment threadtest/parallel/test-http2-max-session-memory-stalled-headers.js Outdated
@mcollina
http2: retain header memory in session accounting
9d98283
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollinaforce-pushed the http2-harden-session-memory-headers branch from ef92a0d to 9d98283CompareJune 6, 2026 20:17
@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jun 7, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73936/

@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73938/

@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73937/

@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73960/

@pimterrypimterry added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2026
@nodejs-github-bot
nodejs-github-bot merged commit ba82a41 into nodejs:mainJun 8, 2026
71 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Landed in ba82a41

@github-actionsgithub-actionsBot mentioned this pull request Jun 8, 2026
Open
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@mcollina@aduh95
http2: retain header memory in session accounting
b7fd13a
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #63752
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@mcollina@aduh95
http2: retain header memory in session accounting
a764d89
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #63752
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@mcollinamcollina added lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Jul 7, 2026
@mcollina
mcollina deleted the http2-harden-session-memory-headers branch July 7, 2026 08:19
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 19, 2026
@mcollina@juanarbol
http2: retain header memory in session accounting
26f3d8c
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs#63752
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@juanarboljuanarbol removed the lts-watch-v22.x PRs that may need to be released in v22.x label Jul 19, 2026
juanarbol pushed a commit that referenced this pull request Jul 19, 2026
@mcollina@juanarbol
http2: retain header memory in session accounting
a6b3a35
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #63752
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
@aduh95aduh95 removed the lts-watch-v24.x PRs that may need to be released in v24.x label Jul 21, 2026
juanarbol pushed a commit that referenced this pull request Jul 29, 2026
@mcollina@RafaelGSS
http2: retain header memory in session accounting
34ed88a
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #63752
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
CVE-ID: CVE-2026-56846
ash2228 pushed a commit to ash2228/node that referenced this pull request Jul 29, 2026
@mcollina@RafaelGSS
http2: retain header memory in session accounting
f14d78b
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs#63752
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
CVE-ID: CVE-2026-56846
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca left review comments
@pimterrypimterrypimterry approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@gurgundaygurgundaygurgunday approved these changes
+1 more reviewer
@metcoder95metcoder95metcoder95 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.http2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mcollina@nodejs-github-bot@lpinca@pimterry@metcoder95@RafaelGSS@gurgunday@aduh95@juanarbol