Skip to content

test: validate ERR_INVALID_THIS for scheduler methods - #63764

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
watilde:test-timer
Jun 9, 2026
Merged

test: validate ERR_INVALID_THIS for scheduler methods#63764
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
watilde:test-timer

Conversation

@watilde

Copy link
Copy Markdown
Member

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 6, 2026
@trivikrtrivikr added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 9, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@watildewatilde added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 1be7464 into nodejs:mainJun 9, 2026
84 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 1be7464

aduh95 pushed a commit that referenced this pull request Jun 18, 2026
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #63764
Refs: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Ftimers%2Fpromises.js
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #63764
Refs: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Ftimers%2Fpromises.js
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #63764
Refs: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Ftimers%2Fpromises.js
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@watilde@nodejs-github-bot@lpinca@atlowChemi@trivikr