sqlite: validate maxSize argument in createTagStore() by Anshikakalpana · Pull Request #63792 · nodejs/node

Anshikakalpana · 2026-06-08T11:11:12Z

database.createTagStore() accepted invalid values for its maxSize argument without throwing. Negative integers caused integer overflow, NaN and floats produced garbage capacity values, and strings were silently ignored.

The maxSize parameter is documented as {integer} and represents a cache size, so negative values are meaningless.

This PR adds validation to reject:

Non-integer values (NaN, floats, strings) with ERR_INVALID_ARG_TYPE
Negative integers with ERR_OUT_OF_RANGE

Edit: non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE.

nodejs-github-bot · 2026-06-08T11:11:17Z

Review requested:

@nodejs/sqlite

aduh95 · 2026-06-08T12:39:22Z

+ code: 'ERR_INVALID_ARG_TYPE',
+ message: /maxSize/,
+ });
+
+ assert.throws(() => db.createTagStore(1.5), {
+ code: 'ERR_INVALID_ARG_TYPE',


This should likely be ERR_OUT_OF_RANGE, like e.g. node -e 'child_process.spawn("/dev/null", { uid: 1.3 })' does

Fixed — floats now throw ERR_OUT_OF_RANGE instead of ERR_INVALID_ARG_TYPE.

@Anshikakalpana Can you update the PR description to include this change?
The non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE

Anshikakalpana · 2026-08-04T15:56:47Z

Hi @aduh95! I addressed all the review comments and updated the PR. Could you please take another look when you have a chance? Thanks!

codecov · 2026-08-07T14:24:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8fc7341) to head (6371aa2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63792 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02% 
==========================================
Files 759 759 Lines 248288 248302 +14 Branches 46857 46858 +1 ==========================================
- Hits 224247 224223 -24 - Misses 15471 15514 +43 + Partials 8570 8565 -5

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.13% <100.00%> (+0.08%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

nodejs-github-bot · 2026-08-08T12:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75643/

nodejs-github-bot · 2026-08-08T15:54:56Z

Landed in 98fd6cb

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63792Fixes: #63791 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Anshikakalpana · 2026-06-08T11:11:12Z

Fixes: #63791

database.createTagStore() accepted invalid values for its maxSize argument without throwing. Negative integers caused integer overflow, NaN and floats produced garbage capacity values, and strings were silently ignored.

The maxSize parameter is documented as {integer} and represents a cache size, so negative values are meaningless.

This PR adds validation to reject:

Non-integer values (NaN, floats, strings) with ERR_INVALID_ARG_TYPE
Negative integers with ERR_OUT_OF_RANGE

Edit: non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE.

nodejs-github-bot · 2026-06-08T11:11:17Z

Review requested:

@nodejs/sqlite

aduh95 · 2026-06-08T12:39:22Z

+ code: 'ERR_INVALID_ARG_TYPE',
+ message: /maxSize/,
+ });
+
+ assert.throws(() => db.createTagStore(1.5), {
+ code: 'ERR_INVALID_ARG_TYPE',


This should likely be ERR_OUT_OF_RANGE, like e.g. node -e 'child_process.spawn("/dev/null", { uid: 1.3 })' does

Fixed — floats now throw ERR_OUT_OF_RANGE instead of ERR_INVALID_ARG_TYPE.

@Anshikakalpana Can you update the PR description to include this change?
The non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE

Anshikakalpana · 2026-08-04T15:56:47Z

Hi @aduh95! I addressed all the review comments and updated the PR. Could you please take another look when you have a chance? Thanks!

codecov · 2026-08-07T14:24:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8fc7341) to head (6371aa2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63792 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02% 
==========================================
Files 759 759 Lines 248288 248302 +14 Branches 46857 46858 +1 ==========================================
- Hits 224247 224223 -24 - Misses 15471 15514 +43 + Partials 8570 8565 -5

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.13% <100.00%> (+0.08%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

nodejs-github-bot · 2026-08-08T12:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75643/

nodejs-github-bot · 2026-08-08T15:54:56Z

Landed in 98fd6cb

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63792Fixes: #63791 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Anshikakalpana · 2026-06-08T11:11:12Z

Fixes: #63791

database.createTagStore() accepted invalid values for its maxSize argument without throwing. Negative integers caused integer overflow, NaN and floats produced garbage capacity values, and strings were silently ignored.

The maxSize parameter is documented as {integer} and represents a cache size, so negative values are meaningless.

This PR adds validation to reject:

Non-integer values (NaN, floats, strings) with ERR_INVALID_ARG_TYPE
Negative integers with ERR_OUT_OF_RANGE

Edit: non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE.

nodejs-github-bot · 2026-06-08T11:11:17Z

Review requested:

@nodejs/sqlite

aduh95 · 2026-06-08T12:39:22Z

+ code: 'ERR_INVALID_ARG_TYPE',
+ message: /maxSize/,
+ });
+
+ assert.throws(() => db.createTagStore(1.5), {
+ code: 'ERR_INVALID_ARG_TYPE',


This should likely be ERR_OUT_OF_RANGE, like e.g. node -e 'child_process.spawn("/dev/null", { uid: 1.3 })' does

Fixed — floats now throw ERR_OUT_OF_RANGE instead of ERR_INVALID_ARG_TYPE.

@Anshikakalpana Can you update the PR description to include this change?
The non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE

Anshikakalpana · 2026-08-04T15:56:47Z

Hi @aduh95! I addressed all the review comments and updated the PR. Could you please take another look when you have a chance? Thanks!

codecov · 2026-08-07T14:24:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8fc7341) to head (6371aa2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63792 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02% 
==========================================
Files 759 759 Lines 248288 248302 +14 Branches 46857 46858 +1 ==========================================
- Hits 224247 224223 -24 - Misses 15471 15514 +43 + Partials 8570 8565 -5

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.13% <100.00%> (+0.08%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

nodejs-github-bot · 2026-08-08T12:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75643/

nodejs-github-bot · 2026-08-08T15:54:56Z

Landed in 98fd6cb

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63792Fixes: #63791 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Anshikakalpana · 2026-06-08T11:11:12Z

Fixes: #63791

database.createTagStore() accepted invalid values for its maxSize argument without throwing. Negative integers caused integer overflow, NaN and floats produced garbage capacity values, and strings were silently ignored.

The maxSize parameter is documented as {integer} and represents a cache size, so negative values are meaningless.

This PR adds validation to reject:

Non-integer values (NaN, floats, strings) with ERR_INVALID_ARG_TYPE
Negative integers with ERR_OUT_OF_RANGE

Edit: non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE.

nodejs-github-bot · 2026-06-08T11:11:17Z

Review requested:

@nodejs/sqlite

aduh95 · 2026-06-08T12:39:22Z

+ code: 'ERR_INVALID_ARG_TYPE',
+ message: /maxSize/,
+ });
+
+ assert.throws(() => db.createTagStore(1.5), {
+ code: 'ERR_INVALID_ARG_TYPE',


This should likely be ERR_OUT_OF_RANGE, like e.g. node -e 'child_process.spawn("/dev/null", { uid: 1.3 })' does

Fixed — floats now throw ERR_OUT_OF_RANGE instead of ERR_INVALID_ARG_TYPE.

@Anshikakalpana Can you update the PR description to include this change?
The non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE

Anshikakalpana · 2026-08-04T15:56:47Z

Hi @aduh95! I addressed all the review comments and updated the PR. Could you please take another look when you have a chance? Thanks!

codecov · 2026-08-07T14:24:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8fc7341) to head (6371aa2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63792 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02% 
==========================================
Files 759 759 Lines 248288 248302 +14 Branches 46857 46858 +1 ==========================================
- Hits 224247 224223 -24 - Misses 15471 15514 +43 + Partials 8570 8565 -5

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.13% <100.00%> (+0.08%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

nodejs-github-bot · 2026-08-08T12:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75643/

nodejs-github-bot · 2026-08-08T15:54:56Z

Landed in 98fd6cb

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63792Fixes: #63791 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Anshikakalpana · 2026-06-08T11:11:12Z

Fixes: #63791

database.createTagStore() accepted invalid values for its maxSize argument without throwing. Negative integers caused integer overflow, NaN and floats produced garbage capacity values, and strings were silently ignored.

The maxSize parameter is documented as {integer} and represents a cache size, so negative values are meaningless.

This PR adds validation to reject:

Non-integer values (NaN, floats, strings) with ERR_INVALID_ARG_TYPE
Negative integers with ERR_OUT_OF_RANGE

Edit: non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE.

nodejs-github-bot · 2026-06-08T11:11:17Z

Review requested:

@nodejs/sqlite

aduh95 · 2026-06-08T12:39:22Z

+ code: 'ERR_INVALID_ARG_TYPE',
+ message: /maxSize/,
+ });
+
+ assert.throws(() => db.createTagStore(1.5), {
+ code: 'ERR_INVALID_ARG_TYPE',


This should likely be ERR_OUT_OF_RANGE, like e.g. node -e 'child_process.spawn("/dev/null", { uid: 1.3 })' does

Fixed — floats now throw ERR_OUT_OF_RANGE instead of ERR_INVALID_ARG_TYPE.

@Anshikakalpana Can you update the PR description to include this change?
The non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE

Anshikakalpana · 2026-08-04T15:56:47Z

Hi @aduh95! I addressed all the review comments and updated the PR. Could you please take another look when you have a chance? Thanks!

codecov · 2026-08-07T14:24:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8fc7341) to head (6371aa2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63792 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02% 
==========================================
Files 759 759 Lines 248288 248302 +14 Branches 46857 46858 +1 ==========================================
- Hits 224247 224223 -24 - Misses 15471 15514 +43 + Partials 8570 8565 -5

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.13% <100.00%> (+0.08%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

nodejs-github-bot · 2026-08-08T12:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75643/

nodejs-github-bot · 2026-08-08T15:54:56Z

Landed in 98fd6cb

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63792Fixes: #63791 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Anshikakalpana · 2026-06-08T11:11:12Z

Fixes: #63791

database.createTagStore() accepted invalid values for its maxSize argument without throwing. Negative integers caused integer overflow, NaN and floats produced garbage capacity values, and strings were silently ignored.

The maxSize parameter is documented as {integer} and represents a cache size, so negative values are meaningless.

This PR adds validation to reject:

Non-integer values (NaN, floats, strings) with ERR_INVALID_ARG_TYPE
Negative integers with ERR_OUT_OF_RANGE

Edit: non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE.

nodejs-github-bot · 2026-06-08T11:11:17Z

Review requested:

@nodejs/sqlite

aduh95 · 2026-06-08T12:39:22Z

+ code: 'ERR_INVALID_ARG_TYPE',
+ message: /maxSize/,
+ });
+
+ assert.throws(() => db.createTagStore(1.5), {
+ code: 'ERR_INVALID_ARG_TYPE',


This should likely be ERR_OUT_OF_RANGE, like e.g. node -e 'child_process.spawn("/dev/null", { uid: 1.3 })' does

Fixed — floats now throw ERR_OUT_OF_RANGE instead of ERR_INVALID_ARG_TYPE.

@Anshikakalpana Can you update the PR description to include this change?
The non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE

Anshikakalpana · 2026-08-04T15:56:47Z

Hi @aduh95! I addressed all the review comments and updated the PR. Could you please take another look when you have a chance? Thanks!

codecov · 2026-08-07T14:24:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8fc7341) to head (6371aa2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63792 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02% 
==========================================
Files 759 759 Lines 248288 248302 +14 Branches 46857 46858 +1 ==========================================
- Hits 224247 224223 -24 - Misses 15471 15514 +43 + Partials 8570 8565 -5

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.13% <100.00%> (+0.08%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

nodejs-github-bot · 2026-08-08T12:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75643/

nodejs-github-bot · 2026-08-08T15:54:56Z

Landed in 98fd6cb

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63792Fixes: #63791 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Anshikakalpana · 2026-06-08T11:11:12Z

Fixes: #63791

database.createTagStore() accepted invalid values for its maxSize argument without throwing. Negative integers caused integer overflow, NaN and floats produced garbage capacity values, and strings were silently ignored.

The maxSize parameter is documented as {integer} and represents a cache size, so negative values are meaningless.

This PR adds validation to reject:

Non-integer values (NaN, floats, strings) with ERR_INVALID_ARG_TYPE
Negative integers with ERR_OUT_OF_RANGE

Edit: non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE.

nodejs-github-bot · 2026-06-08T11:11:17Z

Review requested:

@nodejs/sqlite

aduh95 · 2026-06-08T12:39:22Z

+ code: 'ERR_INVALID_ARG_TYPE',
+ message: /maxSize/,
+ });
+
+ assert.throws(() => db.createTagStore(1.5), {
+ code: 'ERR_INVALID_ARG_TYPE',


This should likely be ERR_OUT_OF_RANGE, like e.g. node -e 'child_process.spawn("/dev/null", { uid: 1.3 })' does

Fixed — floats now throw ERR_OUT_OF_RANGE instead of ERR_INVALID_ARG_TYPE.

@Anshikakalpana Can you update the PR description to include this change?
The non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE

Anshikakalpana · 2026-08-04T15:56:47Z

Hi @aduh95! I addressed all the review comments and updated the PR. Could you please take another look when you have a chance? Thanks!

codecov · 2026-08-07T14:24:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8fc7341) to head (6371aa2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63792 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02% 
==========================================
Files 759 759 Lines 248288 248302 +14 Branches 46857 46858 +1 ==========================================
- Hits 224247 224223 -24 - Misses 15471 15514 +43 + Partials 8570 8565 -5

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.13% <100.00%> (+0.08%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

nodejs-github-bot · 2026-08-08T12:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75643/

nodejs-github-bot · 2026-08-08T15:54:56Z

Landed in 98fd6cb

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63792Fixes: #63791 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Anshikakalpana · 2026-06-08T11:11:12Z

Fixes: #63791

database.createTagStore() accepted invalid values for its maxSize argument without throwing. Negative integers caused integer overflow, NaN and floats produced garbage capacity values, and strings were silently ignored.

The maxSize parameter is documented as {integer} and represents a cache size, so negative values are meaningless.

This PR adds validation to reject:

Non-integer values (NaN, floats, strings) with ERR_INVALID_ARG_TYPE
Negative integers with ERR_OUT_OF_RANGE

Edit: non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE.

nodejs-github-bot · 2026-06-08T11:11:17Z

Review requested:

@nodejs/sqlite

aduh95 · 2026-06-08T12:39:22Z

+ code: 'ERR_INVALID_ARG_TYPE',
+ message: /maxSize/,
+ });
+
+ assert.throws(() => db.createTagStore(1.5), {
+ code: 'ERR_INVALID_ARG_TYPE',


This should likely be ERR_OUT_OF_RANGE, like e.g. node -e 'child_process.spawn("/dev/null", { uid: 1.3 })' does

Fixed — floats now throw ERR_OUT_OF_RANGE instead of ERR_INVALID_ARG_TYPE.

@Anshikakalpana Can you update the PR description to include this change?
The non-integer values (NaN, floats, strings) no longer throw ERR_INVALID_ARG_TYPE

Anshikakalpana · 2026-08-04T15:56:47Z

Hi @aduh95! I addressed all the review comments and updated the PR. Could you please take another look when you have a chance? Thanks!

codecov · 2026-08-07T14:24:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8fc7341) to head (6371aa2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63792 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02% 
==========================================
Files 759 759 Lines 248288 248302 +14 Branches 46857 46858 +1 ==========================================
- Hits 224247 224223 -24 - Misses 15471 15514 +43 + Partials 8570 8565 -5

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.13% <100.00%> (+0.08%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

nodejs-github-bot · 2026-08-08T12:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75643/

nodejs-github-bot · 2026-08-08T15:54:56Z

Landed in 98fd6cb

Signed-off-by: anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63792Fixes: #63791 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jun 8, 2026

Anshikakalpana force-pushed the fix/sqlite-createTagStore-maxSize-validation branch from 68d5139 to 3c0477bCompare June 8, 2026 11:23

aduh95 reviewed Jun 8, 2026
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated

aduh95 reviewed Jun 8, 2026
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated

aduh95 reviewed Jun 8, 2026
View reviewed changes

Anshikakalpana force-pushed the fix/sqlite-createTagStore-maxSize-validation branch from 3c0477b to 406e215Compare June 9, 2026 07:32

This comment was marked as outdated.
Sign in to view

Anshikakalpana force-pushed the fix/sqlite-createTagStore-maxSize-validation branch from 406e215 to b81b873Compare August 7, 2026 12:47

trivikr requested a review from aduh95 August 7, 2026 14:55

trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2026

trivikr approved these changes Aug 7, 2026
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated

trivikr removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2026

Anshikakalpana force-pushed the fix/sqlite-createTagStore-maxSize-validation branch from b81b873 to de6789bCompare August 7, 2026 20:12

sqlite: validate maxSize argument in createTagStore()
6371aa2
Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>

Anshikakalpana force-pushed the fix/sqlite-createTagStore-maxSize-validation branch from de6789b to 6371aa2Compare August 7, 2026 20:21

trivikr approved these changes Aug 7, 2026
View reviewed changes

trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2026

This comment was marked as outdated.
Sign in to view

trivikr removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2026

jasnell approved these changes Aug 8, 2026
View reviewed changes

jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 8, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 8, 2026

nodejs-github-bot merged commit 98fd6cb into nodejs:mainAug 8, 2026
89 of 91 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged