Uh oh!
There was an error while loading. Please reload this page.
test_runner: remove unused shuffleArrayWithSeed - #63847
Merged
Merged
Conversation
shuffleArrayWithSeed was introduced along with test order randomization but was never called: the feature picks a random pending subtest at dequeue time using createSeededGenerator directly. Remove the dead helper and its export, and add direct unit coverage for createSeededGenerator's deterministic contract. Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
nodejs-github-bot
commented
Jun 11, 2026
Collaborator
Review requested:
|
atlowChemi
approved these changes
Jun 11, 2026
JakobJingleheimer
approved these changes
Jun 11, 2026
nodejs-github-bot
commented
Jun 11, 2026
Collaborator
lpinca
approved these changes
Jun 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 13, 2026
Collaborator
Landed in b3042c7 |
aduh95 pushed a commit
that referenced
this pull request
Jun 18, 2026
shuffleArrayWithSeed was introduced along with test order randomization but was never called: the feature picks a random pending subtest at dequeue time using createSeededGenerator directly. Remove the dead helper and its export, and add direct unit coverage for createSeededGenerator's deterministic contract. Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: #63847 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jun 25, 2026
shuffleArrayWithSeed was introduced along with test order randomization but was never called: the feature picks a random pending subtest at dequeue time using createSeededGenerator directly. Remove the dead helper and its export, and add direct unit coverage for createSeededGenerator's deterministic contract. Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: #63847 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
shuffleArrayWithSeed was introduced along with test order randomization but was never called: the feature picks a random pending subtest at dequeue time using createSeededGenerator directly. Remove the dead helper and its export, and add direct unit coverage for createSeededGenerator's deterministic contract. Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: #63847 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shuffleArrayWithSeed was introduced along with test order randomization but was never called: the feature picks a random pending subtest at dequeue time using createSeededGenerator directly. Remove the dead helper and its export, and add direct unit coverage for createSeededGenerator's deterministic contract.