doc: add eljefedelrodeodeljefe to collaborators

[eljefedelrodeodeljefe]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

adds me to the readme.md as collaborator

[ChALkeR]

LGTM, welcome!

[evanlucas]

LGTM. Welcome aboard

[santigimeno]

LGTM and welcome!

[eljefedelrodeodeljefe]

CI: https://ci.nodejs.org/job/node-test-pull-request/2395/

Gonna merge this after CI :) Thanks guys

[eljefedelrodeodeljefe]

Landed in be5d699

[eljefedelrodeodeljefe]

With the process in the collaborators guide the PRs won't be marked as merged on GitHub right? Guess it doesn't matter too much.

[Trott]

@eljefedelrodeodeljefe That's right. @evanlucas told me and others how to make it so that it shows as merged but I don't remember what it was.

[ChALkeR]

@eljefedelrodeodeljefe@Trott
Trivial — just make sure your branch is rebased on master and push the final commits with all the modifications (including the PR-URL, Reviewed-By, etc) to your branch before landing it to master.

GitHub will label the PR as merged when it sees that all the commits with identical ids are landed on the target branch.

[eljefedelrodeodeljefe]

Will try that next time then. Thought I did all that. Thanks

[jbergstroem]

@ChALkeR we should really add that to the collaborators guide -- it makes it easier to make the assumption that the last commit(s) in the PR was also the one's merged.

[jbergstroem]

@eljefedelrodeodeljefe you have to force push to your branch since you're rewriting history (git push -f)

[ChALkeR]

@eljefedelrodeodeljefe The branch had 3f3f41a, the merged commit was be5d699. Those were not identical =).

Update: sorry, copy-pasted wrong commit id. Fixed.

[eljefedelrodeodeljefe]

Yep, after @jbergstroem comments I was realizing that. After adding metadata it needs another force push to the fork.