Uh oh!
There was an error while loading. Please reload this page.
repl: handle dot commands syntax error for multiline inputs - #63911
repl: handle dot commands syntax error for multiline inputs#63911SudhansuBandha wants to merge 4 commits into
Conversation
9279b81 to
8141b1dCompare30d239b to
738694bCompare
avinashkamat48
left a comment
There was a problem hiding this comment.
This can treat ordinary JavaScript property access as a REPL dot command whenever the property name matches a command. For example, obj .help is valid JS member access with whitespace before the dot, but isDotCommandAfterWhitespace plus the regex will extract help and run the REPL help command instead of evaluating the expression. The multiline case should likely only recognize a dot command when the dot begins a logical input line after optional indentation. Please add a regression test for obj .help / obj .break staying as JavaScript.
13934b2 to
fa811ffCompareUpdate conditional logic to correctly handle dot commands in multiline REPL input Fixes: nodejs#63864 Refs: nodejs#63889 Signed-off-by: SudhansuBandha <bandhasudhansu@gmail.com>
39afff7 to
13c45b3CompareSudhansuBandha
commented
Jun 22, 2026
@avinashkamat48 thanks for pointing it out. I have updated the logic to handle these kind of unexpected behaviours |
@mcollina@BridgeAR@puskin@Renegade334 whenever you have a moment please have a look at this PR and it's proposed changes. |
avivkeller
left a comment
There was a problem hiding this comment.
Why do we need this? I feel like dot-commands must be the start of their command, else a SyntaxError is valid
SudhansuBandha
commented
Jul 29, 2026
@avivkeller if these changes are not required then I believe I can close this PR |
Fixes: #63864
Refs: #63889
Update conditional logic to correctly handle dot commands in multiline REPL input