Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 36.7k
Split HTTP/3 module out from QUIC#63995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
b9cffb335691fa92f5d2c0efd303dd4893955450be58eae6b33e84b7ec1dc6e9d175ef4882960File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need separate connect and listen variants for http3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, no.
Those two APIs create a auto-H3 client/server with sensible H3 defaults that automatically wires up the h3 application. It's roughly the equivalent to the current auto-HTTP3 support. But with this PR you can now use
new Http3Session(quicSession)to dynamically create an HTTP/3 session on top of QUIC instead, so a separate server/client API is no longer necessary.It is mildly more fiddly this way: you have to manually create the H3 session every time, and we wouldn't offer a way to set up any HTTP/3 specific defaults (e.g. ALPN) for you. Given we now intend this only for low-level use cases that's fine though, it gives you more control en route anyway.
There is one practical limitation right now: you can't do server 0RTT with dynamic attach like this (because by the time
sessionevent fires on the server to attach, that's been partially processed already). That is fixable I think, it's just a separate step I was going to leave until later. I could investigate that further within this PR instead though, and then if there's a good solution then we could drop these with no practical downside.