fs: add `maxDepth` option to `glob` by TheAlexLichter · Pull Request #64003 · nodejs/node

TheAlexLichter · 2026-06-19T14:31:20Z

This PR adds a maxDepth option to fs.glob(), fs.globSync(), and fs.promises.glob().

Motivation

Broad glob patterns such as ** currently traverse the complete matching directory tree. Results can be filtered further afterwards but that does not avoid the associated filesystem work for use cases that only need "nearby entries".
This is particularly costly for large directory trees or mounted filesystems.

Similar functionality is already available in existing 3rd party packages like tinyglobby in various ways.

Implementation

Depth is measured relative to cwd:

cwd has depth 0
Direct children have depth 1
Grandchildren have depth 2
And so on

The default is Infinity (compatible with existing default behavior). A finite limit applies to both returned matches and filesystem traversal, allowing subtrees to be skipped.

Relative patterns cannot bypass the limit using .., and paths outside cwd, including paths on another Windows volume, are outside any finite depth.

Absolute patterns can traverse ancestors as needed to reach cwd, but matches outside cwd are excluded when the limit is finite.

nodejs-github-bot · 2026-06-19T14:31:25Z

Review requested:

@nodejs/performance

mcollina

lgtm

TheAlexLichter · 2026-06-22T07:30:05Z

(Added the "Signed off" trailer)

Signed-off-by: Alexander Lichter <github@lichter.io>

trivikr · 2026-08-24T18:18:33Z

@TheAlexLichter The lint errors need to be fixed

/home/runner/work/node/node/test/parallel/test-fs-glob.mjsError: 20:1 error 'node:child_process' import is duplicated no-duplicate-imports

codecov · 2026-08-24T19:35:55Z

Codecov Report

❌ Patch coverage is 80.87855% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e6a8d06) to head (9322fe5).
⚠️ Report is 980 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/glob.js	80.87%	72 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64003 +/- ##
==========================================
- Coverage 92.01% 90.12% -1.90% 
==========================================
Files 379 751 +372 Lines 166972 253997 +87025 Branches 25554 47895 +22341 ==========================================
+ Hits 153639 228914 +75275 - Misses 13041 16341 +3300 - Partials 292 8742 +8450

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`89.27% <80.87%> (+1.14%)`	⬆️

... and 604 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheAlexLichter · 2026-08-25T19:18:13Z

@trivikr just resolved them 👍🏻

nodejs-github-bot · 2026-08-26T05:27:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76501/

nodejs-github-bot · 2026-08-26T14:07:52Z

Landed in a00cf06

Signed-off-by: Alexander Lichter <github@lichter.io> PR-URL: #64003 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

TheAlexLichter · 2026-06-19T14:31:20Z

This PR adds a maxDepth option to fs.glob(), fs.globSync(), and fs.promises.glob().

Motivation

Broad glob patterns such as ** currently traverse the complete matching directory tree. Results can be filtered further afterwards but that does not avoid the associated filesystem work for use cases that only need "nearby entries".
This is particularly costly for large directory trees or mounted filesystems.

Similar functionality is already available in existing 3rd party packages like tinyglobby in various ways.

Implementation

Depth is measured relative to cwd:

cwd has depth 0
Direct children have depth 1
Grandchildren have depth 2
And so on

The default is Infinity (compatible with existing default behavior). A finite limit applies to both returned matches and filesystem traversal, allowing subtrees to be skipped.

Relative patterns cannot bypass the limit using .., and paths outside cwd, including paths on another Windows volume, are outside any finite depth.

Absolute patterns can traverse ancestors as needed to reach cwd, but matches outside cwd are excluded when the limit is finite.

nodejs-github-bot · 2026-06-19T14:31:25Z

Review requested:

@nodejs/performance

mcollina

lgtm

TheAlexLichter · 2026-06-22T07:30:05Z

(Added the "Signed off" trailer)

Signed-off-by: Alexander Lichter <github@lichter.io>

trivikr · 2026-08-24T18:18:33Z

@TheAlexLichter The lint errors need to be fixed

/home/runner/work/node/node/test/parallel/test-fs-glob.mjsError: 20:1 error 'node:child_process' import is duplicated no-duplicate-imports

codecov · 2026-08-24T19:35:55Z

Codecov Report

❌ Patch coverage is 80.87855% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e6a8d06) to head (9322fe5).
⚠️ Report is 980 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/glob.js	80.87%	72 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64003 +/- ##
==========================================
- Coverage 92.01% 90.12% -1.90% 
==========================================
Files 379 751 +372 Lines 166972 253997 +87025 Branches 25554 47895 +22341 ==========================================
+ Hits 153639 228914 +75275 - Misses 13041 16341 +3300 - Partials 292 8742 +8450

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`89.27% <80.87%> (+1.14%)`	⬆️

... and 604 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheAlexLichter · 2026-08-25T19:18:13Z

@trivikr just resolved them 👍🏻

nodejs-github-bot · 2026-08-26T05:27:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76501/

nodejs-github-bot · 2026-08-26T14:07:52Z

Landed in a00cf06

Signed-off-by: Alexander Lichter <github@lichter.io> PR-URL: #64003 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

TheAlexLichter · 2026-06-19T14:31:20Z

This PR adds a maxDepth option to fs.glob(), fs.globSync(), and fs.promises.glob().

Motivation

Broad glob patterns such as ** currently traverse the complete matching directory tree. Results can be filtered further afterwards but that does not avoid the associated filesystem work for use cases that only need "nearby entries".
This is particularly costly for large directory trees or mounted filesystems.

Similar functionality is already available in existing 3rd party packages like tinyglobby in various ways.

Implementation

Depth is measured relative to cwd:

cwd has depth 0
Direct children have depth 1
Grandchildren have depth 2
And so on

The default is Infinity (compatible with existing default behavior). A finite limit applies to both returned matches and filesystem traversal, allowing subtrees to be skipped.

Relative patterns cannot bypass the limit using .., and paths outside cwd, including paths on another Windows volume, are outside any finite depth.

Absolute patterns can traverse ancestors as needed to reach cwd, but matches outside cwd are excluded when the limit is finite.

nodejs-github-bot · 2026-06-19T14:31:25Z

Review requested:

@nodejs/performance

mcollina

lgtm

TheAlexLichter · 2026-06-22T07:30:05Z

(Added the "Signed off" trailer)

Signed-off-by: Alexander Lichter <github@lichter.io>

trivikr · 2026-08-24T18:18:33Z

@TheAlexLichter The lint errors need to be fixed

/home/runner/work/node/node/test/parallel/test-fs-glob.mjsError: 20:1 error 'node:child_process' import is duplicated no-duplicate-imports

codecov · 2026-08-24T19:35:55Z

Codecov Report

❌ Patch coverage is 80.87855% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e6a8d06) to head (9322fe5).
⚠️ Report is 980 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/glob.js	80.87%	72 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64003 +/- ##
==========================================
- Coverage 92.01% 90.12% -1.90% 
==========================================
Files 379 751 +372 Lines 166972 253997 +87025 Branches 25554 47895 +22341 ==========================================
+ Hits 153639 228914 +75275 - Misses 13041 16341 +3300 - Partials 292 8742 +8450

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`89.27% <80.87%> (+1.14%)`	⬆️

... and 604 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheAlexLichter · 2026-08-25T19:18:13Z

@trivikr just resolved them 👍🏻

nodejs-github-bot · 2026-08-26T05:27:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76501/

nodejs-github-bot · 2026-08-26T14:07:52Z

Landed in a00cf06

Signed-off-by: Alexander Lichter <github@lichter.io> PR-URL: #64003 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

TheAlexLichter · 2026-06-19T14:31:20Z

This PR adds a maxDepth option to fs.glob(), fs.globSync(), and fs.promises.glob().

Motivation

Broad glob patterns such as ** currently traverse the complete matching directory tree. Results can be filtered further afterwards but that does not avoid the associated filesystem work for use cases that only need "nearby entries".
This is particularly costly for large directory trees or mounted filesystems.

Similar functionality is already available in existing 3rd party packages like tinyglobby in various ways.

Implementation

Depth is measured relative to cwd:

cwd has depth 0
Direct children have depth 1
Grandchildren have depth 2
And so on

The default is Infinity (compatible with existing default behavior). A finite limit applies to both returned matches and filesystem traversal, allowing subtrees to be skipped.

Relative patterns cannot bypass the limit using .., and paths outside cwd, including paths on another Windows volume, are outside any finite depth.

Absolute patterns can traverse ancestors as needed to reach cwd, but matches outside cwd are excluded when the limit is finite.

nodejs-github-bot · 2026-06-19T14:31:25Z

Review requested:

@nodejs/performance

mcollina

lgtm

TheAlexLichter · 2026-06-22T07:30:05Z

(Added the "Signed off" trailer)

Signed-off-by: Alexander Lichter <github@lichter.io>

trivikr · 2026-08-24T18:18:33Z

@TheAlexLichter The lint errors need to be fixed

/home/runner/work/node/node/test/parallel/test-fs-glob.mjsError: 20:1 error 'node:child_process' import is duplicated no-duplicate-imports

codecov · 2026-08-24T19:35:55Z

Codecov Report

❌ Patch coverage is 80.87855% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e6a8d06) to head (9322fe5).
⚠️ Report is 980 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/glob.js	80.87%	72 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64003 +/- ##
==========================================
- Coverage 92.01% 90.12% -1.90% 
==========================================
Files 379 751 +372 Lines 166972 253997 +87025 Branches 25554 47895 +22341 ==========================================
+ Hits 153639 228914 +75275 - Misses 13041 16341 +3300 - Partials 292 8742 +8450

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`89.27% <80.87%> (+1.14%)`	⬆️

... and 604 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheAlexLichter · 2026-08-25T19:18:13Z

@trivikr just resolved them 👍🏻

nodejs-github-bot · 2026-08-26T05:27:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76501/

nodejs-github-bot · 2026-08-26T14:07:52Z

Landed in a00cf06

Signed-off-by: Alexander Lichter <github@lichter.io> PR-URL: #64003 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

TheAlexLichter · 2026-06-19T14:31:20Z

This PR adds a maxDepth option to fs.glob(), fs.globSync(), and fs.promises.glob().

Motivation

Broad glob patterns such as ** currently traverse the complete matching directory tree. Results can be filtered further afterwards but that does not avoid the associated filesystem work for use cases that only need "nearby entries".
This is particularly costly for large directory trees or mounted filesystems.

Similar functionality is already available in existing 3rd party packages like tinyglobby in various ways.

Implementation

Depth is measured relative to cwd:

cwd has depth 0
Direct children have depth 1
Grandchildren have depth 2
And so on

The default is Infinity (compatible with existing default behavior). A finite limit applies to both returned matches and filesystem traversal, allowing subtrees to be skipped.

Relative patterns cannot bypass the limit using .., and paths outside cwd, including paths on another Windows volume, are outside any finite depth.

Absolute patterns can traverse ancestors as needed to reach cwd, but matches outside cwd are excluded when the limit is finite.

nodejs-github-bot · 2026-06-19T14:31:25Z

Review requested:

@nodejs/performance

mcollina

lgtm

TheAlexLichter · 2026-06-22T07:30:05Z

(Added the "Signed off" trailer)

Signed-off-by: Alexander Lichter <github@lichter.io>

trivikr · 2026-08-24T18:18:33Z

@TheAlexLichter The lint errors need to be fixed

/home/runner/work/node/node/test/parallel/test-fs-glob.mjsError: 20:1 error 'node:child_process' import is duplicated no-duplicate-imports

codecov · 2026-08-24T19:35:55Z

Codecov Report

❌ Patch coverage is 80.87855% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e6a8d06) to head (9322fe5).
⚠️ Report is 980 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/glob.js	80.87%	72 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64003 +/- ##
==========================================
- Coverage 92.01% 90.12% -1.90% 
==========================================
Files 379 751 +372 Lines 166972 253997 +87025 Branches 25554 47895 +22341 ==========================================
+ Hits 153639 228914 +75275 - Misses 13041 16341 +3300 - Partials 292 8742 +8450

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`89.27% <80.87%> (+1.14%)`	⬆️

... and 604 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheAlexLichter · 2026-08-25T19:18:13Z

@trivikr just resolved them 👍🏻

nodejs-github-bot · 2026-08-26T05:27:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76501/

nodejs-github-bot · 2026-08-26T14:07:52Z

Landed in a00cf06

Signed-off-by: Alexander Lichter <github@lichter.io> PR-URL: #64003 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

TheAlexLichter · 2026-06-19T14:31:20Z

This PR adds a maxDepth option to fs.glob(), fs.globSync(), and fs.promises.glob().

Motivation

Broad glob patterns such as ** currently traverse the complete matching directory tree. Results can be filtered further afterwards but that does not avoid the associated filesystem work for use cases that only need "nearby entries".
This is particularly costly for large directory trees or mounted filesystems.

Similar functionality is already available in existing 3rd party packages like tinyglobby in various ways.

Implementation

Depth is measured relative to cwd:

cwd has depth 0
Direct children have depth 1
Grandchildren have depth 2
And so on

The default is Infinity (compatible with existing default behavior). A finite limit applies to both returned matches and filesystem traversal, allowing subtrees to be skipped.

Relative patterns cannot bypass the limit using .., and paths outside cwd, including paths on another Windows volume, are outside any finite depth.

Absolute patterns can traverse ancestors as needed to reach cwd, but matches outside cwd are excluded when the limit is finite.

nodejs-github-bot · 2026-06-19T14:31:25Z

Review requested:

@nodejs/performance

mcollina

lgtm

TheAlexLichter · 2026-06-22T07:30:05Z

(Added the "Signed off" trailer)

Signed-off-by: Alexander Lichter <github@lichter.io>

trivikr · 2026-08-24T18:18:33Z

@TheAlexLichter The lint errors need to be fixed

/home/runner/work/node/node/test/parallel/test-fs-glob.mjsError: 20:1 error 'node:child_process' import is duplicated no-duplicate-imports

codecov · 2026-08-24T19:35:55Z

Codecov Report

❌ Patch coverage is 80.87855% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e6a8d06) to head (9322fe5).
⚠️ Report is 980 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/glob.js	80.87%	72 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64003 +/- ##
==========================================
- Coverage 92.01% 90.12% -1.90% 
==========================================
Files 379 751 +372 Lines 166972 253997 +87025 Branches 25554 47895 +22341 ==========================================
+ Hits 153639 228914 +75275 - Misses 13041 16341 +3300 - Partials 292 8742 +8450

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`89.27% <80.87%> (+1.14%)`	⬆️

... and 604 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheAlexLichter · 2026-08-25T19:18:13Z

@trivikr just resolved them 👍🏻

nodejs-github-bot · 2026-08-26T05:27:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76501/

nodejs-github-bot · 2026-08-26T14:07:52Z

Landed in a00cf06

Signed-off-by: Alexander Lichter <github@lichter.io> PR-URL: #64003 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

TheAlexLichter · 2026-06-19T14:31:20Z

This PR adds a maxDepth option to fs.glob(), fs.globSync(), and fs.promises.glob().

Motivation

Broad glob patterns such as ** currently traverse the complete matching directory tree. Results can be filtered further afterwards but that does not avoid the associated filesystem work for use cases that only need "nearby entries".
This is particularly costly for large directory trees or mounted filesystems.

Similar functionality is already available in existing 3rd party packages like tinyglobby in various ways.

Implementation

Depth is measured relative to cwd:

cwd has depth 0
Direct children have depth 1
Grandchildren have depth 2
And so on

The default is Infinity (compatible with existing default behavior). A finite limit applies to both returned matches and filesystem traversal, allowing subtrees to be skipped.

Relative patterns cannot bypass the limit using .., and paths outside cwd, including paths on another Windows volume, are outside any finite depth.

Absolute patterns can traverse ancestors as needed to reach cwd, but matches outside cwd are excluded when the limit is finite.

nodejs-github-bot · 2026-06-19T14:31:25Z

Review requested:

@nodejs/performance

mcollina

lgtm

TheAlexLichter · 2026-06-22T07:30:05Z

(Added the "Signed off" trailer)

Signed-off-by: Alexander Lichter <github@lichter.io>

trivikr · 2026-08-24T18:18:33Z

@TheAlexLichter The lint errors need to be fixed

/home/runner/work/node/node/test/parallel/test-fs-glob.mjsError: 20:1 error 'node:child_process' import is duplicated no-duplicate-imports

codecov · 2026-08-24T19:35:55Z

Codecov Report

❌ Patch coverage is 80.87855% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e6a8d06) to head (9322fe5).
⚠️ Report is 980 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/glob.js	80.87%	72 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64003 +/- ##
==========================================
- Coverage 92.01% 90.12% -1.90% 
==========================================
Files 379 751 +372 Lines 166972 253997 +87025 Branches 25554 47895 +22341 ==========================================
+ Hits 153639 228914 +75275 - Misses 13041 16341 +3300 - Partials 292 8742 +8450

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`89.27% <80.87%> (+1.14%)`	⬆️

... and 604 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheAlexLichter · 2026-08-25T19:18:13Z

@trivikr just resolved them 👍🏻

nodejs-github-bot · 2026-08-26T05:27:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76501/

nodejs-github-bot · 2026-08-26T14:07:52Z

Landed in a00cf06

Signed-off-by: Alexander Lichter <github@lichter.io> PR-URL: #64003 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

TheAlexLichter · 2026-06-19T14:31:20Z

This PR adds a maxDepth option to fs.glob(), fs.globSync(), and fs.promises.glob().

Motivation

Broad glob patterns such as ** currently traverse the complete matching directory tree. Results can be filtered further afterwards but that does not avoid the associated filesystem work for use cases that only need "nearby entries".
This is particularly costly for large directory trees or mounted filesystems.

Similar functionality is already available in existing 3rd party packages like tinyglobby in various ways.

Implementation

Depth is measured relative to cwd:

cwd has depth 0
Direct children have depth 1
Grandchildren have depth 2
And so on

The default is Infinity (compatible with existing default behavior). A finite limit applies to both returned matches and filesystem traversal, allowing subtrees to be skipped.

Relative patterns cannot bypass the limit using .., and paths outside cwd, including paths on another Windows volume, are outside any finite depth.

Absolute patterns can traverse ancestors as needed to reach cwd, but matches outside cwd are excluded when the limit is finite.

nodejs-github-bot · 2026-06-19T14:31:25Z

Review requested:

@nodejs/performance

mcollina

lgtm

TheAlexLichter · 2026-06-22T07:30:05Z

(Added the "Signed off" trailer)

Signed-off-by: Alexander Lichter <github@lichter.io>

trivikr · 2026-08-24T18:18:33Z

@TheAlexLichter The lint errors need to be fixed

/home/runner/work/node/node/test/parallel/test-fs-glob.mjsError: 20:1 error 'node:child_process' import is duplicated no-duplicate-imports

codecov · 2026-08-24T19:35:55Z

Codecov Report

❌ Patch coverage is 80.87855% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e6a8d06) to head (9322fe5).
⚠️ Report is 980 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/glob.js	80.87%	72 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64003 +/- ##
==========================================
- Coverage 92.01% 90.12% -1.90% 
==========================================
Files 379 751 +372 Lines 166972 253997 +87025 Branches 25554 47895 +22341 ==========================================
+ Hits 153639 228914 +75275 - Misses 13041 16341 +3300 - Partials 292 8742 +8450

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`89.27% <80.87%> (+1.14%)`	⬆️

... and 604 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheAlexLichter · 2026-08-25T19:18:13Z

@trivikr just resolved them 👍🏻

nodejs-github-bot · 2026-08-26T05:27:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76501/

nodejs-github-bot · 2026-08-26T14:07:52Z

Landed in a00cf06

Signed-off-by: Alexander Lichter <github@lichter.io> PR-URL: #64003 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Jun 19, 2026

mcollina approved these changes Jun 22, 2026
View reviewed changes

TheAlexLichter force-pushed the fs-glob-max-depth branch from 2972d97 to 020bdf2Compare June 22, 2026 07:29

trivikr requested changes Aug 23, 2026
View reviewed changes

Comment threaddoc/api/fs.md

fs: add maxDepth option to glob
e9f17df
Signed-off-by: Alexander Lichter <github@lichter.io>

TheAlexLichter force-pushed the fs-glob-max-depth branch from 020bdf2 to e9f17dfCompare August 24, 2026 14:46

trivikr approved these changes Aug 24, 2026
View reviewed changes

trivikr added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 24, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2026

This comment was marked as outdated.
Sign in to view

trivikr removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 24, 2026

MoLow approved these changes Aug 25, 2026
View reviewed changes

test: use spawnSync in glob tests
9322fe5

trivikr approved these changes Aug 25, 2026
View reviewed changes

trivikr added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 25, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2026

This comment was marked as outdated.
Sign in to view

trivikr added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 26, 2026

nodejs-github-bot merged commit a00cf06 into nodejs:mainAug 26, 2026
89 of 90 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 26, 2026

greenheadHQ mentioned this pull request Aug 27, 2026
test: use common spawnSync helpers in more tests #65552
Merged