Skip to content

test: mark test-debugger-run-after-quit-restart as flaky on macOS - #64006

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:mark-debugger-run-after-quit-restart-flaky-macos
Jun 20, 2026
Merged

test: mark test-debugger-run-after-quit-restart as flaky on macOS#64006
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:mark-debugger-run-after-quit-restart-flaky-macos

Conversation

@mcollina

@mcollinamcollina commented Jun 19, 2026•
edited by aduh95
Loading

Copy link
Copy Markdown
Member

This test has been observed to be flaky on macOS CI due to slow inspector round-trips, causing a 15s timeout when waiting for the initial break after restart.

Refs: #64005

@mcollina
mcollina requested a review from aduh95June 19, 2026 15:52
@mcollinamcollina added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2026
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 19, 2026
@github-actions

github-actionsBot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.

@lpinca

lpinca commented Jun 19, 2026

Copy link
Copy Markdown
Member

@inoway46 has been working on flaky debbugger tests and might have some ideas.

@inoway46

inoway46 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Thanks for the mention. I left a hypothesis-based comment on the issue: #64005 (comment)

Since the root cause is not fully clear yet, marking this as flaky for now sounds good to me.

@mcollina
test: mark test-debugger-run-after-quit-restart as flaky on macOS
644625b
Refs: nodejs#64005
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollinaforce-pushed the mark-debugger-run-after-quit-restart-flaky-macos branch from 1734747 to 644625bCompareJune 20, 2026 10:00
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 20, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74299/

@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74306/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit c105c73 into nodejs:mainJun 20, 2026
72 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Landed in c105c73

aduh95 pushed a commit that referenced this pull request Jun 20, 2026
@mcollina@aduh95
test: mark test-debugger-run-after-quit-restart as flaky on macOS
ea63005
Refs: #64005
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64006
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@mcollina@aduh95
test: mark test-debugger-run-after-quit-restart as flaky on macOS
5c5dc77
Refs: #64005
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64006
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@mcollina@aduh95
test: mark test-debugger-run-after-quit-restart as flaky on macOS
d2dc033
Refs: #64005
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64006
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@mcollina@aduh95
test: mark test-debugger-run-after-quit-restart as flaky on macOS
6660c75
Refs: #64005
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64006
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@mcollina@aduh95
test: mark test-debugger-run-after-quit-restart as flaky on macOS
b636f47
Refs: #64005
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64006
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@aduh95aduh95aduh95 approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mcollina@lpinca@inoway46@nodejs-github-bot@panva@aduh95@trivikr