deps: update libffi to 3.6.0 by nodejs-github-bot · Pull Request #64040 · nodejs/node

nodejs-github-bot · 2026-06-21T01:26:14Z

This is an automated update of libffi to 3.6.0.

nodejs-github-bot · 2026-06-21T01:26:20Z

Review requested:

@nodejs/ffi
@nodejs/security-wg

nodejs-github-bot · 2026-06-21T09:23:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74321/

github-actions · 2026-06-21T09:30:40Z

Fast-track has been requested by @aduh95. Please 👍 to approve.

aduh95 · 2026-06-21T09:31:06Z

Let's fast-track to include it in the next 26.x release, which I'd like to be able to prepare today

aduh95 · 2026-06-21T10:01:54Z

Related compilation failure on AIX and Windows

../deps/libffi/src/powerpc/ffi_darwin.c:1456:14: error: use of undeclared identifier 'PPC_LD_NONE'
1456 | return PPC_LD_NONE;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1458:14: error: use of undeclared identifier 'PPC_LD_F32'
1458 | return PPC_LD_F32;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1460:14: error: use of undeclared identifier 'PPC_LD_F64'
1460 | return PPC_LD_F64;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1463:14: error: use of undeclared identifier 'PPC_LD_F128'
1463 | return PPC_LD_F128;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1466:14: error: use of undeclared identifier 'PPC_LD_U8'
1466 | return PPC_LD_U8;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1468:14: error: use of undeclared identifier 'PPC_LD_S8'
1468 | return PPC_LD_S8;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1470:14: error: use of undeclared identifier 'PPC_LD_U16'
1470 | return PPC_LD_U16;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1472:14: error: use of undeclared identifier 'PPC_LD_S16'
1472 | return PPC_LD_S16;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1474:14: error: use of undeclared identifier 'PPC_LD_U32'
1474 | return PPC_LD_U32;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1477:14: error: use of undeclared identifier 'PPC_LD_S32'
1477 | return PPC_LD_S32;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1479:14: error: use of undeclared identifier 'PPC_LD_PTR'
1479 | return PPC_LD_PTR;
| ^
../deps/libffi/src/powerpc/ffi_darwin.c:1482:14: error: use of undeclared identifier 'PPC_LD_I64'
1482 | return PPC_LD_I64;
| ^
2 warnings and 12 errors generated.

nodejs-github-bot · 2026-06-21T15:47:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74334/

aduh95 · 2026-06-21T18:07:31Z

@nodejs/platform-aix any idea on how to fix the compilation?

richardlau · 2026-06-21T18:13:10Z

@nodejs/platform-aix any idea on how to fix the compilation?

Why are we compiling ../deps/libffi/src/powerpc/ffi_darwin.c on AIX in the first place?

node/deps/libffi/libffi.gyp

Lines 118 to 126 in 2e19033

 ['target_arch == "ppc64" and OS == "aix"', { 
'variables': { 
'libffi_arch_sources': [ 
'src/powerpc/ffi_darwin.c', 
'src/powerpc/aix.S', 
'src/powerpc/aix_closure.S', 
 ], 
 }, 
 }], 

Renegade334 · 2026-06-21T18:20:27Z

Why are we compiling ../deps/libffi/src/powerpc/ffi_darwin.c on AIX in the first place?

This appears to be how libffi plays it.

As for the missing defines, these were added to ffi_powerpc.h in this update, but there's clearly something janky going on with the includes. ffi_darwin.c is missing this header, whereas ffi.c/ffi_linux64.c/ffi_sysv.c include it.

https://github.com/nodejs/node/blob/d393b3267c82384e37dcf88836b6d48fc97132be/deps/libffi/src/powerpc/ffi_powerpc.h#L35-L94

aduh95 · 2026-06-21T19:12:14Z

CI: https://ci.nodejs.org/job/node-test-commit-aix/63336/

Renegade334 · 2026-06-21T19:39:22Z

ffi.c uses the linux64/sysv asm symbols, not the aix symbols, hence (presumably) the linker error. ffi_darwin.c is explicitly the correct source here:

node/deps/libffi/src/powerpc/ffi_darwin.c

Line 8 in d658f44

FFI support for Darwin and AIX.

Renegade334 · 2026-06-21T19:45:10Z

Let's give this a go.

https://ci.nodejs.org/job/node-test-commit-aix/63337/

Edit: guess not then 😆

Renegade334 · 2026-06-21T20:11:05Z

I get the sense that this is just busted at source.

The function in ffi_darwin.c that returns these constants still expects to return a ffi_type*, which is consistent with the cif->rtype that was previously returned prior to libffi/libffi@840add3. The respective functions in linux64/sysv have been updated to return an int, which matches the new constants.

I note that libffi only tests powerpc64 builds targeting linux, not darwin or aix.

Renegade334 · 2026-06-21T20:43:43Z

Opened libffi/libffi#987. We have a suggested patch to try, going to give it a go!

https://ci.nodejs.org/job/node-test-commit-aix/63338/

aduh95 · 2026-06-21T21:28:25Z

432321bbc0249d754be701208747e4dfab83e32b Would need to be a deps: libffi: cherry-pick …, not a fixup commit

Renegade334 · 2026-06-21T21:31:14Z

👍

Once we confirm the build is green, then it can be landed upstream and we can formally cherry-pick.

nodejs-github-bot · 2026-06-21T23:00:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74339/

PR-URL: #64040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

Original commit message: powerpc: fix aix/darwin closure build errors unbuildable: the PPC_LD_* jump-table indexes (defined in ffi_powerpc.h, which this file cannot include) were missing, and the closure helper functions still declared an ffi_type* return type inconsistent with the PPC_LD_* constants they now return. Define the PPC_LD_* constants locally and change the closure helper return types to int. Fixes#987 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Refs: libffi/libffi@9ca53a1 PR-URL: #64040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 · 2026-06-22T06:57:05Z

Landed in 1f806f2...e9a9065

PR-URL: #64040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

Original commit message: powerpc: fix aix/darwin closure build errors unbuildable: the PPC_LD_* jump-table indexes (defined in ffi_powerpc.h, which this file cannot include) were missing, and the closure helper functions still declared an ffi_type* return type inconsistent with the PPC_LD_* constants they now return. Define the PPC_LD_* constants locally and change the closure helper return types to int. Fixes#987 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Refs: libffi/libffi@9ca53a1 PR-URL: #64040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

sxa · 2026-06-30T09:43:18Z

3.6.0 also includes the fix that I backported in #63794 so great to no longer have that patch being floated :-)

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #64222 Refs: #64040 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>

aduh95 · 2026-07-08T09:24:44Z

+AC_INIT([libffi],[3.6.0],[http://github.com/libffi/libffi/issues])
 AC_CONFIG_HEADERS([fficonfig.h])

 FFI_VERSION_STRING="3.5.2"


I wonder why this wasn't updated, that's the string that get reported when running node -p process.versions.libffi. I've asked in libffi/libffi#992

nodejs-github-bot added dependencies Pull requests that update a dependency file. ffi Issues and PRs related to experimental Foreign Function Interface support. labels Jun 21, 2026

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 21, 2026

ShogunPanda mentioned this pull request Jun 21, 2026
ffi: fix float passing in libffi for riscv64 #63976
Closed

aduh95 approved these changes Jun 21, 2026
View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 21, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2026

aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 21, 2026

Renegade334 reviewed Jun 21, 2026
View reviewed changes

Comment threaddeps/libffi/libffi.gyp

aduh95 mentioned this pull request Jun 21, 2026
tools: update libffi updater script #64046
Merged

Renegade334 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 21, 2026

Renegade334 force-pushed the actions/truetools-update-libffi branch from 4537b46 to 432321bCompare June 21, 2026 21:13

Renegade334 force-pushed the actions/truetools-update-libffi branch from 432321b to b07e414Compare June 21, 2026 22:56

Renegade334 added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 21, 2026

Renegade334 approved these changes Jun 21, 2026
View reviewed changes

Renegade334 requested a review from aduh95 June 22, 2026 00:12

ShogunPanda approved these changes Jun 22, 2026
View reviewed changes

nodejs-github-botand others added 2 commits June 22, 2026 08:55

deps: update libffi to 3.6.0
d9707af
PR-URL: #64040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 force-pushed the actions/truetools-update-libffi branch from b07e414 to e9a9065Compare June 22, 2026 06:56

aduh95 merged commit e9a9065 into mainJun 22, 2026
17 of 18 checks passed

aduh95 deleted the actions/truetools-update-libffi branch June 22, 2026 06:56

aduh95 pushed a commit that referenced this pull request Jun 22, 2026
deps: update libffi to 3.6.0
9761385
PR-URL: #64040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

github-actionsBot mentioned this pull request Jun 22, 2026
2026-06-23, Version 26.4.0 (Current) #64058
Merged

Renegade334 mentioned this pull request Jun 30, 2026
build: suppress clang errors building libffi on Windows #64222
Merged

aduh95 reviewed Jul 8, 2026
View reviewed changes

sxa mentioned this pull request Jul 24, 2026
test-code-cache fails on a Linux/riscv64 build with FFI enabled. #64717
Open

Uh oh!

Uh oh!

Conversation

nodejs-github-bot commented Jun 21, 2026

Uh oh!

nodejs-github-bot commented Jun 21, 2026

Uh oh!

nodejs-github-bot commented Jun 21, 2026

Uh oh!

github-actionsBot commented Jun 21, 2026

Uh oh!

aduh95 commented Jun 21, 2026

Uh oh!

aduh95 commented Jun 21, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 21, 2026

Uh oh!

aduh95 commented Jun 21, 2026

Uh oh!

richardlau commented Jun 21, 2026

Uh oh!

Renegade334 commented Jun 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 commented Jun 21, 2026

Uh oh!

Renegade334 commented Jun 21, 2026

Uh oh!

Renegade334 commented Jun 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Renegade334 commented Jun 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Renegade334 commented Jun 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 commented Jun 21, 2026

Uh oh!

Renegade334 commented Jun 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 21, 2026

Uh oh!

Uh oh!

aduh95 commented Jun 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sxa commented Jun 30, 2026

Uh oh!

aduh95Jul 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Renegade334 commented Jun 21, 2026•
edited
Loading

Renegade334 commented Jun 21, 2026•
edited
Loading

Renegade334 commented Jun 21, 2026•
edited
Loading

Renegade334 commented Jun 21, 2026•
edited
Loading

Renegade334 commented Jun 21, 2026•
edited
Loading

aduh95 commented Jun 22, 2026•
edited
Loading

aduh95Jul 8, 2026•
edited
Loading