test: move assert to improve clarity

[Trott]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

test assert

Description of change

A test is run, and then the relevant assertion is put after a different
test. Place the assertion near the relevant thing it is testing for
clarity.

[cjihrig]

LGTM

[mscdex]

A tad unrelated but wouldn't it be better to just use assert.throws(...) there instead?

[Trott]

@mscdex Yup, probably. I started in on that too but then my "no no no, keep the changeset minimal, do that other stuff some other time" impulse took over.

[Trott]

@mscdex And...it looks like I'll be doing exactly that anyway in the fix for #6416 so this might just get closed anyway...

[jasnell]

LGTM if you decide to land this.

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/2437/

[addaleax]

Adding in progress here because there doesn’t seem any point in landing this if #6432 does.

[jasnell]

Agreed.

[Trott]

#6432 landed so I'm going to close this.