Uh oh!
There was an error while loading. Please reload this page.
deps: update histogram to 0.11.10 - #64296
Conversation
nodejs-github-bot
commented
Jul 5, 2026
Review requested:
|
aduh95
commented
Jul 5, 2026
Related failure on Windows build: |
StefanStojanovic
commented
Jul 6, 2026
I was able to reproduce this locally and to fix it with this simple patch. While it can be patched here, landing this fix in the histogram repo is probably better in the long run. |
aduh95
commented
Jul 6, 2026
Did you send the patch upstream? Once it’s landed there, we can cherry-pick it here |
26c6642 to
f49574cCompareaduh95
commented
Jul 12, 2026
@StefanStojanovic can you follow up of this and link to the upstream PR? I'm happy to take care of updating this PR but I don't feel comfortable sending your patch upstream |
StefanStojanovic
commented
Jul 14, 2026
Hey @aduh95, sorry for not doing this earlier. I've opened a PR upstream at HdrHistogram/HdrHistogram_c#142 |
f49574c to
045c4cfComparefilipecosta90
commented
Jul 23, 2026
@aduh95 and @StefanStojanovic merged. thank you! |
nodejs-github-bot
commented
Jul 24, 2026
PR-URL: #64296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message: Fix ClangCL build on Windows Refs: HdrHistogram/HdrHistogram_c@62ea52b PR-URL: #64296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
52b86e8 to
cdaa88eCompareaduh95
commented
Jul 24, 2026
Landed in 5bdc82d...cdaa88e |
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #64296 +/- ##
==========================================
+ Coverage 90.11% 91.87% +1.75%
==========================================
Files 743 382 -361 Lines 242306 170648 -71658 Branches 45618 26102 -19516 ==========================================
- Hits 218366 156782 -61584 + Misses 15445 13566 -1879 + Partials 8495 300 -8195 🚀 New features to boost your workflow:
|
PR-URL: #64296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message: Fix ClangCL build on Windows Refs: HdrHistogram/HdrHistogram_c@62ea52b PR-URL: #64296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This is an automated update of histogram to 0.11.10.