Uh oh!
There was an error while loading. Please reload this page.
test_runner: report entryFile in TestStream events - #64309
Merged
Conversation
nodejs-github-bot
commented
Jul 5, 2026
Collaborator
Review requested:
|
Signed-off-by: Moshe Atlov <moshe@atlow.co.il>
nodejs-github-bot
commented
Jul 5, 2026
Collaborator
benjamingr
approved these changes
Jul 5, 2026
atlowChemi
approved these changes
Jul 5, 2026
nodejs-github-bot
commented
Jul 6, 2026
Collaborator
MoLow added a commit
to MoLow/reporters
that referenced
this pull request
Jul 6, 2026
…is ambiguous (#241) Under --test process isolation, a helper-file subtest's parentId can match several concurrently open tests from different processes; the eager resolver tie-break attached it to an arbitrary one until the declaration-ordered block self-corrected minutes later (e.g. "restore GCE VM" shown under a DynamoDB test for 20 minutes of a live run). When more than one open candidate matches, attach the subtest to its helper-file group instead of guessing; it is adopted by the first event that sees the collision cleared or by the declaration block. Replaying the originating 40-file run mid-stream drops wrong-test placements from 29 to 4 (single-wrong-candidate cases, unresolvable until nodejs/node#64309 provides entryFile — TODO left at findOpenParents). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 7, 2026
Collaborator
Landed in f4c85d5 |
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Moshe Atlov <moshe@atlow.co.il> PR-URL: #64309 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: Moshe Atlov <moshe@atlow.co.il> PR-URL: #64309 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 added a commit
that referenced
this pull request
Jul 30, 2026
Notable changes: doc: * add MikeMcC399 as collaborator (Mike McCready) #64656 ffi: * (SEMVER-MINOR) add `getCurrentEventLoop` (Paolo Insogna) #64323 test_runner: * (SEMVER-MINOR) add `context.log()` and `test:log` event (Moshe Atlow) #64389 * (SEMVER-MINOR) report `entryFile` in `TestStream` events (Moshe Atlow) #64309 PR-URL: #64655
aduh95 added a commit
that referenced
this pull request
Aug 3, 2026
Notable changes: doc: * add MikeMcC399 as collaborator (Mike McCready) #64656 ffi: * (SEMVER-MINOR) add `getCurrentEventLoop` (Paolo Insogna) #64323 test_runner: * (SEMVER-MINOR) add `context.log()` and `test:log` event (Moshe Atlow) #64389 * (SEMVER-MINOR) report `entryFile` in `TestStream` events (Moshe Atlow) #64309 PR-URL: #64655
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Moshe Atlov <moshe@atlow.co.il> PR-URL: #64309 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.