http: fix perf_hooks detail.req.url port and proxied path by stefanobaghino · Pull Request #64311 · nodejs/node

stefanobaghino · 2026-07-05T19:38:52Z

The detail.req.url reported on http performance entries for HttpClient misrepresents the request URL in two ways: the port is dropped when it is non-default (http://localhost:3000/foo is reported as http://localhost/foo), and when the request path has been rewritten to absolute-form for HTTP proxying it is appended to the protocol and hostname again (http://localhosthttp://localhost:3000/foo).

The URL is now built from the connection authority captured at request creation (which carries the non-default port and IPv6 brackets, same as the auto-generated Host header), and when the path has been rewritten to absolute-form for proxying it is reported as-is, since it is already the full normalized URL.

Fixes: #59625

nodejs-github-bot · 2026-07-05T19:38:57Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me>

stefanobaghino · 2026-07-06T17:30:03Z

Amended the commit to comply with the Signed-off-by requirement (and re-wrapped the message body at 72 columns), which is what made the commit message linting fail.

stefanobaghino · 2026-07-07T08:15:52Z

🤔 The failure looks like an unrelated flaky test.

stefanobaghino · 2026-07-08T08:13:44Z

Is there some way in which I can trigger CI myself? 🙂

nodejs-github-bot · 2026-07-08T14:21:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74664/ 💚

stefanobaghino · 2026-07-12T08:17:04Z

Thanks for the reviews, everyone! This looks ready to land whenever a collaborator has a chance. Very happy to help move it along in any way I can — rebasing, amending the commit, or anything else — just let me know what would be useful.

nodejs-github-bot · 2026-07-12T14:48:44Z

Landed in 2d7fee0

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

Follow-up cleanups to the kAuthority/kProxyRewrittenToAbsolute port so it matches nodejs/node#64311 more closely. Initialize kProxyRewrittenToAbsolute next to kPath rather than after the proxy rewrite block. Node can initialize it late because its rewrite happens in rewriteForProxiedHttp() after construction, but here the rewrite is inline in the constructor, so `x = x || false` was load-bearing on statement order. Setting it before the rewrite drops that coupling. Hoist posColon out of the bare block it was wrapped in and restore the RFC 3986 comment from upstream. Drop the `|| host` fallback in the perf entry. `host` always resolves to at least "localhost", so kAuthority is never empty and the fallback was dead - it only obscured that a caller-supplied Host header no longer determines the reported URL, which is what Node does. Apply the same fix to the OpenTelemetry client span, which built url.full the same way and so carried the same proxy path duplication. This part has no upstream counterpart; Node has no OTel instrumentation here.

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

stefanobaghino · 2026-07-05T19:38:52Z

The detail.req.url reported on http performance entries for HttpClient misrepresents the request URL in two ways: the port is dropped when it is non-default (http://localhost:3000/foo is reported as http://localhost/foo), and when the request path has been rewritten to absolute-form for HTTP proxying it is appended to the protocol and hostname again (http://localhosthttp://localhost:3000/foo).

The URL is now built from the connection authority captured at request creation (which carries the non-default port and IPv6 brackets, same as the auto-generated Host header), and when the path has been rewritten to absolute-form for proxying it is reported as-is, since it is already the full normalized URL.

Fixes: #59625

nodejs-github-bot · 2026-07-05T19:38:57Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me>

stefanobaghino · 2026-07-06T17:30:03Z

Amended the commit to comply with the Signed-off-by requirement (and re-wrapped the message body at 72 columns), which is what made the commit message linting fail.

stefanobaghino · 2026-07-07T08:15:52Z

🤔 The failure looks like an unrelated flaky test.

stefanobaghino · 2026-07-08T08:13:44Z

Is there some way in which I can trigger CI myself? 🙂

nodejs-github-bot · 2026-07-08T14:21:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74664/ 💚

stefanobaghino · 2026-07-12T08:17:04Z

Thanks for the reviews, everyone! This looks ready to land whenever a collaborator has a chance. Very happy to help move it along in any way I can — rebasing, amending the commit, or anything else — just let me know what would be useful.

nodejs-github-bot · 2026-07-12T14:48:44Z

Landed in 2d7fee0

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

Follow-up cleanups to the kAuthority/kProxyRewrittenToAbsolute port so it matches nodejs/node#64311 more closely. Initialize kProxyRewrittenToAbsolute next to kPath rather than after the proxy rewrite block. Node can initialize it late because its rewrite happens in rewriteForProxiedHttp() after construction, but here the rewrite is inline in the constructor, so `x = x || false` was load-bearing on statement order. Setting it before the rewrite drops that coupling. Hoist posColon out of the bare block it was wrapped in and restore the RFC 3986 comment from upstream. Drop the `|| host` fallback in the perf entry. `host` always resolves to at least "localhost", so kAuthority is never empty and the fallback was dead - it only obscured that a caller-supplied Host header no longer determines the reported URL, which is what Node does. Apply the same fix to the OpenTelemetry client span, which built url.full the same way and so carried the same proxy path duplication. This part has no upstream counterpart; Node has no OTel instrumentation here.

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

stefanobaghino · 2026-07-05T19:38:52Z

The detail.req.url reported on http performance entries for HttpClient misrepresents the request URL in two ways: the port is dropped when it is non-default (http://localhost:3000/foo is reported as http://localhost/foo), and when the request path has been rewritten to absolute-form for HTTP proxying it is appended to the protocol and hostname again (http://localhosthttp://localhost:3000/foo).

The URL is now built from the connection authority captured at request creation (which carries the non-default port and IPv6 brackets, same as the auto-generated Host header), and when the path has been rewritten to absolute-form for proxying it is reported as-is, since it is already the full normalized URL.

Fixes: #59625

nodejs-github-bot · 2026-07-05T19:38:57Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me>

stefanobaghino · 2026-07-06T17:30:03Z

Amended the commit to comply with the Signed-off-by requirement (and re-wrapped the message body at 72 columns), which is what made the commit message linting fail.

stefanobaghino · 2026-07-07T08:15:52Z

🤔 The failure looks like an unrelated flaky test.

stefanobaghino · 2026-07-08T08:13:44Z

Is there some way in which I can trigger CI myself? 🙂

nodejs-github-bot · 2026-07-08T14:21:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74664/ 💚

stefanobaghino · 2026-07-12T08:17:04Z

Thanks for the reviews, everyone! This looks ready to land whenever a collaborator has a chance. Very happy to help move it along in any way I can — rebasing, amending the commit, or anything else — just let me know what would be useful.

nodejs-github-bot · 2026-07-12T14:48:44Z

Landed in 2d7fee0

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

Follow-up cleanups to the kAuthority/kProxyRewrittenToAbsolute port so it matches nodejs/node#64311 more closely. Initialize kProxyRewrittenToAbsolute next to kPath rather than after the proxy rewrite block. Node can initialize it late because its rewrite happens in rewriteForProxiedHttp() after construction, but here the rewrite is inline in the constructor, so `x = x || false` was load-bearing on statement order. Setting it before the rewrite drops that coupling. Hoist posColon out of the bare block it was wrapped in and restore the RFC 3986 comment from upstream. Drop the `|| host` fallback in the perf entry. `host` always resolves to at least "localhost", so kAuthority is never empty and the fallback was dead - it only obscured that a caller-supplied Host header no longer determines the reported URL, which is what Node does. Apply the same fix to the OpenTelemetry client span, which built url.full the same way and so carried the same proxy path duplication. This part has no upstream counterpart; Node has no OTel instrumentation here.

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

stefanobaghino · 2026-07-05T19:38:52Z

The detail.req.url reported on http performance entries for HttpClient misrepresents the request URL in two ways: the port is dropped when it is non-default (http://localhost:3000/foo is reported as http://localhost/foo), and when the request path has been rewritten to absolute-form for HTTP proxying it is appended to the protocol and hostname again (http://localhosthttp://localhost:3000/foo).

The URL is now built from the connection authority captured at request creation (which carries the non-default port and IPv6 brackets, same as the auto-generated Host header), and when the path has been rewritten to absolute-form for proxying it is reported as-is, since it is already the full normalized URL.

Fixes: #59625

nodejs-github-bot · 2026-07-05T19:38:57Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me>

stefanobaghino · 2026-07-06T17:30:03Z

Amended the commit to comply with the Signed-off-by requirement (and re-wrapped the message body at 72 columns), which is what made the commit message linting fail.

stefanobaghino · 2026-07-07T08:15:52Z

🤔 The failure looks like an unrelated flaky test.

stefanobaghino · 2026-07-08T08:13:44Z

Is there some way in which I can trigger CI myself? 🙂

nodejs-github-bot · 2026-07-08T14:21:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74664/ 💚

stefanobaghino · 2026-07-12T08:17:04Z

Thanks for the reviews, everyone! This looks ready to land whenever a collaborator has a chance. Very happy to help move it along in any way I can — rebasing, amending the commit, or anything else — just let me know what would be useful.

nodejs-github-bot · 2026-07-12T14:48:44Z

Landed in 2d7fee0

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

Follow-up cleanups to the kAuthority/kProxyRewrittenToAbsolute port so it matches nodejs/node#64311 more closely. Initialize kProxyRewrittenToAbsolute next to kPath rather than after the proxy rewrite block. Node can initialize it late because its rewrite happens in rewriteForProxiedHttp() after construction, but here the rewrite is inline in the constructor, so `x = x || false` was load-bearing on statement order. Setting it before the rewrite drops that coupling. Hoist posColon out of the bare block it was wrapped in and restore the RFC 3986 comment from upstream. Drop the `|| host` fallback in the perf entry. `host` always resolves to at least "localhost", so kAuthority is never empty and the fallback was dead - it only obscured that a caller-supplied Host header no longer determines the reported URL, which is what Node does. Apply the same fix to the OpenTelemetry client span, which built url.full the same way and so carried the same proxy path duplication. This part has no upstream counterpart; Node has no OTel instrumentation here.

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

stefanobaghino · 2026-07-05T19:38:52Z

The detail.req.url reported on http performance entries for HttpClient misrepresents the request URL in two ways: the port is dropped when it is non-default (http://localhost:3000/foo is reported as http://localhost/foo), and when the request path has been rewritten to absolute-form for HTTP proxying it is appended to the protocol and hostname again (http://localhosthttp://localhost:3000/foo).

The URL is now built from the connection authority captured at request creation (which carries the non-default port and IPv6 brackets, same as the auto-generated Host header), and when the path has been rewritten to absolute-form for proxying it is reported as-is, since it is already the full normalized URL.

Fixes: #59625

nodejs-github-bot · 2026-07-05T19:38:57Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me>

stefanobaghino · 2026-07-06T17:30:03Z

Amended the commit to comply with the Signed-off-by requirement (and re-wrapped the message body at 72 columns), which is what made the commit message linting fail.

stefanobaghino · 2026-07-07T08:15:52Z

🤔 The failure looks like an unrelated flaky test.

stefanobaghino · 2026-07-08T08:13:44Z

Is there some way in which I can trigger CI myself? 🙂

nodejs-github-bot · 2026-07-08T14:21:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74664/ 💚

stefanobaghino · 2026-07-12T08:17:04Z

Thanks for the reviews, everyone! This looks ready to land whenever a collaborator has a chance. Very happy to help move it along in any way I can — rebasing, amending the commit, or anything else — just let me know what would be useful.

nodejs-github-bot · 2026-07-12T14:48:44Z

Landed in 2d7fee0

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

Follow-up cleanups to the kAuthority/kProxyRewrittenToAbsolute port so it matches nodejs/node#64311 more closely. Initialize kProxyRewrittenToAbsolute next to kPath rather than after the proxy rewrite block. Node can initialize it late because its rewrite happens in rewriteForProxiedHttp() after construction, but here the rewrite is inline in the constructor, so `x = x || false` was load-bearing on statement order. Setting it before the rewrite drops that coupling. Hoist posColon out of the bare block it was wrapped in and restore the RFC 3986 comment from upstream. Drop the `|| host` fallback in the perf entry. `host` always resolves to at least "localhost", so kAuthority is never empty and the fallback was dead - it only obscured that a caller-supplied Host header no longer determines the reported URL, which is what Node does. Apply the same fix to the OpenTelemetry client span, which built url.full the same way and so carried the same proxy path duplication. This part has no upstream counterpart; Node has no OTel instrumentation here.

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

stefanobaghino · 2026-07-05T19:38:52Z

The detail.req.url reported on http performance entries for HttpClient misrepresents the request URL in two ways: the port is dropped when it is non-default (http://localhost:3000/foo is reported as http://localhost/foo), and when the request path has been rewritten to absolute-form for HTTP proxying it is appended to the protocol and hostname again (http://localhosthttp://localhost:3000/foo).

The URL is now built from the connection authority captured at request creation (which carries the non-default port and IPv6 brackets, same as the auto-generated Host header), and when the path has been rewritten to absolute-form for proxying it is reported as-is, since it is already the full normalized URL.

Fixes: #59625

nodejs-github-bot · 2026-07-05T19:38:57Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me>

stefanobaghino · 2026-07-06T17:30:03Z

Amended the commit to comply with the Signed-off-by requirement (and re-wrapped the message body at 72 columns), which is what made the commit message linting fail.

stefanobaghino · 2026-07-07T08:15:52Z

🤔 The failure looks like an unrelated flaky test.

stefanobaghino · 2026-07-08T08:13:44Z

Is there some way in which I can trigger CI myself? 🙂

nodejs-github-bot · 2026-07-08T14:21:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74664/ 💚

stefanobaghino · 2026-07-12T08:17:04Z

Thanks for the reviews, everyone! This looks ready to land whenever a collaborator has a chance. Very happy to help move it along in any way I can — rebasing, amending the commit, or anything else — just let me know what would be useful.

nodejs-github-bot · 2026-07-12T14:48:44Z

Landed in 2d7fee0

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

Follow-up cleanups to the kAuthority/kProxyRewrittenToAbsolute port so it matches nodejs/node#64311 more closely. Initialize kProxyRewrittenToAbsolute next to kPath rather than after the proxy rewrite block. Node can initialize it late because its rewrite happens in rewriteForProxiedHttp() after construction, but here the rewrite is inline in the constructor, so `x = x || false` was load-bearing on statement order. Setting it before the rewrite drops that coupling. Hoist posColon out of the bare block it was wrapped in and restore the RFC 3986 comment from upstream. Drop the `|| host` fallback in the perf entry. `host` always resolves to at least "localhost", so kAuthority is never empty and the fallback was dead - it only obscured that a caller-supplied Host header no longer determines the reported URL, which is what Node does. Apply the same fix to the OpenTelemetry client span, which built url.full the same way and so carried the same proxy path duplication. This part has no upstream counterpart; Node has no OTel instrumentation here.

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

stefanobaghino · 2026-07-05T19:38:52Z

The detail.req.url reported on http performance entries for HttpClient misrepresents the request URL in two ways: the port is dropped when it is non-default (http://localhost:3000/foo is reported as http://localhost/foo), and when the request path has been rewritten to absolute-form for HTTP proxying it is appended to the protocol and hostname again (http://localhosthttp://localhost:3000/foo).

The URL is now built from the connection authority captured at request creation (which carries the non-default port and IPv6 brackets, same as the auto-generated Host header), and when the path has been rewritten to absolute-form for proxying it is reported as-is, since it is already the full normalized URL.

Fixes: #59625

nodejs-github-bot · 2026-07-05T19:38:57Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me>

stefanobaghino · 2026-07-06T17:30:03Z

Amended the commit to comply with the Signed-off-by requirement (and re-wrapped the message body at 72 columns), which is what made the commit message linting fail.

stefanobaghino · 2026-07-07T08:15:52Z

🤔 The failure looks like an unrelated flaky test.

stefanobaghino · 2026-07-08T08:13:44Z

Is there some way in which I can trigger CI myself? 🙂

nodejs-github-bot · 2026-07-08T14:21:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74664/ 💚

stefanobaghino · 2026-07-12T08:17:04Z

Thanks for the reviews, everyone! This looks ready to land whenever a collaborator has a chance. Very happy to help move it along in any way I can — rebasing, amending the commit, or anything else — just let me know what would be useful.

nodejs-github-bot · 2026-07-12T14:48:44Z

Landed in 2d7fee0

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

Follow-up cleanups to the kAuthority/kProxyRewrittenToAbsolute port so it matches nodejs/node#64311 more closely. Initialize kProxyRewrittenToAbsolute next to kPath rather than after the proxy rewrite block. Node can initialize it late because its rewrite happens in rewriteForProxiedHttp() after construction, but here the rewrite is inline in the constructor, so `x = x || false` was load-bearing on statement order. Setting it before the rewrite drops that coupling. Hoist posColon out of the bare block it was wrapped in and restore the RFC 3986 comment from upstream. Drop the `|| host` fallback in the perf entry. `host` always resolves to at least "localhost", so kAuthority is never empty and the fallback was dead - it only obscured that a caller-supplied Host header no longer determines the reported URL, which is what Node does. Apply the same fix to the OpenTelemetry client span, which built url.full the same way and so carried the same proxy path duplication. This part has no upstream counterpart; Node has no OTel instrumentation here.

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

stefanobaghino · 2026-07-05T19:38:52Z

The detail.req.url reported on http performance entries for HttpClient misrepresents the request URL in two ways: the port is dropped when it is non-default (http://localhost:3000/foo is reported as http://localhost/foo), and when the request path has been rewritten to absolute-form for HTTP proxying it is appended to the protocol and hostname again (http://localhosthttp://localhost:3000/foo).

The URL is now built from the connection authority captured at request creation (which carries the non-default port and IPv6 brackets, same as the auto-generated Host header), and when the path has been rewritten to absolute-form for proxying it is reported as-is, since it is already the full normalized URL.

Fixes: #59625

nodejs-github-bot · 2026-07-05T19:38:57Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me>

stefanobaghino · 2026-07-06T17:30:03Z

Amended the commit to comply with the Signed-off-by requirement (and re-wrapped the message body at 72 columns), which is what made the commit message linting fail.

stefanobaghino · 2026-07-07T08:15:52Z

🤔 The failure looks like an unrelated flaky test.

stefanobaghino · 2026-07-08T08:13:44Z

Is there some way in which I can trigger CI myself? 🙂

nodejs-github-bot · 2026-07-08T14:21:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74664/ 💚

stefanobaghino · 2026-07-12T08:17:04Z

Thanks for the reviews, everyone! This looks ready to land whenever a collaborator has a chance. Very happy to help move it along in any way I can — rebasing, amending the commit, or anything else — just let me know what would be useful.

nodejs-github-bot · 2026-07-12T14:48:44Z

Landed in 2d7fee0

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

Follow-up cleanups to the kAuthority/kProxyRewrittenToAbsolute port so it matches nodejs/node#64311 more closely. Initialize kProxyRewrittenToAbsolute next to kPath rather than after the proxy rewrite block. Node can initialize it late because its rewrite happens in rewriteForProxiedHttp() after construction, but here the rewrite is inline in the constructor, so `x = x || false` was load-bearing on statement order. Setting it before the rewrite drops that coupling. Hoist posColon out of the bare block it was wrapped in and restore the RFC 3986 comment from upstream. Drop the `|| host` fallback in the perf entry. `host` always resolves to at least "localhost", so kAuthority is never empty and the fallback was dead - it only obscured that a caller-supplied Host header no longer determines the reported URL, which is what Node does. Apply the same fix to the OpenTelemetry client span, which built url.full the same way and so carried the same proxy path duplication. This part has no upstream counterpart; Node has no OTel instrumentation here.

The perf_hooks HTTP client entry built the reported URL from the bare hostname, dropping non-default ports and IPv6 brackets, and appended the request path even after it had been rewritten to absolute-form for proxying, duplicating the protocol and authority. Report the connection authority captured at request creation and, for proxied requests, use the rewritten absolute-form target as-is. Fixes: #59625 Signed-off-by: Stefano Baghino <stefano@baghino.me> PR-URL: #64311 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com>

nodejs-github-bot added http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 5, 2026

mcollina approved these changes Jul 5, 2026
View reviewed changes

joyeecheung approved these changes Jul 6, 2026
View reviewed changes

stefanobaghino force-pushed the perf_hooks/fix-http-detail-url branch from f627005 to 9e4d4b0Compare July 6, 2026 16:20

jasnell approved these changes Jul 7, 2026
View reviewed changes

theanarkh approved these changes Jul 7, 2026
View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2026

tawatakumi mentioned this pull request Jul 8, 2026
Add PVRB-003 for Node.js perf_hooks URL risk tawatakumi/pr-risk-briefs#2
Open

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2026

jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 12, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 12, 2026

nodejs-github-bot merged commit 2d7fee0 into nodejs:mainJul 12, 2026
70 of 71 checks passed

github-actionsBot mentioned this pull request Jul 21, 2026
2026-07-22, Version 26.6.0 (Current) #64655
Merged

github-actionsBot mentioned this pull request Aug 21, 2026
2026-08-26, Version 24.20.0 'Krypton' (LTS) #65461
Merged