util: fix OSC 8 hyperlink stripping in stripVTControlCharacters - #64319

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Aug 24, 2026
Merged

util: fix OSC 8 hyperlink stripping in stripVTControlCharacters#64319
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars

Conversation

@dushyant-hada-90

@dushyant-hada-90dushyant-hada-90 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64313

Summary

The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].

This updates OSC handling to match sequences generically as:

ESC ] ... ST

aligned with ansi-regex v6.2.0.

Problem

stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:

[-a-zA-Z\d/#&.:=?%@~_]

Example:

import{stripVTControlCharacters}from'node:util';constlink='\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';console.log(stripVTControlCharacters(link));

Actual

ttps://example.com/(foo\u0007label

Expected

label

The OSC match terminated early at (, leaving most of the escape sequence in the output.

Changes

  • Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
  • Sync the bundled regex behavior with ansi-regex v6.2.0
  • Preserve existing CSI handling logic

Tests

Added regression coverage in:

test/parallel/test-util-stripvtcontrolcharacters.js

for OSC 8 hyperlinks containing:

  • (
  • )
  • !
  • +
  • [ ]

across all supported OSC string terminators.

Notes

  • Existing CSI handling is unchanged
  • Fast-path behavior is unchanged
  • Embedded OSC terminators inside URIs retain previous behavior

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jul 6, 2026
Archkon
Archkon reviewed Jul 7, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js Outdated
'[\\dA-PR-TZcf-nq-uy=><~]))', 'g',
'(?:\\u001B\\][\\s\\S]*?(?:\\u0007|\\u001B\\u005C|\\u009C))' +
'|[\\u001B\\u009B][[\\]()#;?]*' +
'(?:(?:\\d{1,4}(?:;\\d{0,4})*)?' +

This comment was marked as spam.

Sign in to view

Comment threadlib/internal/util/inspect.js Outdated
@dushyant-hada-90
dushyant-hada-90force-pushed the fix/strip-vt-osc-8-uri-chars branch from e3d3cb8 to 9da6ef2CompareJuly 8, 2026 05:40
@dushyant-hada-90

dushyant-hada-90 commented Jul 8, 2026

Copy link
Copy Markdown
ContributorAuthor

Pushed updates addressing the feedback:

Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines
Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case

Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.
Ready for another look

avivkeller
avivkeller reviewed Jul 20, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js Outdated
@dushyant-hada-90
dushyant-hada-90force-pushed the fix/strip-vt-osc-8-uri-chars branch 2 times, most recently from 711b204 to 7a426b8CompareJuly 20, 2026 17:37
@dushyant-hada-90

dushyant-hada-90 commented Jul 24, 2026

Copy link
Copy Markdown
ContributorAuthor

Hi @Archkon, @avivkeller
I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!

avivkeller
avivkeller reviewed Jul 24, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
@avivkelleravivkeller added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 25, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75131/

@codecov

codecovBot commented Jul 26, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (00917ba) to head (8bcabf1).
⚠️ Report is 562 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64319 +/- ##
========================================
Coverage 90.14% 90.14% ========================================
Files 741 744 +3 Lines 242076 242516 +440 Branches 45558 45691 +133 ========================================
+ Hits 218216 218613 +397 - Misses 15385 15409 +24 - Partials 8475 8494 +19
Files with missing linesCoverage Δ
lib/internal/util/inspect.js96.93% <100.00%> (-0.01%)⬇️

... and 100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dushyant-hada-90and others added 6 commits July 27, 2026 00:57
@dushyant-hada-90@cursoragent
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0817b0a
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@Archkon
util: use [;:] as CSI parameter separator, matching ansi-regex v6.2.0
273fbfe
Co-authored-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: extend stripVTControlCharacters regression tests
29f6205
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@cursoragent
util: use full ansi-regex commit SHA in comment
20fc79d
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: align CSI regex grouping with ansi-regex
983f681
Remove the extra non-capturing group around CSI parameters and
the final byte so the bundled pattern matches ansi-regex at
72bc570 exactly.
Refs: https://github.com/chalk/ansi-regex/blob/72bc570aaf25fca25541b49c6a8564f3ec63e835/index.js
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
test: clarify unterminated OSC strip comment
8bcabf1
The previous comment claimed truncated OSC sequences were left
unmatched rather than partially stripped. The CSI alternative can
still consume a short prefix, which is why the expected remainder
is 'ttps://...'. Update the comment to describe that behavior.
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
dushyant-hada-90force-pushed the fix/strip-vt-osc-8-uri-chars branch from a40efe2 to 8bcabf1CompareJuly 26, 2026 19:29
@dushyant-hada-90

dushyant-hada-90 commented Jul 26, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.
Kindly re-approve CI when convenient.
@avivkeller

@avivkelleravivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75280/

@dushyant-hada-90

dushyant-hada-90 commented Aug 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Friendly ping,
@Archkon — whenever you have a chance, could you please review and approve this PR if everything looks good? Thank you!

@Archkon

This comment was marked as spam.

Sign in to view
@dushyant-hada-90

dushyant-hada-90 commented Aug 4, 2026

Copy link
Copy Markdown
ContributorAuthor

Hi @aduh95 , can you please have a look at this PR when you have a chance? If everything looks good, I'd appreciate your help getting it landed. Thank you!

@trivikrtrivikr removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 9, 2026
@luantaraschiluantaraschi mentioned this pull request Aug 18, 2026
Open
@trivikrtrivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76259/

@trivikrtrivikr added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76335/

@trivikrtrivikr added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5b316e5 into nodejs:mainAug 24, 2026
84 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Landed in 5b316e5

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
c7231f6
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
f644853
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95 mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0714ed5
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller approved these changes
@ArchkonArchkonAwaiting requested review from Archkon

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

util.stripVTControlCharacters() fails to strip OSC 8 hyperlinks whose URI contains characters like "("

5 participants

@dushyant-hada-90@nodejs-github-bot@Archkon@avivkeller@trivikr
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters - #64319
Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Aug 24, 2026
Merged
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters#64319
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Conversation
@dushyant-hada-90
@dushyant-hada-90dushyant-hada-90
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64313
Summary
The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].
This updates OSC handling to match sequences generically as:
ESC ] ... ST
aligned with ansi-regex v6.2.0.
Problem
stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:
[-a-zA-Z\d/#&.:=?%@~_]
Example:
import{stripVTControlCharacters}from'node:util';constlink='\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';console.log(stripVTControlCharacters(link));
Actual
ttps://example.com/(foo\u0007label
Expected
label
The OSC match terminated early at (, leaving most of the escape sequence in the output.
Changes
  • Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
  • Sync the bundled regex behavior with ansi-regex v6.2.0
  • Preserve existing CSI handling logic
Tests
Added regression coverage in:
test/parallel/test-util-stripvtcontrolcharacters.js
for OSC 8 hyperlinks containing:
  • (
  • )
  • !
  • +
  • [ ]
across all supported OSC string terminators.
Notes
  • Existing CSI handling is unchanged
  • Fast-path behavior is unchanged
  • Embedded OSC terminators inside URIs retain previous behavior
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jul 6, 2026
Archkon
Archkon
reviewed
Jul 7, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

 '[\\dA-PR-TZcf-nq-uy=><~]))', 'g',
 '(?:\\u001B\\][\\s\\S]*?(?:\\u0007|\\u001B\\u005C|\\u009C))' +
 '|[\\u001B\\u009B][[\\]()#;?]*' +
 '(?:(?:\\d{1,4}(?:;\\d{0,4})*)?' +

This comment was marked as spam.

Sign in to view
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
e3d3cb8 to
9da6ef2CompareJuly 8, 2026 05:40
@dushyant-hada-90
dushyant-hada-90
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Pushed updates addressing the feedback:
Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines

Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case
Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.

Ready for another look
avivkeller
avivkeller
reviewed
Jul 20, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
2 times, most recently
from
711b204 to
7a426b8CompareJuly 20, 2026 17:37
@dushyant-hada-90
dushyant-hada-90
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @Archkon, @avivkeller

I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!
avivkeller
avivkeller
reviewed
Jul 24, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 25, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 25, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75131/
@codecov
codecovBot
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (00917ba) to head (8bcabf1).
⚠️ Report is 562 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64319 +/- ##
========================================
Coverage 90.14% 90.14% ========================================
Files 741 744 +3 Lines 242076 242516 +440 Branches 45558 45691 +133 ========================================
+ Hits 218216 218613 +397 - Misses 15385 15409 +24 - Partials 8475 8494 +19 
Files with missing linesCoverage Δ
lib/internal/util/inspect.js96.93% <100.00%> (-0.01%)⬇️
... and 100 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
dushyant-hada-90and others
added 6 commits
July 27, 2026 00:57
@dushyant-hada-90@cursoragent
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0817b0a
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@Archkon
util: use [;:] as CSI parameter separator, matching ansi-regex v6.2.0
273fbfe
Co-authored-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: extend stripVTControlCharacters regression tests
29f6205
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@cursoragent
util: use full ansi-regex commit SHA in comment
20fc79d
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: align CSI regex grouping with ansi-regex
983f681
Remove the extra non-capturing group around CSI parameters and
the final byte so the bundled pattern matches ansi-regex at
72bc570 exactly.
Refs: https://github.com/chalk/ansi-regex/blob/72bc570aaf25fca25541b49c6a8564f3ec63e835/index.js
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
test: clarify unterminated OSC strip comment
8bcabf1
The previous comment claimed truncated OSC sequences were left
unmatched rather than partially stripped. The CSI alternative can
still consume a short prefix, which is why the expected remainder
is 'ttps://...'. Update the comment to describe that behavior.
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
a40efe2 to
8bcabf1CompareJuly 26, 2026 19:29
@dushyant-hada-90
dushyant-hada-90
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.

Kindly re-approve CI when convenient.
@avivkeller
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 29, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75280/
@dushyant-hada-90
dushyant-hada-90
commented
Aug 2, 2026

Copy link


Copy Markdown

ContributorAuthor
Friendly ping,
@Archkon — whenever you have a chance, could you please review and approve this PR if everything looks good? Thank you!
@Archkon

This comment was marked as spam.

Sign in to view
@dushyant-hada-90
dushyant-hada-90
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @aduh95 , can you please have a look at this PR when you have a chance? If everything looks good, I'd appreciate your help getting it landed. Thank you!
@trivikrtrivikr
removed
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 9, 2026
@luantaraschiluantaraschi
mentioned this pull request
Aug 18, 2026
 Open

@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76259/
@trivikrtrivikr
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76335/
@trivikrtrivikr
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5b316e5
into
nodejs:mainAug 24, 2026

84 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5b316e5
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 24, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
c7231f6
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
f644853
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0714ed5
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller approved these changes
@ArchkonArchkonAwaiting requested review from Archkon

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

util.stripVTControlCharacters() fails to strip OSC 8 hyperlinks whose URI contains characters like "("


5 participants

@dushyant-hada-90@nodejs-github-bot@Archkon@avivkeller@trivikr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters - #64319
Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Aug 24, 2026
Merged
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters#64319
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Conversation
@dushyant-hada-90
@dushyant-hada-90dushyant-hada-90
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64313
Summary
The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].
This updates OSC handling to match sequences generically as:
ESC ] ... ST
aligned with ansi-regex v6.2.0.
Problem
stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:
[-a-zA-Z\d/#&.:=?%@~_]
Example:
import{stripVTControlCharacters}from'node:util';constlink='\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';console.log(stripVTControlCharacters(link));
Actual
ttps://example.com/(foo\u0007label
Expected
label
The OSC match terminated early at (, leaving most of the escape sequence in the output.
Changes
  • Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
  • Sync the bundled regex behavior with ansi-regex v6.2.0
  • Preserve existing CSI handling logic
Tests
Added regression coverage in:
test/parallel/test-util-stripvtcontrolcharacters.js
for OSC 8 hyperlinks containing:
  • (
  • )
  • !
  • +
  • [ ]
across all supported OSC string terminators.
Notes
  • Existing CSI handling is unchanged
  • Fast-path behavior is unchanged
  • Embedded OSC terminators inside URIs retain previous behavior
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jul 6, 2026
Archkon
Archkon
reviewed
Jul 7, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

 '[\\dA-PR-TZcf-nq-uy=><~]))', 'g',
 '(?:\\u001B\\][\\s\\S]*?(?:\\u0007|\\u001B\\u005C|\\u009C))' +
 '|[\\u001B\\u009B][[\\]()#;?]*' +
 '(?:(?:\\d{1,4}(?:;\\d{0,4})*)?' +

This comment was marked as spam.

Sign in to view
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
e3d3cb8 to
9da6ef2CompareJuly 8, 2026 05:40
@dushyant-hada-90
dushyant-hada-90
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Pushed updates addressing the feedback:
Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines

Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case
Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.

Ready for another look
avivkeller
avivkeller
reviewed
Jul 20, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
2 times, most recently
from
711b204 to
7a426b8CompareJuly 20, 2026 17:37
@dushyant-hada-90
dushyant-hada-90
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @Archkon, @avivkeller

I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!
avivkeller
avivkeller
reviewed
Jul 24, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 25, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 25, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75131/
@codecov
codecovBot
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (00917ba) to head (8bcabf1).
⚠️ Report is 562 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64319 +/- ##
========================================
Coverage 90.14% 90.14% ========================================
Files 741 744 +3 Lines 242076 242516 +440 Branches 45558 45691 +133 ========================================
+ Hits 218216 218613 +397 - Misses 15385 15409 +24 - Partials 8475 8494 +19 
Files with missing linesCoverage Δ
lib/internal/util/inspect.js96.93% <100.00%> (-0.01%)⬇️
... and 100 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
dushyant-hada-90and others
added 6 commits
July 27, 2026 00:57
@dushyant-hada-90@cursoragent
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0817b0a
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@Archkon
util: use [;:] as CSI parameter separator, matching ansi-regex v6.2.0
273fbfe
Co-authored-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: extend stripVTControlCharacters regression tests
29f6205
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@cursoragent
util: use full ansi-regex commit SHA in comment
20fc79d
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: align CSI regex grouping with ansi-regex
983f681
Remove the extra non-capturing group around CSI parameters and
the final byte so the bundled pattern matches ansi-regex at
72bc570 exactly.
Refs: https://github.com/chalk/ansi-regex/blob/72bc570aaf25fca25541b49c6a8564f3ec63e835/index.js
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
test: clarify unterminated OSC strip comment
8bcabf1
The previous comment claimed truncated OSC sequences were left
unmatched rather than partially stripped. The CSI alternative can
still consume a short prefix, which is why the expected remainder
is 'ttps://...'. Update the comment to describe that behavior.
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
a40efe2 to
8bcabf1CompareJuly 26, 2026 19:29
@dushyant-hada-90
dushyant-hada-90
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.

Kindly re-approve CI when convenient.
@avivkeller
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 29, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75280/
@dushyant-hada-90
dushyant-hada-90
commented
Aug 2, 2026

Copy link


Copy Markdown

ContributorAuthor
Friendly ping,
@Archkon — whenever you have a chance, could you please review and approve this PR if everything looks good? Thank you!
@Archkon

This comment was marked as spam.

Sign in to view
@dushyant-hada-90
dushyant-hada-90
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @aduh95 , can you please have a look at this PR when you have a chance? If everything looks good, I'd appreciate your help getting it landed. Thank you!
@trivikrtrivikr
removed
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 9, 2026
@luantaraschiluantaraschi
mentioned this pull request
Aug 18, 2026
 Open

@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76259/
@trivikrtrivikr
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76335/
@trivikrtrivikr
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5b316e5
into
nodejs:mainAug 24, 2026

84 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5b316e5
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 24, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
c7231f6
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
f644853
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0714ed5
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller approved these changes
@ArchkonArchkonAwaiting requested review from Archkon

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

util.stripVTControlCharacters() fails to strip OSC 8 hyperlinks whose URI contains characters like "("


5 participants

@dushyant-hada-90@nodejs-github-bot@Archkon@avivkeller@trivikr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters - #64319
Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Aug 24, 2026
Merged
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters#64319
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Conversation
@dushyant-hada-90
@dushyant-hada-90dushyant-hada-90
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64313
Summary
The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].
This updates OSC handling to match sequences generically as:
ESC ] ... ST
aligned with ansi-regex v6.2.0.
Problem
stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:
[-a-zA-Z\d/#&.:=?%@~_]
Example:
import{stripVTControlCharacters}from'node:util';constlink='\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';console.log(stripVTControlCharacters(link));
Actual
ttps://example.com/(foo\u0007label
Expected
label
The OSC match terminated early at (, leaving most of the escape sequence in the output.
Changes
  • Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
  • Sync the bundled regex behavior with ansi-regex v6.2.0
  • Preserve existing CSI handling logic
Tests
Added regression coverage in:
test/parallel/test-util-stripvtcontrolcharacters.js
for OSC 8 hyperlinks containing:
  • (
  • )
  • !
  • +
  • [ ]
across all supported OSC string terminators.
Notes
  • Existing CSI handling is unchanged
  • Fast-path behavior is unchanged
  • Embedded OSC terminators inside URIs retain previous behavior
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jul 6, 2026
Archkon
Archkon
reviewed
Jul 7, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

 '[\\dA-PR-TZcf-nq-uy=><~]))', 'g',
 '(?:\\u001B\\][\\s\\S]*?(?:\\u0007|\\u001B\\u005C|\\u009C))' +
 '|[\\u001B\\u009B][[\\]()#;?]*' +
 '(?:(?:\\d{1,4}(?:;\\d{0,4})*)?' +

This comment was marked as spam.

Sign in to view
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
e3d3cb8 to
9da6ef2CompareJuly 8, 2026 05:40
@dushyant-hada-90
dushyant-hada-90
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Pushed updates addressing the feedback:
Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines

Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case
Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.

Ready for another look
avivkeller
avivkeller
reviewed
Jul 20, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
2 times, most recently
from
711b204 to
7a426b8CompareJuly 20, 2026 17:37
@dushyant-hada-90
dushyant-hada-90
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @Archkon, @avivkeller

I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!
avivkeller
avivkeller
reviewed
Jul 24, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 25, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 25, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75131/
@codecov
codecovBot
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (00917ba) to head (8bcabf1).
⚠️ Report is 562 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64319 +/- ##
========================================
Coverage 90.14% 90.14% ========================================
Files 741 744 +3 Lines 242076 242516 +440 Branches 45558 45691 +133 ========================================
+ Hits 218216 218613 +397 - Misses 15385 15409 +24 - Partials 8475 8494 +19 
Files with missing linesCoverage Δ
lib/internal/util/inspect.js96.93% <100.00%> (-0.01%)⬇️
... and 100 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
dushyant-hada-90and others
added 6 commits
July 27, 2026 00:57
@dushyant-hada-90@cursoragent
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0817b0a
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@Archkon
util: use [;:] as CSI parameter separator, matching ansi-regex v6.2.0
273fbfe
Co-authored-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: extend stripVTControlCharacters regression tests
29f6205
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@cursoragent
util: use full ansi-regex commit SHA in comment
20fc79d
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: align CSI regex grouping with ansi-regex
983f681
Remove the extra non-capturing group around CSI parameters and
the final byte so the bundled pattern matches ansi-regex at
72bc570 exactly.
Refs: https://github.com/chalk/ansi-regex/blob/72bc570aaf25fca25541b49c6a8564f3ec63e835/index.js
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
test: clarify unterminated OSC strip comment
8bcabf1
The previous comment claimed truncated OSC sequences were left
unmatched rather than partially stripped. The CSI alternative can
still consume a short prefix, which is why the expected remainder
is 'ttps://...'. Update the comment to describe that behavior.
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
a40efe2 to
8bcabf1CompareJuly 26, 2026 19:29
@dushyant-hada-90
dushyant-hada-90
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.

Kindly re-approve CI when convenient.
@avivkeller
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 29, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75280/
@dushyant-hada-90
dushyant-hada-90
commented
Aug 2, 2026

Copy link


Copy Markdown

ContributorAuthor
Friendly ping,
@Archkon — whenever you have a chance, could you please review and approve this PR if everything looks good? Thank you!
@Archkon

This comment was marked as spam.

Sign in to view
@dushyant-hada-90
dushyant-hada-90
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @aduh95 , can you please have a look at this PR when you have a chance? If everything looks good, I'd appreciate your help getting it landed. Thank you!
@trivikrtrivikr
removed
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 9, 2026
@luantaraschiluantaraschi
mentioned this pull request
Aug 18, 2026
 Open

@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76259/
@trivikrtrivikr
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76335/
@trivikrtrivikr
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5b316e5
into
nodejs:mainAug 24, 2026

84 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5b316e5
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 24, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
c7231f6
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
f644853
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0714ed5
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller approved these changes
@ArchkonArchkonAwaiting requested review from Archkon

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

util.stripVTControlCharacters() fails to strip OSC 8 hyperlinks whose URI contains characters like "("


5 participants

@dushyant-hada-90@nodejs-github-bot@Archkon@avivkeller@trivikr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters - #64319
Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Aug 24, 2026
Merged
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters#64319
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Conversation
@dushyant-hada-90
@dushyant-hada-90dushyant-hada-90
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64313
Summary
The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].
This updates OSC handling to match sequences generically as:
ESC ] ... ST
aligned with ansi-regex v6.2.0.
Problem
stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:
[-a-zA-Z\d/#&.:=?%@~_]
Example:
import{stripVTControlCharacters}from'node:util';constlink='\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';console.log(stripVTControlCharacters(link));
Actual
ttps://example.com/(foo\u0007label
Expected
label
The OSC match terminated early at (, leaving most of the escape sequence in the output.
Changes
  • Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
  • Sync the bundled regex behavior with ansi-regex v6.2.0
  • Preserve existing CSI handling logic
Tests
Added regression coverage in:
test/parallel/test-util-stripvtcontrolcharacters.js
for OSC 8 hyperlinks containing:
  • (
  • )
  • !
  • +
  • [ ]
across all supported OSC string terminators.
Notes
  • Existing CSI handling is unchanged
  • Fast-path behavior is unchanged
  • Embedded OSC terminators inside URIs retain previous behavior
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jul 6, 2026
Archkon
Archkon
reviewed
Jul 7, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

 '[\\dA-PR-TZcf-nq-uy=><~]))', 'g',
 '(?:\\u001B\\][\\s\\S]*?(?:\\u0007|\\u001B\\u005C|\\u009C))' +
 '|[\\u001B\\u009B][[\\]()#;?]*' +
 '(?:(?:\\d{1,4}(?:;\\d{0,4})*)?' +

This comment was marked as spam.

Sign in to view
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
e3d3cb8 to
9da6ef2CompareJuly 8, 2026 05:40
@dushyant-hada-90
dushyant-hada-90
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Pushed updates addressing the feedback:
Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines

Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case
Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.

Ready for another look
avivkeller
avivkeller
reviewed
Jul 20, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
2 times, most recently
from
711b204 to
7a426b8CompareJuly 20, 2026 17:37
@dushyant-hada-90
dushyant-hada-90
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @Archkon, @avivkeller

I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!
avivkeller
avivkeller
reviewed
Jul 24, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 25, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 25, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75131/
@codecov
codecovBot
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (00917ba) to head (8bcabf1).
⚠️ Report is 562 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64319 +/- ##
========================================
Coverage 90.14% 90.14% ========================================
Files 741 744 +3 Lines 242076 242516 +440 Branches 45558 45691 +133 ========================================
+ Hits 218216 218613 +397 - Misses 15385 15409 +24 - Partials 8475 8494 +19 
Files with missing linesCoverage Δ
lib/internal/util/inspect.js96.93% <100.00%> (-0.01%)⬇️
... and 100 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
dushyant-hada-90and others
added 6 commits
July 27, 2026 00:57
@dushyant-hada-90@cursoragent
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0817b0a
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@Archkon
util: use [;:] as CSI parameter separator, matching ansi-regex v6.2.0
273fbfe
Co-authored-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: extend stripVTControlCharacters regression tests
29f6205
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@cursoragent
util: use full ansi-regex commit SHA in comment
20fc79d
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: align CSI regex grouping with ansi-regex
983f681
Remove the extra non-capturing group around CSI parameters and
the final byte so the bundled pattern matches ansi-regex at
72bc570 exactly.
Refs: https://github.com/chalk/ansi-regex/blob/72bc570aaf25fca25541b49c6a8564f3ec63e835/index.js
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
test: clarify unterminated OSC strip comment
8bcabf1
The previous comment claimed truncated OSC sequences were left
unmatched rather than partially stripped. The CSI alternative can
still consume a short prefix, which is why the expected remainder
is 'ttps://...'. Update the comment to describe that behavior.
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
a40efe2 to
8bcabf1CompareJuly 26, 2026 19:29
@dushyant-hada-90
dushyant-hada-90
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.

Kindly re-approve CI when convenient.
@avivkeller
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 29, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75280/
@dushyant-hada-90
dushyant-hada-90
commented
Aug 2, 2026

Copy link


Copy Markdown

ContributorAuthor
Friendly ping,
@Archkon — whenever you have a chance, could you please review and approve this PR if everything looks good? Thank you!
@Archkon

This comment was marked as spam.

Sign in to view
@dushyant-hada-90
dushyant-hada-90
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @aduh95 , can you please have a look at this PR when you have a chance? If everything looks good, I'd appreciate your help getting it landed. Thank you!
@trivikrtrivikr
removed
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 9, 2026
@luantaraschiluantaraschi
mentioned this pull request
Aug 18, 2026
 Open

@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76259/
@trivikrtrivikr
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76335/
@trivikrtrivikr
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5b316e5
into
nodejs:mainAug 24, 2026

84 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5b316e5
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 24, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
c7231f6
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
f644853
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0714ed5
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller approved these changes
@ArchkonArchkonAwaiting requested review from Archkon

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

util.stripVTControlCharacters() fails to strip OSC 8 hyperlinks whose URI contains characters like "("


5 participants

@dushyant-hada-90@nodejs-github-bot@Archkon@avivkeller@trivikr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters - #64319
Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Aug 24, 2026
Merged
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters#64319
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Conversation
@dushyant-hada-90
@dushyant-hada-90dushyant-hada-90
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64313
Summary
The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].
This updates OSC handling to match sequences generically as:
ESC ] ... ST
aligned with ansi-regex v6.2.0.
Problem
stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:
[-a-zA-Z\d/#&.:=?%@~_]
Example:
import{stripVTControlCharacters}from'node:util';constlink='\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';console.log(stripVTControlCharacters(link));
Actual
ttps://example.com/(foo\u0007label
Expected
label
The OSC match terminated early at (, leaving most of the escape sequence in the output.
Changes
  • Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
  • Sync the bundled regex behavior with ansi-regex v6.2.0
  • Preserve existing CSI handling logic
Tests
Added regression coverage in:
test/parallel/test-util-stripvtcontrolcharacters.js
for OSC 8 hyperlinks containing:
  • (
  • )
  • !
  • +
  • [ ]
across all supported OSC string terminators.
Notes
  • Existing CSI handling is unchanged
  • Fast-path behavior is unchanged
  • Embedded OSC terminators inside URIs retain previous behavior
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jul 6, 2026
Archkon
Archkon
reviewed
Jul 7, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

 '[\\dA-PR-TZcf-nq-uy=><~]))', 'g',
 '(?:\\u001B\\][\\s\\S]*?(?:\\u0007|\\u001B\\u005C|\\u009C))' +
 '|[\\u001B\\u009B][[\\]()#;?]*' +
 '(?:(?:\\d{1,4}(?:;\\d{0,4})*)?' +

This comment was marked as spam.

Sign in to view
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
e3d3cb8 to
9da6ef2CompareJuly 8, 2026 05:40
@dushyant-hada-90
dushyant-hada-90
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Pushed updates addressing the feedback:
Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines

Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case
Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.

Ready for another look
avivkeller
avivkeller
reviewed
Jul 20, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
2 times, most recently
from
711b204 to
7a426b8CompareJuly 20, 2026 17:37
@dushyant-hada-90
dushyant-hada-90
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @Archkon, @avivkeller

I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!
avivkeller
avivkeller
reviewed
Jul 24, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 25, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 25, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75131/
@codecov
codecovBot
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (00917ba) to head (8bcabf1).
⚠️ Report is 562 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64319 +/- ##
========================================
Coverage 90.14% 90.14% ========================================
Files 741 744 +3 Lines 242076 242516 +440 Branches 45558 45691 +133 ========================================
+ Hits 218216 218613 +397 - Misses 15385 15409 +24 - Partials 8475 8494 +19 
Files with missing linesCoverage Δ
lib/internal/util/inspect.js96.93% <100.00%> (-0.01%)⬇️
... and 100 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
dushyant-hada-90and others
added 6 commits
July 27, 2026 00:57
@dushyant-hada-90@cursoragent
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0817b0a
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@Archkon
util: use [;:] as CSI parameter separator, matching ansi-regex v6.2.0
273fbfe
Co-authored-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: extend stripVTControlCharacters regression tests
29f6205
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@cursoragent
util: use full ansi-regex commit SHA in comment
20fc79d
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: align CSI regex grouping with ansi-regex
983f681
Remove the extra non-capturing group around CSI parameters and
the final byte so the bundled pattern matches ansi-regex at
72bc570 exactly.
Refs: https://github.com/chalk/ansi-regex/blob/72bc570aaf25fca25541b49c6a8564f3ec63e835/index.js
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
test: clarify unterminated OSC strip comment
8bcabf1
The previous comment claimed truncated OSC sequences were left
unmatched rather than partially stripped. The CSI alternative can
still consume a short prefix, which is why the expected remainder
is 'ttps://...'. Update the comment to describe that behavior.
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
a40efe2 to
8bcabf1CompareJuly 26, 2026 19:29
@dushyant-hada-90
dushyant-hada-90
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.

Kindly re-approve CI when convenient.
@avivkeller
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 29, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75280/
@dushyant-hada-90
dushyant-hada-90
commented
Aug 2, 2026

Copy link


Copy Markdown

ContributorAuthor
Friendly ping,
@Archkon — whenever you have a chance, could you please review and approve this PR if everything looks good? Thank you!
@Archkon

This comment was marked as spam.

Sign in to view
@dushyant-hada-90
dushyant-hada-90
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @aduh95 , can you please have a look at this PR when you have a chance? If everything looks good, I'd appreciate your help getting it landed. Thank you!
@trivikrtrivikr
removed
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 9, 2026
@luantaraschiluantaraschi
mentioned this pull request
Aug 18, 2026
 Open

@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76259/
@trivikrtrivikr
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76335/
@trivikrtrivikr
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5b316e5
into
nodejs:mainAug 24, 2026

84 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5b316e5
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 24, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
c7231f6
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
f644853
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0714ed5
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller approved these changes
@ArchkonArchkonAwaiting requested review from Archkon

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

util.stripVTControlCharacters() fails to strip OSC 8 hyperlinks whose URI contains characters like "("


5 participants

@dushyant-hada-90@nodejs-github-bot@Archkon@avivkeller@trivikr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters - #64319
Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Aug 24, 2026
Merged
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters#64319
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Conversation
@dushyant-hada-90
@dushyant-hada-90dushyant-hada-90
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64313
Summary
The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].
This updates OSC handling to match sequences generically as:
ESC ] ... ST
aligned with ansi-regex v6.2.0.
Problem
stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:
[-a-zA-Z\d/#&.:=?%@~_]
Example:
import{stripVTControlCharacters}from'node:util';constlink='\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';console.log(stripVTControlCharacters(link));
Actual
ttps://example.com/(foo\u0007label
Expected
label
The OSC match terminated early at (, leaving most of the escape sequence in the output.
Changes
  • Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
  • Sync the bundled regex behavior with ansi-regex v6.2.0
  • Preserve existing CSI handling logic
Tests
Added regression coverage in:
test/parallel/test-util-stripvtcontrolcharacters.js
for OSC 8 hyperlinks containing:
  • (
  • )
  • !
  • +
  • [ ]
across all supported OSC string terminators.
Notes
  • Existing CSI handling is unchanged
  • Fast-path behavior is unchanged
  • Embedded OSC terminators inside URIs retain previous behavior
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jul 6, 2026
Archkon
Archkon
reviewed
Jul 7, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

 '[\\dA-PR-TZcf-nq-uy=><~]))', 'g',
 '(?:\\u001B\\][\\s\\S]*?(?:\\u0007|\\u001B\\u005C|\\u009C))' +
 '|[\\u001B\\u009B][[\\]()#;?]*' +
 '(?:(?:\\d{1,4}(?:;\\d{0,4})*)?' +

This comment was marked as spam.

Sign in to view
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
e3d3cb8 to
9da6ef2CompareJuly 8, 2026 05:40
@dushyant-hada-90
dushyant-hada-90
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Pushed updates addressing the feedback:
Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines

Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case
Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.

Ready for another look
avivkeller
avivkeller
reviewed
Jul 20, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
2 times, most recently
from
711b204 to
7a426b8CompareJuly 20, 2026 17:37
@dushyant-hada-90
dushyant-hada-90
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @Archkon, @avivkeller

I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!
avivkeller
avivkeller
reviewed
Jul 24, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 25, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 25, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75131/
@codecov
codecovBot
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (00917ba) to head (8bcabf1).
⚠️ Report is 562 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64319 +/- ##
========================================
Coverage 90.14% 90.14% ========================================
Files 741 744 +3 Lines 242076 242516 +440 Branches 45558 45691 +133 ========================================
+ Hits 218216 218613 +397 - Misses 15385 15409 +24 - Partials 8475 8494 +19 
Files with missing linesCoverage Δ
lib/internal/util/inspect.js96.93% <100.00%> (-0.01%)⬇️
... and 100 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
dushyant-hada-90and others
added 6 commits
July 27, 2026 00:57
@dushyant-hada-90@cursoragent
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0817b0a
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@Archkon
util: use [;:] as CSI parameter separator, matching ansi-regex v6.2.0
273fbfe
Co-authored-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: extend stripVTControlCharacters regression tests
29f6205
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@cursoragent
util: use full ansi-regex commit SHA in comment
20fc79d
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: align CSI regex grouping with ansi-regex
983f681
Remove the extra non-capturing group around CSI parameters and
the final byte so the bundled pattern matches ansi-regex at
72bc570 exactly.
Refs: https://github.com/chalk/ansi-regex/blob/72bc570aaf25fca25541b49c6a8564f3ec63e835/index.js
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
test: clarify unterminated OSC strip comment
8bcabf1
The previous comment claimed truncated OSC sequences were left
unmatched rather than partially stripped. The CSI alternative can
still consume a short prefix, which is why the expected remainder
is 'ttps://...'. Update the comment to describe that behavior.
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
a40efe2 to
8bcabf1CompareJuly 26, 2026 19:29
@dushyant-hada-90
dushyant-hada-90
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.

Kindly re-approve CI when convenient.
@avivkeller
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 29, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75280/
@dushyant-hada-90
dushyant-hada-90
commented
Aug 2, 2026

Copy link


Copy Markdown

ContributorAuthor
Friendly ping,
@Archkon — whenever you have a chance, could you please review and approve this PR if everything looks good? Thank you!
@Archkon

This comment was marked as spam.

Sign in to view
@dushyant-hada-90
dushyant-hada-90
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @aduh95 , can you please have a look at this PR when you have a chance? If everything looks good, I'd appreciate your help getting it landed. Thank you!
@trivikrtrivikr
removed
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 9, 2026
@luantaraschiluantaraschi
mentioned this pull request
Aug 18, 2026
 Open

@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76259/
@trivikrtrivikr
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76335/
@trivikrtrivikr
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5b316e5
into
nodejs:mainAug 24, 2026

84 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5b316e5
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 24, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
c7231f6
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
f644853
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0714ed5
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller approved these changes
@ArchkonArchkonAwaiting requested review from Archkon

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

util.stripVTControlCharacters() fails to strip OSC 8 hyperlinks whose URI contains characters like "("


5 participants

@dushyant-hada-90@nodejs-github-bot@Archkon@avivkeller@trivikr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters - #64319
Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Aug 24, 2026
Merged
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters#64319
nodejs-github-bot merged 6 commits into
nodejs:mainfrom 
dushyant-hada-90:fix/strip-vt-osc-8-uri-chars
Conversation
@dushyant-hada-90
@dushyant-hada-90dushyant-hada-90
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64313
Summary
The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].
This updates OSC handling to match sequences generically as:
ESC ] ... ST
aligned with ansi-regex v6.2.0.
Problem
stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:
[-a-zA-Z\d/#&.:=?%@~_]
Example:
import{stripVTControlCharacters}from'node:util';constlink='\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';console.log(stripVTControlCharacters(link));
Actual
ttps://example.com/(foo\u0007label
Expected
label
The OSC match terminated early at (, leaving most of the escape sequence in the output.
Changes
  • Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
  • Sync the bundled regex behavior with ansi-regex v6.2.0
  • Preserve existing CSI handling logic
Tests
Added regression coverage in:
test/parallel/test-util-stripvtcontrolcharacters.js
for OSC 8 hyperlinks containing:
  • (
  • )
  • !
  • +
  • [ ]
across all supported OSC string terminators.
Notes
  • Existing CSI handling is unchanged
  • Fast-path behavior is unchanged
  • Embedded OSC terminators inside URIs retain previous behavior
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jul 6, 2026
Archkon
Archkon
reviewed
Jul 7, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

 '[\\dA-PR-TZcf-nq-uy=><~]))', 'g',
 '(?:\\u001B\\][\\s\\S]*?(?:\\u0007|\\u001B\\u005C|\\u009C))' +
 '|[\\u001B\\u009B][[\\]()#;?]*' +
 '(?:(?:\\d{1,4}(?:;\\d{0,4})*)?' +

This comment was marked as spam.

Sign in to view
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
e3d3cb8 to
9da6ef2CompareJuly 8, 2026 05:40
@dushyant-hada-90
dushyant-hada-90
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Pushed updates addressing the feedback:
Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines

Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case
Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.

Ready for another look
avivkeller
avivkeller
reviewed
Jul 20, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
Outdated

@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
2 times, most recently
from
711b204 to
7a426b8CompareJuly 20, 2026 17:37
@dushyant-hada-90
dushyant-hada-90
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @Archkon, @avivkeller

I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!
avivkeller
avivkeller
reviewed
Jul 24, 2026
View reviewed changes
Comment threadlib/internal/util/inspect.js
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 25, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 25, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75131/
@codecov
codecovBot
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (00917ba) to head (8bcabf1).
⚠️ Report is 562 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64319 +/- ##
========================================
Coverage 90.14% 90.14% ========================================
Files 741 744 +3 Lines 242076 242516 +440 Branches 45558 45691 +133 ========================================
+ Hits 218216 218613 +397 - Misses 15385 15409 +24 - Partials 8475 8494 +19 
Files with missing linesCoverage Δ
lib/internal/util/inspect.js96.93% <100.00%> (-0.01%)⬇️
... and 100 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
dushyant-hada-90and others
added 6 commits
July 27, 2026 00:57
@dushyant-hada-90@cursoragent
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0817b0a
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@Archkon
util: use [;:] as CSI parameter separator, matching ansi-regex v6.2.0
273fbfe
Co-authored-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: extend stripVTControlCharacters regression tests
29f6205
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90@cursoragent
util: use full ansi-regex commit SHA in comment
20fc79d
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
util: align CSI regex grouping with ansi-regex
983f681
Remove the extra non-capturing group around CSI parameters and
the final byte so the bundled pattern matches ansi-regex at
72bc570 exactly.
Refs: https://github.com/chalk/ansi-regex/blob/72bc570aaf25fca25541b49c6a8564f3ec63e835/index.js
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
test: clarify unterminated OSC strip comment
8bcabf1
The previous comment claimed truncated OSC sequences were left
unmatched rather than partially stripped. The CSI alternative can
still consume a short prefix, which is why the expected remainder
is 'ttps://...'. Update the comment to describe that behavior.
Signed-off-by: dushyant <dushyanthada90@gmail.com>
@dushyant-hada-90
dushyant-hada-90force-pushed
the
fix/strip-vt-osc-8-uri-chars
branch
from
a40efe2 to
8bcabf1CompareJuly 26, 2026 19:29
@dushyant-hada-90
dushyant-hada-90
commented
Jul 26, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.

Kindly re-approve CI when convenient.
@avivkeller
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 29, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 29, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75280/
@dushyant-hada-90
dushyant-hada-90
commented
Aug 2, 2026

Copy link


Copy Markdown

ContributorAuthor
Friendly ping,
@Archkon — whenever you have a chance, could you please review and approve this PR if everything looks good? Thank you!
@Archkon

This comment was marked as spam.

Sign in to view
@dushyant-hada-90
dushyant-hada-90
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Hi @aduh95 , can you please have a look at this PR when you have a chance? If everything looks good, I'd appreciate your help getting it landed. Thank you!
@trivikrtrivikr
removed
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 9, 2026
@luantaraschiluantaraschi
mentioned this pull request
Aug 18, 2026
 Open

@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76259/
@trivikrtrivikr
added
the 
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
label
Aug 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76335/
@trivikrtrivikr
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5b316e5
into
nodejs:mainAug 24, 2026

84 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 24, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5b316e5
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 24, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
c7231f6
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
f644853
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@dushyant-hada-90@cursoragent@aduh95
util: fix OSC 8 hyperlink stripping in stripVTControlCharacters
0714ed5
The bundled ansi-regex OSC pattern used a restrictive URI
character class that failed when URIs contained RFC 3986-valid
characters such as parentheses.
Match OSC sequences generically as ESC ] ... ST, aligned with
ansi-regex v6.2.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: dushyant <dushyanthada90@gmail.com>
PR-URL: #64319Fixes: #64313
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller approved these changes
@ArchkonArchkonAwaiting requested review from Archkon

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

util.stripVTControlCharacters() fails to strip OSC 8 hyperlinks whose URI contains characters like "("


5 participants

@dushyant-hada-90@nodejs-github-bot@Archkon@avivkeller@trivikr