Skip to content

deps: update c-ares to 1.34.8 - #64330

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/truetools-update-c-ares
Jul 8, 2026
Merged

deps: update c-ares to 1.34.8#64330
nodejs-github-bot merged 1 commit into
mainfrom
actions/truetools-update-c-ares

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Jul 6, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of c-ares to 1.34.8.

@nodejs-github-botnodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. labels Jul 6, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 6, 2026
@aduh95

aduh95 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
../src/cares_wrap.cc:1740:3: error: no matching function for call to 'ares_gethostbyaddr'
1740 | ares_gethostbyaddr(wrap->channel()->cares_channel(),
| ^~~~~~~~~~~~~~~~~~
../deps/cares/include/ares.h:887:19: note: candidate function not viable: no overload of 'Callback' matching 'ares_host_callback' (aka 'void (*)(void *, int, int, const struct hostent *)') for 5th argument
887 | CARES_EXTERN void ares_gethostbyaddr(ares_channel_t *channel, const void *addr,
| ^
888 | int addrlen, int family,
889 | ares_host_callback callback, void *arg);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~

@nodejs-github-bot
nodejs-github-botforce-pushed the actions/truetools-update-c-ares branch from 9ecba3f to fe01db0CompareJuly 8, 2026 08:14
@nodejs-github-botnodejs-github-bot changed the title deps: update c-ares to 1.34.7deps: update c-ares to 1.34.8Jul 8, 2026
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 8, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2026

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/74655/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2026
@richardlaurichardlau added lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Jul 8, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2026
@nodejs-github-bot
nodejs-github-bot merged commit a18052e into mainJul 8, 2026
71 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Landed in a18052e

@nodejs-github-bot
nodejs-github-bot deleted the actions/truetools-update-c-ares branch July 8, 2026 18:54
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 19, 2026
@nodejs-github-bot@juanarbol
deps: update c-ares to 1.34.8
2b85c06
PR-URL: nodejs#64330
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@juanarboljuanarbol removed the lts-watch-v22.x PRs that may need to be released in v22.x label Jul 19, 2026
juanarbol pushed a commit that referenced this pull request Jul 19, 2026
@nodejs-github-bot@juanarbol
deps: update c-ares to 1.34.8
266073a
PR-URL: #64330
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95 removed the lts-watch-v24.x PRs that may need to be released in v24.x label Jul 21, 2026
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@nodejs-github-bot@aduh95
deps: update c-ares to 1.34.8
bbbe223
PR-URL: #64330
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
@nodejs-github-bot@RafaelGSS
deps: update c-ares to 1.34.8
c097012
PR-URL: #64330
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
marco-ippolito pushed a commit that referenced this pull request Jul 29, 2026
@nodejs-github-bot@marco-ippolito
deps: update c-ares to 1.34.8
400e833
PR-URL: #64330
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@nodejs-github-bot@aduh95
deps: update c-ares to 1.34.8
215105e
PR-URL: #64330
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nodejs-github-bot@aduh95@richardlau@juanarbol